This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 46e623e885 BZ 69477: Wrong 'allowedInternalProxies' param name in the
Remote IP Filter documentation (#786)
46e623e885 is described below
commit 46e623e8850bc0ba1dc2219af46b1f900a9d6fae
Author: Jorge Díaz <[email protected]>
AuthorDate: Wed Nov 27 12:49:20 2024 +0100
BZ 69477: Wrong 'allowedInternalProxies' param name in the Remote IP Filter
documentation (#786)
* BZ 69477: Correct wrong 'allowedInternalProxies' parameter in Remote IP
Filter documentation
* BZ 69477: Add missing filter-mapping sections in some of the
RemoteIpFilter examples
---
webapps/docs/config/filter.xml | 40 ++++++++++++++++++++++++++++++++--------
1 file changed, 32 insertions(+), 8 deletions(-)
diff --git a/webapps/docs/config/filter.xml b/webapps/docs/config/filter.xml
index 753e8bd8a8..5a879727ab 100644
--- a/webapps/docs/config/filter.xml
+++ b/webapps/docs/config/filter.xml
@@ -1447,7 +1447,7 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<filter-name>RemoteIpFilter</filter-name>
<filter-class>org.apache.catalina.filters.RemoteIpFilter</filter-class>
<init-param>
- <param-name>allowedInternalProxies</param-name>
+ <param-name>internalProxies</param-name>
<param-value>192\.168\.0\.10|192\.168\.0\.11</param-value>
</init-param>
<init-param>
@@ -1462,7 +1462,13 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<param-name>protocolHeader</param-name>
<param-value>x-forwarded-proto</param-value>
</init-param>
- </filter>]]></source>
+ </filter>
+
+ <filter-mapping>
+ <filter-name>RemoteIpFilter</filter-name>
+ <url-pattern>/*</url-pattern>
+ <dispatcher>REQUEST</dispatcher>
+ </filter-mapping>]]></source>
<p>Request values:</p>
<table class="defaultTable">
<tr>
@@ -1522,7 +1528,7 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<filter-name>RemoteIpFilter</filter-name>
<filter-class>org.apache.catalina.filters.RemoteIpFilter</filter-class>
<init-param>
- <param-name>allowedInternalProxies</param-name>
+ <param-name>internalProxies</param-name>
<param-value>192\.168\.0\.10|192\.168\.0\.11</param-value>
</init-param>
<init-param>
@@ -1537,7 +1543,13 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<param-name>trustedProxies</param-name>
<param-value>proxy1|proxy2</param-value>
</init-param>
- </filter>]]></source>
+ </filter>
+
+ <filter-mapping>
+ <filter-name>RemoteIpFilter</filter-name>
+ <url-pattern>/*</url-pattern>
+ <dispatcher>REQUEST</dispatcher>
+ </filter-mapping>]]></source>
<p>Request values:</p>
<table class="defaultTable">
<tr>
@@ -1576,7 +1588,7 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<filter-name>RemoteIpFilter</filter-name>
<filter-class>org.apache.catalina.filters.RemoteIpFilter</filter-class>
<init-param>
- <param-name>allowedInternalProxies</param-name>
+ <param-name>internalProxies</param-name>
<param-value>192\.168\.0\.10|192\.168\.0\.11</param-value>
</init-param>
<init-param>
@@ -1591,7 +1603,13 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<param-name>trustedProxies</param-name>
<param-value>proxy1|proxy2</param-value>
</init-param>
- </filter>]]></source>
+ </filter>
+
+ <filter-mapping>
+ <filter-name>RemoteIpFilter</filter-name>
+ <url-pattern>/*</url-pattern>
+ <dispatcher>REQUEST</dispatcher>
+ </filter-mapping>]]></source>
<p>Request values:</p>
<table class="defaultTable">
<tr>
@@ -1633,7 +1651,7 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<filter-name>RemoteIpFilter</filter-name>
<filter-class>org.apache.catalina.filters.RemoteIpFilter</filter-class>
<init-param>
- <param-name>allowedInternalProxies</param-name>
+ <param-name>internalProxies</param-name>
<param-value>192\.168\.0\.10|192\.168\.0\.11</param-value>
</init-param>
<init-param>
@@ -1648,7 +1666,13 @@ FINE: Request "/docs/config/manager.html" with response
status "200"
<param-name>trustedProxies</param-name>
<param-value>proxy1|proxy2</param-value>
</init-param>
- </filter>]]></source>
+ </filter>
+
+ <filter-mapping>
+ <filter-name>RemoteIpFilter</filter-name>
+ <url-pattern>/*</url-pattern>
+ <dispatcher>REQUEST</dispatcher>
+ </filter-mapping>]]></source>
<p>Request values:</p>
<table class="defaultTable">
<tr>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
