Re: [PR] Report HTTP/2 header parsing errors earlier [tomcat]

2024-10-09 Thread via GitHub
n828cl commented on PR #762: URL: https://github.com/apache/tomcat/pull/762#issuecomment-2404044482 As previously stated, the 10.0.x branch is well past end-of-life (over three years ago); there will be no further updates to this level. Anyone not updating a product in that length of time c

Re: [PR] Report HTTP/2 header parsing errors earlier [tomcat]

2024-10-09 Thread via GitHub
n828cl closed pull request #762: Report HTTP/2 header parsing errors earlier URL: https://github.com/apache/tomcat/pull/762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] Report HTTP/2 header parsing errors earlier [tomcat]

2024-10-09 Thread via GitHub
LQxdu commented on PR #762: URL: https://github.com/apache/tomcat/pull/762#issuecomment-2404037105 During a recent network asset mapping assessment, we identified that a significant number of services are still deployed on Tomcat 10.0.x. Given the continued widespread use of this version, w

Re: [PR] Report HTTP/2 header parsing errors earlier [tomcat]

2024-10-09 Thread via GitHub
isapir commented on PR #762: URL: https://github.com/apache/tomcat/pull/762#issuecomment-2403933166 Is there a reason you are using Tomcat 10.0 and not Tomcat 10.1? Tomcat 10.0 is no longer supported See https://tomcat.apache.org/tomcat-10.0-eol.html -- This is an automated messa

Re: [PR] Allow applications to trigger sending of 103 early hints [tomcat]

2024-10-09 Thread via GitHub
isapir commented on code in PR #761: URL: https://github.com/apache/tomcat/pull/761#discussion_r1794578764 ## java/org/apache/catalina/connector/Response.java: ## @@ -1209,7 +1213,11 @@ public void setStatus(int status) { return; } -getCoyoteRespo

Re: [PR] Allow applications to trigger sending of 103 early hints [tomcat]

2024-10-09 Thread via GitHub
isapir commented on code in PR #761: URL: https://github.com/apache/tomcat/pull/761#discussion_r1794575451 ## java/org/apache/catalina/connector/Response.java: ## @@ -1069,16 +1069,20 @@ public void sendError(int status, String message) throws IOException { return;

[PR] Report HTTP/2 header parsing errors earlier [tomcat]

2024-10-09 Thread via GitHub
LQxdu opened a new pull request, #762: URL: https://github.com/apache/tomcat/pull/762 We found that the 10.0.x branch is also affected by CVE-2024-24549(https://github.com/advisories/GHSA-7w75-32cg-r6g2), but it has not been fixed yet. Therefore, we have created this patch for 10.0.x based

[Bug 69387] SPAM SPAM SPAM SPAM

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69387 Chuck Caldarale changed: What|Removed |Added URL|https://glamourmumbai.com/ | Resolution|---

[Bug 69387] The Ultimate Mumbai Escort Service Experience: A Blend of Glamour and Discretion

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69387 --- Comment #2 from Chuck Caldarale --- The content of attachment 39900 has been deleted for the following reason: Spam -- You are receiving this mail because: You are the assignee for the bug. ---

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
isapir commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403740181 Oh, I see the code that you use to benchmark in the PR. Have you tried to run an external tool like `ab` or `wrk2`? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
isapir commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403736338 > In Performance Test, request client threads have sleep ops. Why? Can those be removed? > Average cost of each rateLimiter is about 3500ns. The difference in time cost between F

[Bug 69387] The Ultimate Mumbai Escort Service Experience: A Blend of Glamour and Discretion

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69387 Madhavi Singh changed: What|Removed |Added URL||https://glamourmumbai.com/

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
Chenjp commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2403720730 > The performance results look odd to me. I'd expect throughput to be significantly higher in all cases. I wonder if the request processing time is dominating the results rather than any over

Re: svn commit: r1921212 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2024-10-09 Thread Christopher Schultz
Mark, On 10/9/24 13:05, ma...@apache.org wrote: Author: markt Date: Wed Oct 9 17:05:58 2024 New Revision: 1921212 URL: http://svn.apache.org/viewvc?rev=1921212&view=rev Log: Fix typo Oops, thanks. -chris Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.

Re: [PR] Allow applications to trigger sending of 103 early hints [tomcat]

2024-10-09 Thread via GitHub
ChristopherSchultz commented on PR #761: URL: https://github.com/apache/tomcat/pull/761#issuecomment-2402893460 I noticed that `Response` does some things that `ResponseFacade` does not. Specifically, it is sensitive to whether or not there is an *include* in progress. However, if the `Resp

[PR] Allow applications to trigger sending of 103 early hints [tomcat]

2024-10-09 Thread via GitHub
ChristopherSchultz opened a new pull request, #761: URL: https://github.com/apache/tomcat/pull/761 Use sendError(103) or setStatus(103). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

svn commit: r1921212 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2024-10-09 Thread markt
Author: markt Date: Wed Oct 9 17:05:58 2024 New Revision: 1921212 URL: http://svn.apache.org/viewvc?rev=1921212&view=rev Log: Fix typo Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.org/vi

svn commit: r1921211 [9/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/security.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/security.html (original) +++ t

svn commit: r1921211 [10/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/tomcat-85-eol.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/tomcat-85-eol.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/tomcat-85-eol.html (

svn commit: r1921211 [8/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/security-8.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-8.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/security-8.html (original)

svn commit: r1921211 [5/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2010.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2010.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/oldnews-2010.html (ori

svn commit: r1921211 [3/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/index.html (original) +++ tomcat/sit

svn commit: r1921211 [6/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/oldnews-2018.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/oldnews-2018.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/oldnews-2018.html (ori

svn commit: r1921211 [7/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/resources.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/resources.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/resources.html (original) ++

svn commit: r1921211 [1/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Author: markt Date: Wed Oct 9 17:02:30 2024 New Revision: 1921211 URL: http://svn.apache.org/viewvc?rev=1921211&view=rev Log: Update site for 11.0.0 release (including removal of beta tag) Modified: tomcat/site/trunk/build.properties.default tomcat/site/trunk/docs/bugreport.html tomc

svn commit: r1921211 [4/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/migration-11.0.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-11.0.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/migration-11.0.htm

svn commit: r1921211 [2/10] - in /tomcat/site/trunk: ./ docs/ tools/ xdocs/ xdocs/stylesheets/

2024-10-09 Thread markt
Modified: tomcat/site/trunk/docs/download-connectors.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-connectors.html?rev=1921211&r1=1921210&r2=1921211&view=diff == --- tomcat/site/trunk/docs/download

svn commit: r1921210 - in /tomcat/site/trunk/docs/tomcat-11.0-doc: ./ annotationapi/ annotationapi/jakarta/annotation/ annotationapi/jakarta/annotation/security/ annotationapi/jakarta/annotation/sql/

2024-10-09 Thread markt
Author: markt Date: Wed Oct 9 17:01:01 2024 New Revision: 1921210 URL: http://svn.apache.org/viewvc?rev=1921210&view=rev Log: Update docs for 11.0.0 release [This commit notification would consist of 65 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] --

svn commit: r72230 - /dev/tomcat/tomcat-11/v11.0.0/ /release/tomcat/tomcat-11/v11.0.0/

2024-10-09 Thread markt
Author: markt Date: Wed Oct 9 16:36:37 2024 New Revision: 72230 Log: Release Tomcat 11.0.0 Added: release/tomcat/tomcat-11/v11.0.0/ - copied from r72229, dev/tomcat/tomcat-11/v11.0.0/ Removed: dev/tomcat/tomcat-11/v11.0.0/ -

Re: [VOTE][RESULT] Release Apache Tomcat 11.0.0

2024-10-09 Thread Mark Thomas
The following votes were cast: Binding: +1: isapir, remm, ebourg, schultz, rjung, fschumacher, markt Non-binding: +1: dsoumis No other votes were cast. The vote therefore passes. Thanks to everyone who contributed to this release. Mark ---

Re: [VOTE] Release Apache Tomcat 11.0.0

2024-10-09 Thread Mark Thomas
On 03/10/2024 11:58, Mark Thomas wrote: The proposed 11.0.0 release is: [ ] -1 Broken - do not release [X] +1 Stable - go ahead and release as 11.0.0 +1 Tests pass on: - Linux (OpenSSL 3.0.13 from Ubuntu 24.04) - Windows (OpenSSL 3.0.14 - Native 2.0.8 binaries) - MacOS (Intel) (OpenSSL 3.3.1)

[Bug 69377] JSP optimization via custom code generation

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #3 from John Engebretson --- Thank you! I've enabled it locally and immediately ran into some edge case bugs causing a few JSPs to fail compilation. I'll work through those and contribute fixes on this ticket. -- You are receivi

svn commit: r72227 - /release/tomcat/tomcat-10/v10.1.30/

2024-10-09 Thread schultz
Author: schultz Date: Wed Oct 9 15:45:08 2024 New Revision: 72227 Log: Drop old release artifact Removed: release/tomcat/tomcat-10/v10.1.30/ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional comman

svn commit: r1921209 - in /tomcat/site/trunk: ./ docs/ docs/tomcat-10.1-doc/ docs/tomcat-10.1-doc/annotationapi/ docs/tomcat-10.1-doc/annotationapi/jakarta/annotation/ docs/tomcat-10.1-doc/annotationa

2024-10-09 Thread schultz
Author: schultz Date: Wed Oct 9 15:44:46 2024 New Revision: 1921209 URL: http://svn.apache.org/viewvc?rev=1921209&view=rev Log: Announce v10.1.31 release. [This commit notification would consist of 66 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.]

(tomcat) branch 10.1.x updated: Add release date

2024-10-09 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new f15366cc25 Add release date f15366cc25 is descr

Re: [VOTE] Release Apache Tomcat 10.1.31

2024-10-09 Thread Rémy Maucherat
On Wed, Oct 9, 2024 at 5:20 PM Christopher Schultz wrote: > > All, > > On 10/3/24 17:35, Christopher Schultz wrote: > > The proposed Apache Tomcat 10.1.31 release is now available for > > voting. > > > > All committers and PMC members are kindly requested to provide a vote if > > possible. ANY TOM

svn commit: r72226 - /dev/tomcat/tomcat-10/v10.1.31/ /release/tomcat/tomcat-10/v10.1.31/

2024-10-09 Thread schultz
Author: schultz Date: Wed Oct 9 15:25:10 2024 New Revision: 72226 Log: Promose v10.1.31 to released. Added: release/tomcat/tomcat-10/v10.1.31/ - copied from r72225, dev/tomcat/tomcat-10/v10.1.31/ Removed: dev/tomcat/tomcat-10/v10.1.31/

[VOTE][RESULT] Release Apache Tomcat 10.1.31

2024-10-09 Thread Christopher Schultz
All, The following votes were cast: +1: isapir, remm, markt, rjung, fschumacher, schultz Non-binding: +1: dsoumis No other votes were cast, therefore the vote passes. Thanks to everyone who contributed toward this release. And Happy Birthday! -chris On 10/3/24 17:35, Christopher Schultz w

(tomcat) branch main updated: Update

2024-10-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 8e90a82759 Update 8e90a82759 is described below commi

Re: [VOTE] Release Apache Tomcat 10.1.31

2024-10-09 Thread Christopher Schultz
All, On 10/3/24 17:35, Christopher Schultz wrote: The proposed Apache Tomcat 10.1.31 release is now available for voting. All committers and PMC members are kindly requested to provide a vote if possible. ANY TOMCAT USER MAY VOTE, though only PMC members votes are binding. We welcome non-comm

[Bug 69386] Pre-compiled JSPs result in NoSuchMethodError with latest upgrade

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69386 --- Comment #3 from Remy Maucherat --- The deprecated method will remain in 10.1.x and 9.0.x in the future. However the method is removed in 11.0.x. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 69386] Pre-compiled JSPs result in NoSuchMethodError with latest upgrade

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69386 --- Comment #2 from Jonathon Merz --- Understood, and thank you very much for fixing anyway even though it's not the ideal path! I will assume that the deprecated method won't last long and will get to consolidated dependencies as quickly as po

[Bug 69377] JSP optimization via custom code generation

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #2 from Remy Maucherat --- This is certainly a feature from a long time ago (Tomcat 5). At the time Kin-man did it because JSTL was very very slow. Obviously tags remain an order of magnitude slower than hand crafted code. Anyway,

[Bug 69377] JSP optimization via custom code generation

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69377 --- Comment #1 from John Engebretson --- So, I found my way to TagPluginManager, and the existing code in org.apache.jasper.tagplugins.jstl.core that does exactly what I asked for. Sorry. :) Do I correctly grasp that I need a dedicated XML f

Re: [PR] Added optional X-Request-Id to RemoteIpFilter [tomcat]

2024-10-09 Thread via GitHub
markt-asf commented on PR #758: URL: https://github.com/apache/tomcat/pull/758#issuecomment-2402184594 From memory of previous discussions, implementing Request/Response wrapping in Valves is non-trivial. I'd expose a setter for `requestId`. -- This is an automated message from the Apache

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
Chenjp commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2402162598 > Could the headers follow https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ ? Great! Will look into the spec and implement it tomorrow. -- This is an automated

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
markt-asf commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2402047535 The performance results look odd to me. I'd expect throughput to be significantly higher in all cases. I wonder if the request processing time is dominating the results rather than any ove

Re: [PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
markt-asf commented on PR #760: URL: https://github.com/apache/tomcat/pull/760#issuecomment-2402045763 Could the headers follow https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers/ ? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] BZ69355: RateLimitFilter2 with FixedWindowRateLimiter [tomcat]

2024-10-09 Thread via GitHub
markt-asf commented on PR #757: URL: https://github.com/apache/tomcat/pull/757#issuecomment-2402040291 Closing in favour of new PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] BZ69355: RateLimitFilter2 with FixedWindowRateLimiter [tomcat]

2024-10-09 Thread via GitHub
markt-asf closed pull request #757: BZ69355: RateLimitFilter2 with FixedWindowRateLimiter URL: https://github.com/apache/tomcat/pull/757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Buildbot success in on tomcat-9.0.x

2024-10-09 Thread buildbot
Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/1121 Blamelist: Rainer Jung , remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x] ecd4aa1af00ca055df9f709cd3c88d315b71b0fa Steps: work

Re: [PR] BZ69355: RateLimitFilter2 with FixedWindowRateLimiter [tomcat]

2024-10-09 Thread via GitHub
Chenjp commented on PR #757: URL: https://github.com/apache/tomcat/pull/757#issuecomment-2401707085 new PR #760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[PR] BZ69355: ExactRateLimiter [tomcat]

2024-10-09 Thread via GitHub
Chenjp opened a new pull request, #760: URL: https://github.com/apache/tomcat/pull/760 Original PR: https://github.com/apache/tomcat/pull/757 1. Accurate rate limiter. 2. exposeHeaders - disabled by default, for debugging purpose only. 3. Performance test shows (org.apache.catalina

[Bug 69386] Pre-compiled JSPs result in NoSuchMethodError with latest upgrade

2024-10-09 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=69386 Remy Maucherat changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

(tomcat) branch 9.0.x updated: Add back method as deprecated

2024-10-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new ecd4aa1af0 Add back method as deprecated ecd4aa1af0

(tomcat) branch 10.1.x updated: Add back method as deprecated

2024-10-09 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new cf2ae185c2 Add back method as deprecated cf2ae185c