[GitHub] [tomcat] gksxodnd007 commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

gksxodnd007 commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1414693058 @markt-asf I see the reactor netty code to check how they close the connection when the current request was not fully read. they also close the connection even though that is keep-

[GitHub] [tomcat] tbw777 commented on pull request #581: Speedup by removing non pattern replaceAll with constant arg

tbw777 commented on PR #581: URL: https://github.com/apache/tomcat/pull/581#issuecomment-1414189316 @markt-asf Branch was updated and https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b also Check please. -- This is an automated message from the Apache Git Service. To r

[GitHub] [tomcat] markt-asf commented on a diff in pull request #581: Speedup by removing non pattern replaceAll with constant arg

markt-asf commented on code in PR #581: URL: https://github.com/apache/tomcat/pull/581#discussion_r1094893763 ## java/org/apache/tomcat/buildutil/translate/Utils.java: ## @@ -123,7 +123,7 @@ static String formatValueCommon(String in) { result = ESCAPE_LEADING_SPACE.ma

[GitHub] [tomcat] markt-asf commented on a diff in pull request #581: Speedup by removing non pattern replaceAll with constant arg

markt-asf commented on code in PR #581: URL: https://github.com/apache/tomcat/pull/581#discussion_r1094884701 ## java/org/apache/tomcat/buildutil/translate/Utils.java: ## @@ -123,7 +123,7 @@ static String formatValueCommon(String in) { result = ESCAPE_LEADING_SPACE.ma

[GitHub] [tomcat] tbw777 commented on a diff in pull request #581: Speedup by removing non pattern replaceAll with constant arg

tbw777 commented on code in PR #581: URL: https://github.com/apache/tomcat/pull/581#discussion_r1094863229 ## java/org/apache/tomcat/buildutil/translate/Utils.java: ## @@ -123,7 +123,7 @@ static String formatValueCommon(String in) { result = ESCAPE_LEADING_SPACE.match

[tomcat-native] branch 1.2.x updated: Bump recommended APR version to 1.7.2

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 1.2.x in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/1.2.x by this push: new 8683d31c6 Bump recommended APR version to 1.

[tomcat-native] branch main updated: Bump recommended APR version to 1.7.2

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat-native.git The following commit(s) were added to refs/heads/main by this push: new af2252a10 Bump recommended APR version to 1.7.

[GitHub] [tomcat] markt-asf commented on a diff in pull request #581: Speedup by removing non pattern replaceAll with constant arg

markt-asf commented on code in PR #581: URL: https://github.com/apache/tomcat/pull/581#discussion_r1094835289 ## java/org/apache/tomcat/buildutil/translate/Utils.java: ## @@ -123,7 +123,7 @@ static String formatValueCommon(String in) { result = ESCAPE_LEADING_SPACE.ma

[tomcat] branch 8.5.x updated: Improvements to Korean translations.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 374fc7c648 Improvements to Korean translations. 374

[tomcat] branch 8.5.x updated: Additional i18n strings to support BZ 66196 fix

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 66122f29de Additional i18n strings to support BZ 66

[tomcat] 02/02: Improvements to Korean translations.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2db95575f4177132ad8bdac9ab0dbe65ff0a5254 Author: Mark Thomas AuthorDate: Thu Feb 2 17:03:38 2023 + Improvements t

[tomcat] branch 9.0.x updated (6c05e1cfb5 -> 2db95575f4)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 6c05e1cfb5 Drop xml prolog from DTD as it's not needed and causing the file to be flagged as malformed by xml validator

[tomcat] 01/02: Additional i18n strings to support BZ 66196 fix

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 67045d5b3f8c8d01725b5cd7f8094ea18c1c8333 Author: Mark Thomas AuthorDate: Thu Feb 2 17:02:41 2023 + Additional i18

[tomcat] 01/02: Reformat to simplify back-porting updates

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7bb93e75259bea1e80dc8264b8a8e842af67f40d Author: Mark Thomas AuthorDate: Thu Feb 2 16:23:35 2023 + Reformat to s

[tomcat] 02/02: Improvements to Korean translations

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit c5d0a755ef558d80e30d8d862ae050ebfa0cd207 Author: Mark Thomas AuthorDate: Thu Feb 2 16:56:44 2023 + Improvements

[tomcat] branch 10.1.x updated (0fb9397ff9 -> c5d0a755ef)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git from 0fb9397ff9 Restore ISE catching behavior new 7bb93e7525 Reformat to simplify back-porting updates new c5d0a75

[tomcat] branch main updated: Exclude keys from the backport that differ between 11.0.x and 10.1.x

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 61af113c52 Exclude keys from the backport that differ

Re: [tomcat] branch main updated: Restore ISE catching behavior

On 02/02/2023 09:26, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 10733c4

[tomcat] 04/04: Improvements to Korean translations.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3c710a8919a4b18602338090cf12d6a06935c736 Author: Mark Thomas AuthorDate: Thu Feb 2 14:47:38 2023 + Improvements to

[tomcat] 02/04: Improvements to French translations

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b475c9be3fa2a33f243cddc63db01024cd23502b Author: Mark Thomas AuthorDate: Thu Feb 2 14:43:49 2023 + Improvements to

[tomcat] 03/04: Improvements to Japanese translations. Contributed by tak7iji.

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b7b6dd756c9e9bf92da84ec3a0f6245eb4666511 Author: Mark Thomas AuthorDate: Thu Feb 2 14:45:25 2023 + Improvements to

[tomcat] 01/04: Improvements to Chinese translations

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 1cf60d6e9909f2514641bc65adcb5194f9b02ea7 Author: Mark Thomas AuthorDate: Thu Feb 2 14:42:36 2023 + Improvements to

[tomcat] branch main updated (10733c4228 -> 3c710a8919)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from 10733c4228 Restore ISE catching behavior new 1cf60d6e99 Improvements to Chinese translations new b475c9be3f Imp

Buildbot success in on tomcat-9.0.x

Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/37/builds/441 Blamelist: Coty Sutherland , Mark Thomas Build Text: build successful Status Detected: restored build Build Source Stamp: [branch 9.0.x] 6c05e1cfb5fca9ac99438a284ebd9788743f07b0 Step

[GitHub] [tomcat] hojongs commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

hojongs commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413855117 @markt-asf I get what you mean. But some people (including me) usually use the status codes with additional cases. For example, the status code 400 doesn't occur only in the badly format

[GitHub] [tomcat] markt-asf commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

markt-asf commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413798605 - 400 Always unsafe to continue since if you have a badly formatted request you can't tell where that request ends and the next one starts. - 408 Always unsafe to continue since the curr

[tomcat] branch 9.0.x updated: Drop xml prolog from DTD as it's not needed and causing the file to be flagged as malformed by xml validators

This is an automated email from the ASF dual-hosted git repository. csutherl pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 6c05e1cfb5 Drop xml prolog from DTD as it's not

[GitHub] [tomcat] dongseokk commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

dongseokk commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413769699 > -1. veto. I have security concerns. The connection is dropped in error conditions to avoid request smuggling risks. Of the status codes lists, the only one we might be able to handle saf

[GitHub] [tomcat] tbw777 opened a new pull request, #581: Speedup by removing non pattern replaceAll with constant arg

tbw777 opened a new pull request, #581: URL: https://github.com/apache/tomcat/pull/581 replaceAll("ABC", "") is non Pattern method and therefore must be replaced to simple fast replace() A proofs of changes: https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b -- This is an

[GitHub] [tomcat] tbw777 closed pull request #580: Speedup by removing non pattern replaceAll with constant arg

tbw777 closed pull request #580: Speedup by removing non pattern replaceAll with constant arg URL: https://github.com/apache/tomcat/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [tomcat] tbw777 opened a new pull request, #580: Speedup by removing non pattern replaceAll with constant arg

tbw777 opened a new pull request, #580: URL: https://github.com/apache/tomcat/pull/580 replaceAll("ABC", "") is non Pattern method and therefore must be replaced to simple fast replace() A proofs of changes: https://gist.github.com/tbw777/8a6ef60af21487c5faec67037099fd0b -- This is an

[GitHub] [tomcat] gksxodnd007 commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

gksxodnd007 commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413675074 @markt-asf thank you for your good opinion. but I think, it is no need to force drop connections. also, the default action is not changing by setting false the value. and some situat

[GitHub] [tomcat] markt-asf commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

markt-asf commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413624082 -1. veto. I have security concerns. The connection is dropped in error conditions to avoid request smuggling risks. Of the status codes lists, the only one we might be able to handle sa

[GitHub] [tomcat] rmaucher commented on pull request #579: Add activateDropConnection config to choose drop connection by http status code

rmaucher commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413524460 Ok why not, but "activateDropConnection" does not sound very good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [tomcat] gksxodnd007 opened a new pull request, #579: Add activateDropConnection config to choose drop connection by http status code

gksxodnd007 opened a new pull request, #579: URL: https://github.com/apache/tomcat/pull/579 when response http status code is `400, 408, 411, 413, 414, 500, 501, 503`, the connecton is closed by tomcat even though that is keep-alive. undertow and jetty and netty don't close keep-alive conne

Buildbot success in on tomcat-11.0.x

Build status: Build succeeded! Worker used: bb_worker2_ubuntu URL: https://ci2.apache.org/#builders/112/builds/169 Blamelist: Mark Thomas , remm Build Text: build successful Status Detected: restored build Build Source Stamp: [branch main] 10733c4228daece83195bb553ed97cf5996714f0 Steps: worke

[tomcat] branch 10.1.x updated: Restore ISE catching behavior

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new 0fb9397ff9 Restore ISE catching behavior 0fb9397ff

[tomcat] branch main updated: Restore ISE catching behavior

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 10733c4228 Restore ISE catching behavior 10733c4228 is