tbw777 commented on code in PR #581: URL: https://github.com/apache/tomcat/pull/581#discussion_r1094863229
########## java/org/apache/tomcat/buildutil/translate/Utils.java: ########## @@ -123,7 +123,7 @@ static String formatValueCommon(String in) { result = ESCAPE_LEADING_SPACE.matcher(result).replaceAll("\\\\$1"); - result = result.replaceAll("\t", "\\t"); + result = result.replace("\t", "t"); Review Comment: The second argument in replaceAll means escape t, not \t. You can check proofs tests. equals returning true if replace maked to t, not \t -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org