markt-asf commented on PR #579: URL: https://github.com/apache/tomcat/pull/579#issuecomment-1413798605
- 400 Always unsafe to continue since if you have a badly formatted request you can't tell where that request ends and the next one starts. - 408 Always unsafe to continue since the current request was not fully read - 411 Likely unsafe since the only reason for asking for a length is if you can't work it out. However, Tomcat never uses this status code so the point is moot. - 413 Unsafe since it is likely that the request will not be read fully - 414 Unsafe since it is likely that the request will not be read fully - 500 Unsafe since the request processing is in an unknown state - 503 Safe if, and only if, the request is fully read - 501 Safe if, and only if, the request is fully read If the change was limited to 501 and 503 and if it is confirmed that Tomcat reads the request fully in those cases (or there are changes to ensure that this is the case) then I'd be willing to reconsider my veto. I'd suggest, at this point, the OP's time would be better spent determining which status codes are triggering the observed connection closures and addressing the associated root cause(s). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
