martin-g commented on a change in pull request #351:
URL: https://github.com/apache/tomcat/pull/351#discussion_r494079321
##
File path: java/org/apache/jasper/compiler/Generator.java
##
@@ -2095,6 +2101,20 @@ public void visit(Node.JspElement n) throws
JasperException {
martin-g commented on a change in pull request #351:
URL: https://github.com/apache/tomcat/pull/351#discussion_r494077383
##
File path: java/org/apache/jasper/compiler/NewlineReductionServletWriter.java
##
@@ -0,0 +1,41 @@
+package org.apache.jasper.compiler;
+
+import java.io.
The Buildbot has detected a restored build on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/460
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSchedu
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 7.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/7.0.x by this push:
new 858a062 Clarify when additional Manager instances
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 4c2fc82 Clarify when additional Manager instances
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 4f7d34f Clarify when additional Manager instances
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 10c6b85 Clarify when additional Manager instance
kamnani edited a comment on pull request #352:
URL: https://github.com/apache/tomcat/pull/352#issuecomment-697550277
> I tried it, with some changes. Will see the feedback about an actual
performance benefit. I measured the cost of building the filter, not too big
overall so there's likely
kamnani commented on pull request #352:
URL: https://github.com/apache/tomcat/pull/352#issuecomment-697550277
> I tried it, with some changes. Will see the feedback about an actual
performance benefit. I measured the cost of building the filter, not too big
overall so there's likely someth
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
--- Comment #4 from Christopher Schultz ---
(In reply to Ralf Hauser from comment #3)
> No, we are not using "Tomcat-provided Servlet-3.0 file-upload" but
> commons-fileupload-1.4.jar with launched by some legacy struts
Okay, so Struts is hand
https://bz.apache.org/bugzilla/show_bug.cgi?id=64763
Christopher Schultz changed:
What|Removed |Added
Resolution|--- |INVALID
Status|NEW
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
Ralf Hauser changed:
What|Removed |Added
Summary|CoyoteInputStream |CoyoteInputStream
|asy
https://bz.apache.org/bugzilla/show_bug.cgi?id=64763
Bug ID: 64763
Summary: Tomcat does not interrupts http-nio--execXXX
threads
Product: Tomcat 8
Version: 8.5.58
Hardware: PC
OS: Linux
Statu
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
--- Comment #2 from Christopher Schultz ---
Looks like you are doing multipart/form-data processing, as handled by
commons-fileupload. Is that using the Tomcat-provided Servlet-3.0 file-upload,
or are you using a different mechanism?
I would g
ChristopherSchultz commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-697473351
@rotty3000 This is what I was thinking would be better than post-processing.
The JSP->class translation should be a one-time hit rather than a
filtering-step that requir
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
--- Comment #1 from Ralf Hauser ---
The stream is read/copied with
org.apache.commons.io.IOUtils.copy()
In combination with Axis2, the soap client side sees
"Unexpected EOF in prolog"
(there we haven't found the symptom fighting workarou
rotty3000 commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-697412964
If I may bring one point; I wonder if maybe this optimization is later in
the process than would _really_ benefit even more concerns.
For instance, if the optimization was
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
Ralf Hauser changed:
What|Removed |Added
Summary|CoyoteInputStream |CoyoteInputStream
|asy
https://bz.apache.org/bugzilla/show_bug.cgi?id=64762
Bug ID: 64762
Summary: CoyoteInputStream asynchronous read
Product: Tomcat 9
Version: 9.0.31
Hardware: PC
OS: Linux
Status: NEW
Severity: regression
markt-asf commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-697355204
The relevance of gzip depends on what you are trying to optimize. If you are
trying to minimise network bytes then gzip is very relevant. For the minimise
network bytes use case,
ChristopherSchultz commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-697345837
I still think gzip is a red herring, here. If you remove whitespace prior to
gzipping, you'll likely see that gzip gives you a lower compression ratio when
comparing the
The Buildbot has detected a restored build on builder tomcat-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5449
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler
markt-asf commented on pull request #351:
URL: https://github.com/apache/tomcat/pull/351#issuecomment-697269157
I have been doing some simple tests to compare the behaviour of compression
with and without this PR. Using the default index page as an example, gzip
achieves 80.1% compression.
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 88afc14 Javadoc fix
88afc14 is described below
com
This is an automated email from the ASF dual-hosted git repository.
remm pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 99647b3 Merge branch 'master' of g...@github.com:apache/tomcat.git
add 2b4e441 Javadoc fix
No new revisions wer
The Buildbot has detected a new failure on builder tomcat-trunk while building
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5448
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler sc
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new ec2369d Add a bloom filter to speed up archive look
rmaucher closed pull request #352:
URL: https://github.com/apache/tomcat/pull/352
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rmaucher commented on pull request #352:
URL: https://github.com/apache/tomcat/pull/352#issuecomment-697260660
I tried it, with some changes. Will see the feedback about an actual
performance benefit. I measured the cost of building the filter, not too big
overall so there's likely somethi
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new ce17ede Add a bloom filter to speed up archive lo
30 matches
Mail list logo