markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697355204
The relevance of gzip depends on what you are trying to optimize. If you are trying to minimise network bytes then gzip is very relevant. For the minimise network bytes use case, this PR + gzip offers very small gains compared to gzip alone. Hence, in my view, this PR is not supported by the minimise network bytes use case. Where this PR does make a difference - at least in my tests - is throughput. The bottleneck on my system appears to be in the Tomcat and/or JVM network stack and is somewhere around 3Gbps. At least that is how it appears. Because this PR reduces the size of the response without (unlike gzip) adding delay or CPU overhead, it increases throughput in terms of requests per second. What I am unclear on is how likely this bottleneck is to appear in a real-world scenario. Other thoughts that come to mind are: - how does this compare to an HTML minifier filter (I'd like to test this) - if we do apply this PR, does this need to be a separate configuration option or does it make more sense as an additional Tomcat specific extension of trimSpaces like "single" is. Maybe call it "extended". ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
