markt-asf commented on pull request #351: URL: https://github.com/apache/tomcat/pull/351#issuecomment-697269157
I have been doing some simple tests to compare the behaviour of compression with and without this PR. Using the default index page as an example, gzip achieves 80.1% compression. Applying this PR and then gzip achieves 80.8% compression. Given the nature of gzip compression and the optimisations provided by this PR I'd expect to see similar results for other input. i.e. gzip provides significant compression and adding this PR makes only a minimal difference. gzip does require additional CPU to perform the compression so I want to do some more experiments to understand the impact of this PR under various load scenarios. Separately, I'll note that the PR as currently provided fails the Checkstyle checks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
