Github user fjodorver commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-110251900
It's updated pull request.
1) Build.xml configuration in separate commit now
2) Fixed imports and formatting
3) Method refactoring has been made separately.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010
Joshua C Rebelo changed:
What|Removed |Added
CC||joshua.reb...@gmail.com
it/target/junit-4.13-SNAPSHOT.jar
-Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.2-SNAPSHOT.jar
-Dtest.reports=output/logs-APR
-Dtomcat-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20150608-native-src.tar.gz
-Dexampl
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1344
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedu
Author: markt
Date: Mon Jun 8 21:30:19 2015
New Revision: 1684283
URL: http://svn.apache.org/r1684283
Log:
Fix header writing bug
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
Modified: tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
URL:
h
The Buildbot has detected a build exception on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/1343
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSc
Author: markt
Date: Mon Jun 8 21:10:46 2015
New Revision: 1684280
URL: http://svn.apache.org/r1684280
Log:
Remove unused import
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerContainer.java
Modified:
tomcat/trunk/java/org/apache/tomcat/websocket/server/WsServerConta
Author: markt
Date: Mon Jun 8 21:07:38 2015
New Revision: 1684279
URL: http://svn.apache.org/r1684279
Log:
Add a test for exceeding the maximum frame size
Modified:
tomcat/trunk/java/org/apache/coyote/http2/ByteUtil.java
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java
Author: markt
Date: Mon Jun 8 20:53:39 2015
New Revision: 1684277
URL: http://svn.apache.org/r1684277
Log:
Invalid priority length is only a stream error
Modified:
tomcat/trunk/java/org/apache/coyote/http2/FrameType.java
tomcat/trunk/java/org/apache/coyote/http2/Http2Parser.java
tomc
Author: markt
Date: Mon Jun 8 20:44:21 2015
New Revision: 1684273
URL: http://svn.apache.org/r1684273
Log:
A couple more tests
Added:
tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.java (with
props)
Added: tomcat/trunk/test/org/apache/coyote/http2/TestHttp2Section_4_2.jav
Author: markt
Date: Mon Jun 8 20:32:34 2015
New Revision: 1684271
URL: http://svn.apache.org/r1684271
Log:
Implement stream closure on StreamError
Modified:
tomcat/trunk/java/org/apache/coyote/http2/Http2UpgradeHandler.java
tomcat/trunk/java/org/apache/coyote/http2/LocalStrings.propertie
Author: markt
Date: Mon Jun 8 20:11:36 2015
New Revision: 1684266
URL: http://svn.apache.org/r1684266
Log:
StreamError needs the stream ID (so we know which stream to close)
Modified:
tomcat/trunk/java/org/apache/coyote/http2/FrameType.java
tomcat/trunk/java/org/apache/coyote/http2/Http2
Author: markt
Date: Mon Jun 8 19:51:30 2015
New Revision: 1684258
URL: http://svn.apache.org/r1684258
Log:
Remove stream ID from Http2Exception (simpler logging of this to follow)
Modified:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionError.java
tomcat/trunk/java/org/apache/coyote
Author: markt
Date: Mon Jun 8 19:45:12 2015
New Revision: 1684255
URL: http://svn.apache.org/r1684255
Log:
Introduce separate exceptions for stream errors and connection errors
Added:
tomcat/trunk/java/org/apache/coyote/http2/ConnectionError.java (with
props)
tomcat/trunk/java/org/apa
https://bz.apache.org/bugzilla/show_bug.cgi?id=58009
--- Comment #2 from Matt ---
Actually, after restarting the test server I'm getting the same behavior there,
so the regression is not in 8.0.10. Disabling the resource cache does fix it,
but that doesn't seem to be ideal. If the file is not fou
Author: markt
Date: Mon Jun 8 17:57:05 2015
New Revision: 1684233
URL: http://svn.apache.org/r1684233
Log:
Rename ErrorCode -> Error
Added:
tomcat/trunk/java/org/apache/coyote/http2/Error.java
- copied, changed from r1683410,
tomcat/trunk/java/org/apache/coyote/http2/ErrorCode.java
Re
https://bz.apache.org/bugzilla/show_bug.cgi?id=57977
Remy Maucherat changed:
What|Removed |Added
Severity|normal |minor
--- Comment #4 from Remy Mauche
https://bz.apache.org/bugzilla/show_bug.cgi?id=58009
Remy Maucherat changed:
What|Removed |Added
Status|NEW |NEEDINFO
OS|
https://bz.apache.org/bugzilla/show_bug.cgi?id=58011
Bug ID: 58011
Summary: Tomcat 7 crasches intermittently with NIO and HTTPS
Product: Tomcat 7
Version: 7.0.61
Hardware: PC
Status: NEW
Severity: major
Priority
https://bz.apache.org/bugzilla/show_bug.cgi?id=57969
Violeta Georgieva changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: violetagg
Date: Mon Jun 8 14:24:30 2015
New Revision: 1684196
URL: http://svn.apache.org/r1684196
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57969
Merged revision 1684172 from tomcat/trunk:
Provide path params to POJO via WsPerSessionServerEndpointConfig instead of the
'glob
Author: violetagg
Date: Mon Jun 8 14:17:30 2015
New Revision: 1684193
URL: http://svn.apache.org/r1684193
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57969
Merged revision 1684172 from tomcat/trunk:
Provide path params to POJO via WsPerSessionServerEndpointConfig instead of the
'glob
Author: violetagg
Date: Mon Jun 8 12:43:30 2015
New Revision: 1684172
URL: http://svn.apache.org/r1684172
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=57969
Provide path params to POJO via WsPerSessionServerEndpointConfig instead of the
'global' ServerEndpointConfig.
Modified:
to
All,
I'm not particularly happy with the current error handling (based around
Http2Exception) and as I work my way through the spec in detail I am
coming across cases that are becoming increasingly difficult to handle
cleanly.
I think I have reached the point where a completely different approach
Github user markt-asf commented on the pull request:
https://github.com/apache/tomcat/pull/21#issuecomment-109959429
OK. I've copied the Geronimo classes across and fixed the checkstyle and
compilation errors. I've now seen some additional issues that need to be
addressed.
1. Remo
Author: markt
Date: Mon Jun 8 11:35:14 2015
New Revision: 1684162
URL: http://svn.apache.org/r1684162
Log:
Fix the generics issues we can fix and suppress the issues in the API since we
can't fix those.
Suppress at the method level so we spot generics issues in any new methods we
add (assuming
Author: markt
Date: Mon Jun 8 11:29:02 2015
New Revision: 1684158
URL: http://svn.apache.org/r1684158
Log:
Add missing @Override markers
Modified:
tomcat/trunk/java/javax/security/auth/message/AuthStatus.java
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java
Mo
Author: markt
Date: Mon Jun 8 11:27:10 2015
New Revision: 1684155
URL: http://svn.apache.org/r1684155
Log:
Fix compilation error (will need review w.r.t. what the spec expects here)
based on pull request 21 from fjodorver.
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthC
Author: markt
Date: Mon Jun 8 11:21:30 2015
New Revision: 1684150
URL: http://svn.apache.org/r1684150
Log:
Fix disallowed imports
Modified:
tomcat/trunk/res/checkstyle/javax-import-control.xml
Modified: tomcat/trunk/res/checkstyle/javax-import-control.xml
URL:
http://svn.apache.org/viewvc/
Author: markt
Date: Mon Jun 8 11:09:28 2015
New Revision: 1684148
URL: http://svn.apache.org/r1684148
Log:
Remove unused imports
Modified:
tomcat/trunk/java/javax/security/auth/message/config/AuthConfig.java
tomcat/trunk/java/javax/security/auth/message/config/AuthConfigFactory.java
Mod
Author: markt
Date: Mon Jun 8 11:08:18 2015
New Revision: 1684146
URL: http://svn.apache.org/r1684146
Log:
Fix import order issues
Modified:
tomcat/trunk/java/javax/security/auth/message/callback/CallerPrincipalCallback.java
tomcat/trunk/java/javax/security/auth/message/callback/CertSt
Author: markt
Date: Mon Jun 8 11:01:48 2015
New Revision: 1684145
URL: http://svn.apache.org/r1684145
Log:
Fix trailing whitespace issues
Modified:
tomcat/trunk/java/javax/security/auth/message/AuthException.java
tomcat/trunk/java/javax/security/auth/message/callback/CertStoreCallback.j
Author: markt
Date: Mon Jun 8 11:00:19 2015
New Revision: 1684144
URL: http://svn.apache.org/r1684144
Log:
Copy JASPIC 1.0 API from Geronimo
This copy is unchanged so there are numerous Checkstyle issues that need to be
fixed
Added:
tomcat/trunk/java/javax/security/auth/message/
- cop
Author: markt
Date: Mon Jun 8 10:55:57 2015
New Revision: 1684143
URL: http://svn.apache.org/r1684143
Log:
Create package ready to copy in JASPIC API from Geronimo
Added:
tomcat/trunk/java/javax/security/
tomcat/trunk/java/javax/security/auth/
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=58010
Bug ID: 58010
Summary: Class file are not getting compiled with debuginfo
while setting classdebuginfo in jasper ant task
Product: Tomcat 7
Version: 7.0.55
Hardware: PC
ace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20
ib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20150608.jar:/srv/g
ace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.8-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20
38 matches
Mail list logo
