The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4763
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/4762
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source St
Author: jboynes
Date: Tue Jul 30 01:01:04 2013
New Revision: 1508261
URL: http://svn.apache.org/r1508261
Log:
Delete test case as it was not really testing what was intended anyway
Removed:
tomcat/trunk/test/org/apache/jasper/servlet/TestJasperInitializer.java
--
Author: jboynes
Date: Tue Jul 30 00:53:23 2013
New Revision: 1508259
URL: http://svn.apache.org/r1508259
Log:
Reformat to 80 char line length.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebappServic
On Mon, Jul 29, 2013 at 2:08 PM, Mark Thomas wrote:
> On 29/07/2013 22:56, Nick Williams wrote:
> >
> > On Jul 29, 2013, at 3:53 PM, Jeremy Boynes wrote:
> >
> >> This is what lies under the syntactic sugar, and causes no warnings in
> >> javac or IDEA (and I presume Eclipse). Should we stick to
On 29/07/2013 22:56, Jeremy Boynes wrote:
> On Mon, Jul 29, 2013 at 9:51 AM, Mark Thomas wrote:
>
>> On 29/07/2013 01:01, jboy...@apache.org wrote:
>>> Author: jboynes
>>> Date: Sun Jul 28 23:01:23 2013
>>> New Revision: 1507870
>>>
>>> URL: http://svn.apache.org/r1507870
>>
>> Generally, line le
On 29/07/2013 22:56, Nick Williams wrote:
>
> On Jul 29, 2013, at 3:53 PM, Jeremy Boynes wrote:
>
>> This is what lies under the syntactic sugar, and causes no warnings in
>> javac or IDEA (and I presume Eclipse). Should we stick to it?
>
> I would say no. This is why generics exist, so that you
https://issues.apache.org/bugzilla/show_bug.cgi?id=55309
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Mon Jul 29 21:03:22 2013
New Revision: 1508200
URL: http://svn.apache.org/r1508200
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55309
Fix concurrency issue in TagPluginManager
PageInfo should not be a field as it is per page and there will be conflicts
with conc
On Mon, Jul 29, 2013 at 9:51 AM, Mark Thomas wrote:
> On 29/07/2013 01:01, jboy...@apache.org wrote:
> > Author: jboynes
> > Date: Sun Jul 28 23:01:23 2013
> > New Revision: 1507870
> >
> > URL: http://svn.apache.org/r1507870
>
> Generally, line lengths should be limited to 80 characters. I know
On Jul 29, 2013, at 3:53 PM, Jeremy Boynes wrote:
> This is what lies under the syntactic sugar, and causes no warnings in
> javac or IDEA (and I presume Eclipse). Should we stick to it?
I would say no. This is why generics exist, so that you don't have to write
code like that.
>
> Index: jav
Author: markt
Date: Mon Jul 29 20:55:45 2013
New Revision: 1508196
URL: http://svn.apache.org/r1508196
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55309
Fix concurrency issue in TagPluginManager
PageInfo should not be a field as it is per page and there will be conflicts
with conc
This is what lies under the syntactic sugar, and causes no warnings in
javac or IDEA (and I presume Eclipse). Should we stick to it?
Index: java/org/apache/catalina/startup/WebappServiceLoader.java
===
--- java/org/apache/catalina/sta
On 29/07/2013 22:12, Nick Williams wrote:
>
> On Jul 29, 2013, at 3:02 PM, Mark Thomas wrote:
>
>> On 29/07/2013 21:45, Nick Williams wrote:
>>>
>>> On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote:
>>>
On 29/07/2013 21:04, Nick Williams wrote:
> On Jul 29, 2013, at 2:02 PM, Jeremy Boyne
On Jul 29, 2013, at 3:02 PM, Mark Thomas wrote:
> On 29/07/2013 21:45, Nick Williams wrote:
>>
>> On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote:
>>
>>> On 29/07/2013 21:04, Nick Williams wrote:
On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:
> This flags as a warning for me in
On 29/07/2013 21:45, Nick Williams wrote:
>
> On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote:
>
>> On 29/07/2013 21:04, Nick Williams wrote:
>>> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:
>>>
This flags as a warning for me in IDEA without the suppression.
Isn't this an unchecked
On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote:
> On 29/07/2013 21:04, Nick Williams wrote:
>> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:
>>
>>> This flags as a warning for me in IDEA without the suppression. Isn't this
>>> an unchecked cast (Object to List)?
>
> It is an unchecked cast
On 29/07/2013 21:04, Nick Williams wrote:
> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:
>
>> This flags as a warning for me in IDEA without the suppression. Isn't this
>> an unchecked cast (Object to List)?
It is an unchecked cast but there is no way to avoid the cast so there
is no point t
On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote:
> This flags as a warning for me in IDEA without the suppression. Isn't this
> an unchecked cast (Object to List)?
Yes, that's an unchecked cast. The @SuppressWarnings was not unnecessary.
N
>
>
> On Mon, Jul 29, 2013 at 11:38 AM, wrote:
>
>
This flags as a warning for me in IDEA without the suppression. Isn't this
an unchecked cast (Object to List)?
On Mon, Jul 29, 2013 at 11:38 AM, wrote:
> Author: markt
> Date: Mon Jul 29 18:38:08 2013
> New Revision: 1508171
>
> URL: http://svn.apache.org/r1508171
> Log:
> Remove unnecessary @S
On 29/07/2013 01:01, jboy...@apache.org wrote:
> Author: jboynes
> Date: Sun Jul 28 23:01:23 2013
> New Revision: 1507870
>
> URL: http://svn.apache.org/r1507870
> Log:
> Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=55287
>
> Decouple service loading for ServletContainerInitializers
On 29/07/2013 20:34, Jeremy Boynes wrote:
> On Mon, Jul 29, 2013 at 10:19 AM, Mark Thomas wrote:
>
>>
>> Looking forward to the point where we use an SCI for JSPs, we don't want
>> to / shouldn't have to do this for every test that uses JSPs.
>>
>> addWebapp() is the interface that provides the s
Author: markt
Date: Mon Jul 29 18:38:08 2013
New Revision: 1508171
URL: http://svn.apache.org/r1508171
Log:
Remove unnecessary @SuppressWarnings
Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebappServiceLoader.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebappServ
Author: markt
Date: Mon Jul 29 18:38:39 2013
New Revision: 1508172
URL: http://svn.apache.org/r1508172
Log:
Remove unused code
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
URL:
http://sv
On Mon, Jul 29, 2013 at 10:19 AM, Mark Thomas wrote:
>
> Looking forward to the point where we use an SCI for JSPs, we don't want
> to / shouldn't have to do this for every test that uses JSPs.
>
> addWebapp() is the interface that provides the settings from the default
> web.xml and should be ju
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312
--- Comment #5 from Mark Thomas ---
(In reply to Dave Syer from comment #1)
> I played around with the Tomcat embedded server a bit more and found that it
> actually is relatively easy (if obscure) to switch on SCI:
>
> Conte
Author: markt
Date: Mon Jul 29 17:46:48 2013
New Revision: 1508152
URL: http://svn.apache.org/r1508152
Log:
Better documentation.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java
URL:
http://svn.apache.or
On 29/07/2013 02:01, jboy...@apache.org wrote:
> Author: jboynes
> Date: Mon Jul 29 00:01:15 2013
> New Revision: 1507874
>
> URL: http://svn.apache.org/r1507874
> Log:
> Test case should assert SCI is actually loaded
> +public void testServiceLoader() throws Exception {
> +Tomcat t
On 29/07/2013 01:01, jboy...@apache.org wrote:
> Author: jboynes
> Date: Sun Jul 28 23:01:23 2013
> New Revision: 1507870
>
> URL: http://svn.apache.org/r1507870
Generally, line lengths should be limited to 80 characters. I know not
all of the Tomcat code does that but new code should.
> +publi
https://issues.apache.org/bugzilla/show_bug.cgi?id=55101
--- Comment #5 from Mark Thomas ---
Thanks. Applied to trunk.
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-uns
Author: markt
Date: Mon Jul 29 16:30:54 2013
New Revision: 1508127
URL: http://svn.apache.org/r1508127
Log:
Remove duplicate tests.
Add comment to explain where credential decoding is tested.
Patch provided by Brian Burch.
Modified:
tomcat/trunk/test/org/apache/catalina/authenticator/TestNon
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312
Dave Syer changed:
What|Removed |Added
Status|NEEDINFO|NEW
--
You are receiving this mail be
https://issues.apache.org/bugzilla/show_bug.cgi?id=55312
--- Comment #4 from Dave Syer ---
It helps a bit. But it's actually the scan for HandlesTypes references that I
need to modify (populating the initializerClassMap in ContextConfig) - the
SCIs are all discovered correctly, but their handler
33 matches
Mail list logo
