On 29/07/2013 22:12, Nick Williams wrote: > > On Jul 29, 2013, at 3:02 PM, Mark Thomas wrote: > >> On 29/07/2013 21:45, Nick Williams wrote: >>> >>> On Jul 29, 2013, at 2:40 PM, Mark Thomas wrote: >>> >>>> On 29/07/2013 21:04, Nick Williams wrote: >>>>> On Jul 29, 2013, at 2:02 PM, Jeremy Boynes wrote: >>>>> >>>>>> This flags as a warning for me in IDEA without the >>>>>> suppression. Isn't this an unchecked cast (Object to >>>>>> List<String>)? >>>> >>>> It is an unchecked cast but there is no way to avoid the cast >>>> so there is no point the IDE flagging it as there is nothing >>>> the developer can do to fix it. Eclipse added an option >>>> (Ignore unavoidable generic type problems) not to flag issues >>>> such as this as of a recent(ish) version. >>>> >>>>> Yes, that's an unchecked cast. The @SuppressWarnings was not >>>>> unnecessary. >>>> >>>> Yes, it is unchecked cast. However, the warning is pointless >>>> and shouldn't have been generated in the first place. >>>> >>>> The Tomcat 8 code base should not exhibit any warnings with >>>> the defined Eclipse settings [1]. Ditto for FindBugs and >>>> Checkstyle with the provided configurations. >>> >>> Shouldn't it also not exhibit any warnings when compiled by the >>> JDK? >> >> That isn't the standard the Tomcat community decided to adopt. > > When did that happen?
I don't recall. It will be in the archives and/or the svn history. > It must've been before my time. I know I would > have adamantly opposed such an adoption. Such decisions should be > based on the platform, not the IDE. The chances of anyone being involved in an open source project for any length of time and agreeing with every single decision made is about close to zero. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
