On Mon, Jul 29, 2013 at 9:51 AM, Mark Thomas <ma...@apache.org> wrote:
> On 29/07/2013 01:01, jboy...@apache.org wrote: > > Author: jboynes > > Date: Sun Jul 28 23:01:23 2013 > > New Revision: 1507870 > > > > URL: http://svn.apache.org/r1507870 > > Generally, line lengths should be limited to 80 characters. I know not > all of the Tomcat code does that but new code should. > I'll set up style rules and fix that. > > > > +public class WebappServiceLoader<T> { > > + private static final String LIB = "/WEB-INF/lib/"; > > + private static final String SERVICES = "META-INF/services/"; > > + private static final Charset UTF8 = Charset.forName("UTF-8"); > > Should use B2CConverter.UTF_8 > I try to avoid dependencies and this would be the same instance from Charset's cache so I don't see any memory benefit. Am I missing something here?
