[Tomcat Wiki] Trivial Update of "BrittneyY" by BrittneyY

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "BrittneyY" page has been changed by BrittneyY: http://wiki.apache.org/tomcat/BrittneyY New page: Nothing to write about me at all.<> Feels good to be a part of this community.<> I

[Bug 54729] New: new HttpParser.parseAuthorizationBasic method

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54729 Bug ID: 54729 Summary: new HttpParser.parseAuthorizationBasic method Product: Tomcat 8 Version: trunk Hardware: PC OS: Linux Status: NEW Severity: e

Re: Servlet 3.1 Request Upgrade

2013-03-19 Thread Nick Williams
On Mar 11, 2013, at 3:37 PM, Mark Thomas wrote: > On 09/03/2013 23:03, Nick Williams wrote: >> Mark, >> >> I noticed the HttpServletRequest upgrade method still had the >> signature void upgrade(HttpUpgradeHandler) when it should be > extends HttpUpgradeHandler> T upgrade(Class) per the latest s

[Bug 54728] HttpServletRequest#upgrade() and other interfaces don't match spec; change may be impossible to implement

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54728 --- Comment #1 from Nick Williams --- Created attachment 30082 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30082&action=edit Patch that doesn't work #2 -- You are receiving this mail because: You are the assignee for the bu

[Bug 54728] HttpServletRequest#upgrade() and other interfaces don't match spec; change may be impossible to implement

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54728 Nick Williams changed: What|Removed |Added Attachment #30081|0 |1 is patch|

[Bug 54728] New: HttpServletRequest#upgrade() and other interfaces don't match spec; change may be impossible to implement

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54728 Bug ID: 54728 Summary: HttpServletRequest#upgrade() and other interfaces don't match spec; change may be impossible to implement Product: Tomcat 8 Version:

svn commit: r1458566 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/fileupload/ java/org/apache/tomcat/util/http/fileupload/util/ java/org/apache/tomcat/util/http/fileupload/util/mime

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 23:14:59 2013 New Revision: 1458566 URL: http://svn.apache.org/r1458566 Log: Update Commons Fileupload to r1458500 Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) tom

svn commit: r1458565 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/util/mime: Base64Decoder.java QuotedPrintableDecoder.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 23:14:02 2013 New Revision: 1458565 URL: http://svn.apache.org/r1458565 Log: Whitespace police after merge Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/util/mime/Base64Decoder.java tomcat/trunk/java/org/apache/tomcat/util/http/fileupl

svn commit: r1458564 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: ./ FileUploadBase.java package-info.java util/FileItemHeadersImpl.java util/mime/Base64Decoder.java util/mime/MimeU

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 23:13:15 2013 New Revision: 1458564 URL: http://svn.apache.org/r1458564 Log: Update Commons Fileupload to r1458500 Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/

Re: [Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread Mark Thomas
On 19/03/2013 23:02, sebb wrote: > On 18 March 2013 21:54, Mark Thomas wrote: >> I'll note that while the spammers entries to the wiki get removed pretty >> quickly (thanks Chunk) their content is in our mail archive which is > > s/Chunk/Chuck/ ! Sorry. Too much time spent typing ByteChunk and

svn commit: r1458562 - in /tomcat/trunk: build.properties.default build.xml

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 23:02:50 2013 New Revision: 1458562 URL: http://svn.apache.org/r1458562 Log: Update to Commons Logging 1.1.2 Modified: tomcat/trunk/build.properties.default tomcat/trunk/build.xml Modified: tomcat/trunk/build.properties.default URL: http://svn.apache.org/v

Re: [Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread sebb
On 18 March 2013 21:54, Mark Thomas wrote: > On 18/03/2013 21:46, Apache Wiki wrote: >> Dear Wiki user, >> >> You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for >> change notification. >> >> The "LocalBadContent" page has been changed by ChuckCaldarale: > > I've raised it be

Re: AJP + WebSockets

2013-03-19 Thread Mark Thomas
On 19/03/2013 22:49, Nick Williams wrote: > I was working on the recent change in the Servlet 3.1 spec for > HttpServletRequest#upgrade(...) and noticed that the > AbstractAjpProcessor doesn't support HTTP Upgrade (and, by extension, > doesn't support WebSockets). Only the AbstractHttp11Processor d

svn commit: r1458559 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsSession.java server/LocalStrings.properties server/WsProtocolHandler.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 22:51:15 2013 New Revision: 1458559 URL: http://svn.apache.org/r1458559 Log: As highlighted by the Autobahn tests, a protocol error needs to force an immediate close. The server can't wait for a echoed close frame from a connection that is in an unknown state. Mod

AJP + WebSockets

2013-03-19 Thread Nick Williams
I was working on the recent change in the Servlet 3.1 spec for HttpServletRequest#upgrade(...) and noticed that the AbstractAjpProcessor doesn't support HTTP Upgrade (and, by extension, doesn't support WebSockets). Only the AbstractHttp11Processor does. Is there a plan for AJP to support Upgrad

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=90&rev2=91 cheapestoemsoftware chemisesvendre\.eu cho

svn commit: r1458527 - /tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 21:41:56 2013 New Revision: 1458527 URL: http://svn.apache.org/r1458527 Log: Link to the 7.0.x code which uses the old API Modified: tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/web-socket-howto.xml URL: ht

svn commit: r1458526 - /tomcat/trunk/build.xml

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 21:36:49 2013 New Revision: 1458526 URL: http://svn.apache.org/r1458526 Log: Fix typo Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1458526&r1=1458525&r2=1458526&view=diff ===

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 --- Comment #7 from Nick Williams --- Then I stand corrected. My patch still contains a solution to the "more than one meta-inf" problem, but if you'd rather wait and solve that problem when it appears, that's fine. By the way, there's a

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 --- Comment #6 from Mark Thomas --- (In reply to comment #5) > The source JARs should contain all code necessary to build a running Tomcat, > right? Wrong. That describes the -src.tar.gz and -src.zip distributions. The src JARs are purely

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=89&rev2=90 africancanadianmodels\.com alcor\-holding

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 --- Comment #5 from Nick Williams --- "the answer to that problem is probably creating additional directories for the embedded JARs under ${tomcat.manifests} at the same time ${tomcat.manifests} is created." Yep. That's what I did, except

svn commit: r1458525 - /tomcat/trunk/build.xml

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 21:25:21 2013 New Revision: 1458525 URL: http://svn.apache.org/r1458525 Log: Tab police Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=1458525&r1=1458524&r2=1458525&view=diff =

[Tomcat Wiki] Trivial Update of "MohamedHo" by MohamedHo

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "MohamedHo" page has been changed by MohamedHo: http://wiki.apache.org/tomcat/MohamedHo New page: Not much to say about me I think.<> Enjoying to be a member of apache.org.<> I just

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 --- Comment #4 from Mark Thomas --- I'm not clear what the purpose of adding those files to the source JAR would be. As for additional JARs, I'm happy not worrying about that until we need to and the answer to that problem is probably crea

svn commit: r1458523 - in /tomcat/trunk/java/org/apache/tomcat/websocket: LocalStrings.properties WsFrameBase.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 21:12:15 2013 New Revision: 1458523 URL: http://svn.apache.org/r1458523 Log: Once a close frame has been received, don't process any more frames. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/LocalStrings.properties tomcat/trunk/java/org/apache/tom

svn commit: r1458521 - /tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 21:11:11 2013 New Revision: 1458521 URL: http://svn.apache.org/r1458521 Log: A RuntimeException in one test shouldn't stop the test run. Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TesterWsClientAutobahn.java Modified: tomcat/trunk/test/org/apache/

buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4130 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 --- Comment #3 from Nick Williams --- Created attachment 30080 --> https://issues.apache.org/bugzilla/attachment.cgi?id=30080&action=edit Proposed different patch Hmmm. And here I was attached a patch as you checked in a fix. If you don

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1458503 - /tomcat/trunk/build.xml

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 20:34:48 2013 New Revision: 1458503 URL: http://svn.apache.org/r1458503 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 Include WebSocket META-INF files in core embedded JAR Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL

[Bug 54726] JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 --- Comment #1 from Nick Williams --- Also missing is META-INF/web-fragment.xml. I will have a patch for this shortly. -- You are receiving this mail because: You are the assignee for the bug.

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 --- Comment #7 from Nick Williams --- Looks good. The only potential problem I can see is that it allows calls to addMessageHandler(MessageHandler), removeMessageHandler(MessageHandler), any set* methods, getAsyncRemote(), and getBasicRemot

[Bug 54716] WebSocket implementation "freaks out" if Session closed or exception thrown from onOpen method

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1458484 - in /tomcat/trunk/java/org/apache/tomcat/websocket: BackgroundProcessManager.java WsWebSocketContainer.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 19:58:34 2013 New Revision: 1458484 URL: http://svn.apache.org/r1458484 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 Additional fix. Avoid NPE on session de-registration. Based on a patch by Nick Williams. Modified: tomcat/trunk/java/org/apa

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1458479 - in /tomcat/trunk: java/org/apache/tomcat/websocket/LocalStrings.properties java/org/apache/tomcat/websocket/WsSession.java test/org/apache/tomcat/websocket/TestWsWebSocketContai

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 19:49:51 2013 New Revision: 1458479 URL: http://svn.apache.org/r1458479 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 Session should throw IllegalStateException if closed when methods on it are called Modified: tomcat/trunk/java/org/apache/t

Re: [Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-03-19 Thread sebb
On 19 March 2013 16:06, Apache Wiki wrote: > Dear Wiki user, > > You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for > change notification. > > The "LocalBadContent" page has been changed by KonstantinKolinko: > http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=8

[Bug 54726] New: JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54726 Bug ID: 54726 Summary: JAR file META-INF/services resources missing for WebSocket in latest tomcat-embed-core-8.0 snapshot artifact Product: Tomcat 8 Versio

buildbot success in ASF Buildbot on tomcat-trunk

2013-03-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4128 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 --- Comment #5 from Nick Williams --- Okay. I won't work on a patch then. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-m

svn commit: r1458406 - /tomcat/trunk/webapps/docs/changelog.xml

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 16:55:21 2013 New Revision: 1458406 URL: http://svn.apache.org/r1458406 Log: Whitespace police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/chang

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 --- Comment #4 from Mark Thomas --- I have a patch that does pretty much exactly that but there are some unit test failures I need to resolve before I commit it. -- You are receiving this mail because: You are the assignee for the bug. -

Changelog has training whitespace

2013-03-19 Thread Nick Williams
validate: [mkdir] Created dir: C:\Tomcat-Build\Source\output\res\checkstyle [checkstyle] Running Checkstyle 5.6 on 2516 files [checkstyle] C:\Tomcat-Build\Source\webapps\docs\changelog.xml:128: Line matches the illegal pattern '\s+$'. BUILD FAILED C:\Tomcat-Build\Source\build.xml:485: Got 1 e

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 --- Comment #3 from Nick Williams --- This may need more clarification at the spec level. Created a spec bug: http://java.net/jira/browse/WEBSOCKET_SPEC-174 -- You are receiving this mail because: You are the assignee for the bug. -

[Tomcat Wiki] Update of "LocalBadContent" by KonstantinKolinko

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by KonstantinKolinko: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=88&rev2=89 Comment: Try to block a frequently used phras

buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4127 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 --- Comment #2 from Nick Williams --- Want to make sure we agree on approach, which is slightly more detailed than the JavaDoc spec: 1. ALL WsSession methods specified by the Session interface will throw IllegalStateException if the sessio

buildbot failure in ASF Buildbot on tomcat-7-trunk

2013-03-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1131 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

[Bug 54716] WebSocket implementation "freaks out" if Session closed or exception thrown from onOpen method

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 --- Comment #3 from Nick Williams --- Assuming the solution is 1, the patch is simply changing this: if (processes.size() == 0) { wsBackgroundThread.halt(); wsBackgroundThread = null;

svn commit: r1458340 - /tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 15:33:28 2013 New Revision: 1458340 URL: http://svn.apache.org/r1458340 Log: Fix regression. Always add method handlers whether there is an onOpen method or not. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java Modified: tomca

[Bug 54716] WebSocket implementation "freaks out" if Session closed or exception thrown from onOpen method

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 Nick Williams changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=87&rev2=88 nofaxpayday nordenpark\.com novolinespiele

[Tomcat Wiki] Trivial Update of "DonnyOste" by DonnyOste

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "DonnyOste" page has been changed by DonnyOste: http://wiki.apache.org/tomcat/DonnyOste New page: My name: Donny Osteen<> Age: 18<> Country: Switzerland<> Home town: St. Chrischona

[Bug 54724] WsSession does not throw IllegalStateException if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 Nick Williams changed: What|Removed |Added Summary|WsSession does not throw|WsSession does not throw

buildbot success in ASF Buildbot on tomcat-trunk

2013-03-19 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4126 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 --- Comment #5 from Nick Williams --- Nice! :-) -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomca

svn commit: r1458316 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2013-03-19 Thread kkolinko
Author: kkolinko Date: Tue Mar 19 14:40:18 2013 New Revision: 1458316 URL: http://svn.apache.org/r1458316 Log: Add changelog entry for r1457889 Reorder sections according to canonical order (as stated by a comment at the top of Changelog file) Modified: tomcat/tc7.0.x/trunk/webapps/docs/chan

[Bug 54724] WsSession does not throw IllegalState exception if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 --- Comment #1 from Mark Thomas --- 1) Agreed. 2) It is called when a close frame is received. 3) WsSession.state was not implemented with 1) in mind. Its main role was making sure the socket was closed at the right point. Some additional

[Bug 54721] RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54721 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1458308 - /tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 14:26:49 2013 New Revision: 1458308 URL: http://svn.apache.org/r1458308 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54721 RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders Patch provided by Nick Williams

[Bug 54716] WebSocket implementation "freaks out" if Session closed or exception thrown from onOpen method

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1458304 - in /tomcat/trunk: java/org/apache/tomcat/websocket/pojo/LocalStrings.properties java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java test/org/apache/tomcat/websocket/pojo

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 14:22:33 2013 New Revision: 1458304 URL: http://svn.apache.org/r1458304 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=54716 Make Calling on POJO method more robust if those methods throw an exception. Added: tomcat/trunk/test/org/apache/tomcat/web

[Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 --- Comment #4 from Mark Thomas --- About half the unit tests started failing because the request URI was null when the processing reached the WsProtocolHandler. Even though I had forgotten to call finish(), the HttpServletRequest has been

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=86&rev2=87 wearepsychics\.com webcamss\.com webdesign

svn propchange: r1458222 - svn:log

2013-03-19 Thread kkolinko
Author: kkolinko Revision: 1458222 Modified property: svn:log Modified: svn:log at Tue Mar 19 13:51:33 2013 -- --- svn:log (original) +++ svn:log Tue Mar 19 13:51:33 2013 @@ -0,0 +1,2 @@ +Merged revision 1458221 from tomca

[Tomcat Wiki] Trivial Update of "Jacquelyn" by Jacquelyn

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Jacquelyn" page has been changed by Jacquelyn: http://wiki.apache.org/tomcat/Jacquelyn New page: Connie is the name her mothers and fathers gave her but she does not like when ind

Re: [Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread Nicholas Williams
On Mar 19, 2013, at 8:31, "bugzi...@apache.org" wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 > > Mark Thomas changed: > > What|Removed |Added > > Status

buildbot failure in ASF Buildbot on tomcat-trunk

2013-03-19 Thread buildbot
The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/4125 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1458279 - in /tomcat/trunk/test/org/apache/tomcat/websocket/pojo: TestPojoMethodMapping.java Util.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 13:47:37 2013 New Revision: 1458279 URL: http://svn.apache.org/r1458279 Log: Refactor Modified: tomcat/trunk/test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java tomcat/trunk/test/org/apache/tomcat/websocket/pojo/Util.java Modified: tomcat/tru

[Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

svn commit: r1458271 - in /tomcat/trunk/java/org/apache/tomcat/websocket/server: WsHandshakeRequest.java WsServlet.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 13:30:33 2013 New Revision: 1458271 URL: http://svn.apache.org/r1458271 Log: Fix failing unit tests. Add missing call to mark the Handshake request as finished. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/server/WsHandshakeRequest.java tomcat/tru

[Bug 54724] New: WsSession does not throw IllegalState exception if closed when methods on it are called

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54724 Bug ID: 54724 Summary: WsSession does not throw IllegalState exception if closed when methods on it are called Product: Tomcat 8 Version: trunk Hardware: All

[Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 Nick Williams changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

svn commit: r1458263 - in /tomcat/trunk/java/org/apache/tomcat/websocket: WsHandshakeResponse.java WsRequest.java WsSession.java WsWebSocketContainer.java server/WsHandshakeRequest.java server/WsProto

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 13:00:43 2013 New Revision: 1458263 URL: http://svn.apache.org/r1458263 Log: Implement modifyHandshake() call Based on a patch by Nick Williams Added: tomcat/trunk/java/org/apache/tomcat/websocket/WsHandshakeResponse.java (with props) tomcat/trunk/java/or

[Bug 54715] WebSocket implementation never calls ServerEndpointConfig.Configurator#modifyHandshake()

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54715 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Tomcat Wiki] Update of "LocalBadContent" by ChuckCaldarale

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "LocalBadContent" page has been changed by ChuckCaldarale: http://wiki.apache.org/tomcat/LocalBadContent?action=diff&rev1=85&rev2=86 uebersetzungsforum\.forumieren\.eu ulcertrea

[Tomcat Wiki] Trivial Update of "Augusta61" by Augusta61

2013-03-19 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "Augusta61" page has been changed by Augusta61: http://wiki.apache.org/tomcat/Augusta61 New page: You may want to replace white pastas and breads with wholemeal varieties.<> <> If y

svn commit: r1458222 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 10:57:41 2013 New Revision: 1458222 URL: http://svn.apache.org/r1458222 Log: (empty) Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java Propchange: tomcat/tc7.0.x/trunk/ --

svn commit: r1458221 - /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 10:56:44 2013 New Revision: 1458221 URL: http://svn.apache.org/r1458221 Log: FindBugs: There needs to be the same number of place-holders as there are replacements. Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileUploadBase.java Modified

svn commit: r1458216 - in /tomcat/trunk/java: javax/websocket/server/ServerEndpointConfig.java org/apache/tomcat/websocket/server/DefaultServerEndpointConfigurator.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 10:46:19 2013 New Revision: 1458216 URL: http://svn.apache.org/r1458216 Log: Remove matchesURI as per EG discussion Modified: tomcat/trunk/java/javax/websocket/server/ServerEndpointConfig.java tomcat/trunk/java/org/apache/tomcat/websocket/server/DefaultServ

svn commit: r1458206 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/http/fileupload/ java/org/apache/tomcat/util/http/fileupload/util/mime/ webapps/docs/

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 10:13:17 2013 New Revision: 1458206 URL: http://svn.apache.org/r1458206 Log: Update Fileupload Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) tomcat/tc7.0.x/trunk/ja

Re: svn commit: r1458187 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: ./ util/mime/Base64Decoder.java util/mime/MimeUtility.java

2013-03-19 Thread Konstantin Kolinko
2013/3/19 : > Author: markt > Date: Tue Mar 19 09:29:16 2013 > New Revision: 1458187 > > URL: http://svn.apache.org/r1458187 > Log: > Syncing with Commons Fileupload trunk > > Modified: > tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ (props > changed) > > tomcat/trunk/java/

svn commit: r1458200 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: FileItem.java util/mime/Base64Decoder.java util/mime/MimeUtility.java util/mime/QuotedPrintableDecoder.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 10:07:32 2013 New Revision: 1458200 URL: http://svn.apache.org/r1458200 Log: Updates after reviewing diff between Tomcat and Commons versions of Fileupload Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/FileItem.java tomcat/trunk/java/or

svn commit: r1458192 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: ./ package-info.java util/mime/Base64Decoder.java util/mime/MimeUtility.java util/mime/QuotedPrintableDecoder.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 09:51:46 2013 New Revision: 1458192 URL: http://svn.apache.org/r1458192 Log: Syncing with Commons Fileupload trunk Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/

svn commit: r1458187 - in /tomcat/trunk/java/org/apache/tomcat/util/http/fileupload: ./ util/mime/Base64Decoder.java util/mime/MimeUtility.java

2013-03-19 Thread markt
Author: markt Date: Tue Mar 19 09:29:16 2013 New Revision: 1458187 URL: http://svn.apache.org/r1458187 Log: Syncing with Commons Fileupload trunk Modified: tomcat/trunk/java/org/apache/tomcat/util/http/fileupload/ (props changed) tomcat/trunk/java/org/apache/tomcat/util/http/fileupload

[Bug 54178] MESSAGE POST to tomcat, but it called doGet

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54178 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|---

[Bug 54609] Running service install on 7.0.37 on Windows 2008 adds unexpected characters to service executable path

2013-03-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=54609 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---