Author: markt Date: Tue Mar 19 15:33:28 2013 New Revision: 1458340 URL: http://svn.apache.org/r1458340 Log: Fix regression. Always add method handlers whether there is an onOpen method or not.
Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java Modified: tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java?rev=1458340&r1=1458339&r2=1458340&view=diff ============================================================================== --- tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java (original) +++ tomcat/trunk/java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java Tue Mar 19 15:33:28 2013 @@ -58,23 +58,27 @@ public abstract class PojoEndpointBase e methodMapping.getOnOpen().invoke(pojo, methodMapping.getOnOpenArgs(pathParameters, session)); - for (MessageHandler mh : methodMapping.getMessageHandlers(pojo, - pathParameters, session, config)) { - session.addMessageHandler(mh); - } } catch (IllegalAccessException e) { // Reflection related problems log.error(sm.getString( "pojoEndpointBase.onOpenFail", pojo.getClass().getName()), e); handleOnOpenError(session, e); + return; } catch (InvocationTargetException e) { Throwable cause = e.getCause(); handleOnOpenError(session, cause); + return; } catch (Throwable t) { handleOnOpenError(session, t); + return; } } + + for (MessageHandler mh : methodMapping.getMessageHandlers(pojo, + pathParameters, session, config)) { + session.addMessageHandler(mh); + } } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org