https://issues.apache.org/bugzilla/show_bug.cgi?id=54715
Nick Williams <nicho...@nicholaswilliams.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |---
--- Comment #2 from Nick Williams <nicho...@nicholaswilliams.net> ---
There's only one problem I see: The implementations of getRequestURI,
getParameterMap and getHeaders, according to your comment, all assume they only
get called zero or one times, and so all calculate their values on-the-fly.
However, all three of these methods DO get called in WsProtocolHandler when it
creates a new WsSession, so they are already called at least once. If the
developer also calls them, they will get called TWICE. Plus, I've been known
(and I've seen it plenty of other places, too), to do something like this,
instead of creating a local reference:
request.getParameterMap().get("var1")
request.getParameterMap().get("var2")
request.getParameterMap().get("var3")
This could get very inefficient fast.
I think the values these three methods return should be calculated only once,
no matter how many times they are called.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
