Re: [VOTE] Release Apache Tomcat Connectors 1.2.32

2011-07-06 Thread Wendal Chen
Stable +1: Ubuntu 10.04.02 2011/7/7 Jim Jagielski > > On Jul 4, 2011, at 2:34 AM, Mladen Turk wrote: > > The proposed 1.2.32 release is: > > [X] Stable - go ahead and release as 1.2.32 Stable > > [ ] Broken - do not release > > +1: OSX and Fed14 > > --

DO NOT REPLY [Bug 51468] Redirect Valve

2011-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468 Christopher Schultz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1143610 - in /tomcat/tc7.0.x: TOMCAT_7_0_18/ tags/TOMCAT_7_0_18/

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 23:24:13 2011 New Revision: 1143610 URL: http://svn.apache.org/viewvc?rev=1143610&view=rev Log: Put tag in right place Added: tomcat/tc7.0.x/tags/TOMCAT_7_0_18/ - copied from r1143609, tomcat/tc7.0.x/TOMCAT_7_0_18/ Removed: tomcat/tc7.0.x/TOMCAT_7_0_18

svn commit: r1143609 - in /tomcat/trunk: build.properties.default res/maven/mvn.properties.default

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 23:22:06 2011 New Revision: 1143609 URL: http://svn.apache.org/viewvc?rev=1143609&view=rev Log: Update ready for next release Modified: tomcat/trunk/build.properties.default tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/build.properti

svn commit: r1143607 - in /tomcat/tc7.0.x/TOMCAT_7_0_18: ./ build.properties.default modules/

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 23:21:15 2011 New Revision: 1143607 URL: http://svn.apache.org/viewvc?rev=1143607&view=rev Log: Tag 7.0.18 Added: tomcat/tc7.0.x/TOMCAT_7_0_18/ - copied from r1143606, tomcat/trunk/ Removed: tomcat/tc7.0.x/TOMCAT_7_0_18/modules/ Modified: tomcat/tc

svn commit: r1143605 - /tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 23:12:15 2011 New Revision: 1143605 URL: http://svn.apache.org/viewvc?rev=1143605&view=rev Log: Remove debug code Modified: tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java Modified: tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimit

Re: svn commit: r1143488 - /tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java

2011-07-06 Thread Mark Thomas
On 07/07/2011 00:08, Konstantin Kolinko wrote: > 2011/7/6 : >> Author: markt >> Date: Wed Jul 6 16:31:31 2011 >> New Revision: 1143488 >> >> URL: http://svn.apache.org/viewvc?rev=1143488&view=rev >> Log: >> Refactor to avoid NPEs during test >> >> Modified: >>tomcat/trunk/test/org/apache/tomc

Re: svn commit: r1143488 - /tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java

2011-07-06 Thread Konstantin Kolinko
2011/7/6 : > Author: markt > Date: Wed Jul  6 16:31:31 2011 > New Revision: 1143488 > > URL: http://svn.apache.org/viewvc?rev=1143488&view=rev > Log: > Refactor to avoid NPEs during test > > Modified: >    tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java > > @@ -120,6 +113,8 @

DO NOT REPLY [Bug 51468] Redirect Valve

2011-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51468 --- Comment #12 from Sergey Ushakov 2011-07-06 22:31:04 UTC --- Just one more word regarding reluctance to incorporate existing mature functionality into Tomcat. I would personally be happy to use UrlRewrite for the mentioned tasks if thi

Re: [VOTE] Release Apache Tomcat Connectors 1.2.32

2011-07-06 Thread Jim Jagielski
On Jul 4, 2011, at 2:34 AM, Mladen Turk wrote: > The proposed 1.2.32 release is: > [X] Stable - go ahead and release as 1.2.32 Stable > [ ] Broken - do not release +1: OSX and Fed14 - To unsubscribe, e-mail: dev-unsubscr...@tomc

svn commit: r1143488 - /tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 16:31:31 2011 New Revision: 1143488 URL: http://svn.apache.org/viewvc?rev=1143488&view=rev Log: Refactor to avoid NPEs during test Modified: tomcat/trunk/test/org/apache/tomcat/util/threads/TestLimitLatch.java Modified: tomcat/trunk/test/org/apache/tomcat/util/

svn commit: r1143457 - in /tomcat/trunk: java/org/apache/coyote/http11/ webapps/docs/

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 15:05:45 2011 New Revision: 1143457 URL: http://svn.apache.org/viewvc?rev=1143457&view=rev Log: Correct regression caused by connector re-factoring that meant that sendfile data was not reset between pipe-lined HTTP requests. Modified: tomcat/trunk/java/org/apa

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 13:26, Mark Thomas wrote: > On 06/07/2011 12:26, Konstantin Kolinko wrote: >> 2011/7/6 Mark Thomas : >>> On 06/07/2011 08:55, Konstantin Kolinko wrote: I have doubts regarding this change. If I understand correctly, recycle() (and thus recycleInternal()) is not ca

svn commit: r1143380 - /tomcat/trunk/webapps/docs/changelog.xml

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 12:34:27 2011 New Revision: 1143380 URL: http://svn.apache.org/viewvc?rev=1143380&view=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/

svn commit: r1143379 - in /tomcat/trunk: java/org/apache/catalina/tribes/transport/ReceiverBase.java webapps/docs/changelog.xml

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 12:31:50 2011 New Revision: 1143379 URL: http://svn.apache.org/viewvc?rev=1143379&view=rev Log: Add sync to fix test failures on Linux. Should have minimal impact in normal Tomcat usage since each instance/JVM only opens a single socket. Modified: tomcat/trunk/

Re: svn commit: r1143334 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 12:16, Mark Thomas wrote: > On 06/07/2011 11:51, ma...@apache.org wrote: >> Author: markt >> Date: Wed Jul 6 10:51:18 2011 >> New Revision: 1143334 >> >> URL: http://svn.apache.org/viewvc?rev=1143334&view=rev >> Log: >> Refactor the bind call to reduce the length of the stack traces

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 12:26, Konstantin Kolinko wrote: > 2011/7/6 Mark Thomas : >> On 06/07/2011 08:55, Konstantin Kolinko wrote: >>> I have doubts regarding this change. >>> >>> If I understand correctly, recycle() (and thus recycleInternal()) is >>> not called when several requests are processed in a ro

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Mark Thomas : > On 06/07/2011 08:55, Konstantin Kolinko wrote: >> I have doubts regarding this change. >> >> If I understand correctly,  recycle() (and thus recycleInternal()) is >> not called when several requests are processed in a row. > > Recycle is called between every request, keepin

Re: svn commit: r1143334 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 11:51, ma...@apache.org wrote: > Author: markt > Date: Wed Jul 6 10:51:18 2011 > New Revision: 1143334 > > URL: http://svn.apache.org/viewvc?rev=1143334&view=rev > Log: > Refactor the bind call to reduce the length of the stack traces when the unit > tests fail. It probably won't f

svn commit: r1143334 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/ReceiverBase.java

2011-07-06 Thread markt
Author: markt Date: Wed Jul 6 10:51:18 2011 New Revision: 1143334 URL: http://svn.apache.org/viewvc?rev=1143334&view=rev Log: Refactor the bind call to reduce the length of the stack traces when the unit tests fail. It probably won't fix the issue but it will make the logs easier to read. Modi

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Mark Thomas
On 06/07/2011 08:55, Konstantin Kolinko wrote: > I have doubts regarding this change. > > If I understand correctly, recycle() (and thus recycleInternal()) is > not called when several requests are processed in a row. Recycle is called between every request, keeping in mind that a Comet request

Re: Something is wrong with TC7 uninstaller (Windows)

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Konstantin Kolinko : > There is some bug in the uninstaller: > > It deleted *all* shortcuts from Windows Menu (both for me and for All Users), > not only Tomcat ones. > > I just noticed after rebooting, that none of my Startup shortcuts did > run -- they have been deleted. > > Please bewar

Something is wrong with TC7 uninstaller (Windows)

2011-07-06 Thread Konstantin Kolinko
There is some bug in the uninstaller: It deleted *all* shortcuts from Windows Menu (both for me and for All Users), not only Tomcat ones. I just noticed after rebooting, that none of my Startup shortcuts did run -- they have been deleted. Please beware while testing. It might be my fault, but

DO NOT REPLY [Bug 51472] Bugin ? in BeanELResolver.getMethod()

2011-07-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51472 --- Comment #4 from Konstantin Kolinko 2011-07-06 08:51:05 UTC --- (In reply to comment #3) Yes, as designed. For reference, the discussion that Mark mentions http://markmail.org/message/zpyvs4vqj2whqloo -- Configure bugmail: https://is

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-06 Thread Konstantin Kolinko
2011/7/6 Rainer Jung : > Hi Konstantin, > > On 06.07.2011 08:03, Konstantin Kolinko wrote: >> 1. JavaDoc for the method has to be updated. It still says that the >> name is quoted. > > Will fix. > >> 2. If I understand correctly, the name _is_ used directly, in >> AbstractConnectionHandler.register

Re: svn commit: r1137440 - in /tomcat/trunk/java/org/apache/coyote/http11: Http11AprProcessor.java Http11NioProcessor.java

2011-07-06 Thread Konstantin Kolinko
I have doubts regarding this change. If I understand correctly, recycle() (and thus recycleInternal()) is not called when several requests are processed in a row. So, in the old code sendfile is set to null before each request, in the new code it is set to null only once after connection is clo

Re: svn commit: r1135088 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2011-07-06 Thread Rainer Jung
Hi Konstantin, On 06.07.2011 08:03, Konstantin Kolinko wrote: > 1. JavaDoc for the method has to be updated. It still says that the > name is quoted. Will fix. > 2. If I understand correctly, the name _is_ used directly, in > AbstractConnectionHandler.register(): > ... ",worker=" + getProtocol()