On 06/07/2011 13:26, Mark Thomas wrote: > On 06/07/2011 12:26, Konstantin Kolinko wrote: >> 2011/7/6 Mark Thomas <ma...@apache.org>: >>> On 06/07/2011 08:55, Konstantin Kolinko wrote: >>>> I have doubts regarding this change. >>>> >>>> If I understand correctly, recycle() (and thus recycleInternal()) is >>>> not called when several requests are processed in a row. >>> >>> Recycle is called between every request, keeping in mind that a Comet >>> request may involve multiple reads and writes and that Async requests >>> may have multiple writes. >> >> I do not have much time to dig at the moment, >> but my understanding was that recycle() clears the input buffer. Thus >> it cannot be called when there is data in it. The method that is >> called between requests when there are data is prepareRequest(). >> >> All this happens while looping inside process() call. > > I'll double check what happens when pipe-lining requests. That wasn't > something I had in mind when looking at it before. Worst case, we need > two recycle methods.
Yep, the sendfileData does need to be nulled. Looking at options for doing this now. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
