DO NOT REPLY [Bug 48925] ((ServletRequest) request).getLocalAddr() returns "null"

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48925 --- Comment #1 from Steven Yates 2010-05-21 02:13:27 EDT --- Paul, can you reproduce this with a test case? If so please attach and I will be happy to take a look at it for you. RGS SY -- Configure bugmail: https://issues.apache.org/bug

svn commit: r946849 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/startup/Catalina.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2010-05-20 Thread kkolinko
Author: kkolinko Date: Fri May 21 01:38:20 2010 New Revision: 946849 URL: http://svn.apache.org/viewvc?rev=946849&view=rev Log: Log any unexpected errors that might occur during server shutdown from the shutdown hook, and do not forget to shutdown (read: flush) the logging subsystem. Modified:

svn commit: r946844 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/ApplicationContext.java java/org/apache/catalina/core/LocalStrings.properties webapps/docs/changelog.xml

2010-05-20 Thread kkolinko
Author: kkolinko Date: Fri May 21 01:19:48 2010 New Revision: 946844 URL: http://svn.apache.org/viewvc?rev=946844&view=rev Log: Log unexpected errors in ApplicationContext#getResource() and #getResourceAsStream() This is inspired by https://issues.apache.org/bugzilla/show_bug.cgi?id=49218#c0 whe

svn commit: r946841 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2010-05-20 Thread kkolinko
Author: kkolinko Date: Fri May 21 00:56:52 2010 New Revision: 946841 URL: http://svn.apache.org/viewvc?rev=946841&view=rev Log: Fix possible overflows when calculating session statistics. It fixes a) miscalculating the "average" because of multiplication overflow, and b) possible ArithmeticExcepti

svn commit: r946840 - in /tomcat/tc5.5.x/trunk: STATUS.txt container/catalina/src/share/org/apache/catalina/session/StandardSession.java container/webapps/docs/changelog.xml

2010-05-20 Thread kkolinko
Author: kkolinko Date: Fri May 21 00:53:27 2010 New Revision: 946840 URL: http://svn.apache.org/viewvc?rev=946840&view=rev Log: Fix possible overflows when calculating session statistics. It fixes a) miscalculating the "average" because of multiplication overflow, and b) possible ArithmeticExcepti

DO NOT REPLY [Bug 47785] Cluster MBean not registered

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47785 Mark Thomas changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|WORKSFOR

svn commit: r946751 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 18:43:01 2010 New Revision: 946751 URL: http://svn.apache.org/viewvc?rev=946751&view=rev Log: proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/

svn commit: r946746 - /tomcat/trunk/java/org/apache/tomcat/util/buf/UDecoder.java

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 18:28:39 2010 New Revision: 946746 URL: http://svn.apache.org/viewvc?rev=946746&view=rev Log: Tabs to 8 spaces. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/UDecoder.java Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/

svn commit: r946740 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf: B2CConverter.java UDecoder.java

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 18:16:34 2010 New Revision: 946740 URL: http://svn.apache.org/viewvc?rev=946740&view=rev Log: CTR: Tabs to 8 spaces. No functional change. Technically, it is a merge of r451510 and r519362 from tc5.5.x. Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/u

svn commit: r946716 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 17:12:10 2010 New Revision: 946716 URL: http://svn.apache.org/viewvc?rev=946716&view=rev Log: Improvement suggested by Sebastian Bazley. Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java Modified: tomcat/trunk/java/org/apache/cata

DO NOT REPLY [Bug 49292] Memory leak in org.apache.taglibs.standard.lang.jstl.ELEvaluator

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292 --- Comment #7 from pmd1nh...@yahoo.com 2010-05-20 13:10:05 EDT --- Hi, Can you please share the application/JSP source that you used to test this? I don't have a test case for this as the dump was sent in by one of our customers. Thank

svn commit: r946712 - /tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 17:02:06 2010 New Revision: 946712 URL: http://svn.apache.org/viewvc?rev=946712&view=rev Log: Tabs to 8 spaces. No functional change. Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/CharChunk.java Modified: tomcat/trunk/java/org/apache/tomcat/util/buf

svn commit: r946708 - in /tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/buf: ByteChunk.java CharChunk.java

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 16:57:05 2010 New Revision: 946708 URL: http://svn.apache.org/viewvc?rev=946708&view=rev Log: CTR: Tabs to 8 spaces. No functional change. Technically, it is a merge of r449335 from tc5.5.x, and brings formatting in sync with tc5.5.x and trunk. Some patches will

Re: svn commit: r946671 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-05-20 Thread sebb
On 20/05/2010, jfcl...@apache.org wrote: > Author: jfclere > Date: Thu May 20 15:25:13 2010 > New Revision: 946671 > > URL: http://svn.apache.org/viewvc?rev=946671&view=rev > Log: > Prevent core due to wrong synchronisation. > > Modified: > tomcat/trunk/java/org/apache/catalina/core/AprL

svn commit: r946707 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 16:52:16 2010 New Revision: 946707 URL: http://svn.apache.org/viewvc?rev=946707&view=rev Log: The SSL gets cleaned too. Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java Modified: tomcat/trunk/java/org/apache/catalina/core/AprLife

Re: svn commit: r946671 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-05-20 Thread sebb
On 20/05/2010, Mark Thomas wrote: > On 20/05/2010 16:25, jfcl...@apache.org wrote: > > Author: jfclere > > Date: Thu May 20 15:25:13 2010 > > New Revision: 946671 > > > > URL: http://svn.apache.org/viewvc?rev=946671&view=rev > > Log: > > Prevent core due to wrong synchronisation. > > > >

[Tomcat Wiki] Update of "HowTo" by ChuckCaldarale

2010-05-20 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "HowTo" page has been changed by ChuckCaldarale. The comment on this change is: Clarify default servlet usage.. http://wiki.apache.org/tomcat/HowTo?action=diff&rev1=91&rev2=92 -

svn commit: r946691 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 16:24:12 2010 New Revision: 946691 URL: http://svn.apache.org/viewvc?rev=946691&view=rev Log: proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/

svn commit: r946686 - /tomcat/trunk/bin/tool-wrapper.sh

2010-05-20 Thread kkolinko
Author: kkolinko Date: Thu May 20 16:19:49 2010 New Revision: 946686 URL: http://svn.apache.org/viewvc?rev=946686&view=rev Log: Additional fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48840 Port the fix from catalina.sh to tool-wrapper.sh as well. Modified: tomcat/trunk/bin/tool

svn commit: r946677 - in /tomcat/trunk/java/org/apache: catalina/core/AprLifecycleListener.java tomcat/util/net/AprEndpoint.java

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 15:50:51 2010 New Revision: 946677 URL: http://svn.apache.org/viewvc?rev=946677&view=rev Log: Oops... Minor errors. Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java

svn commit: r946674 - in /tomcat/trunk/java/org/apache: coyote/ajp/ coyote/http11/ tomcat/util/net/ tomcat/util/net/res/

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 15:42:17 2010 New Revision: 946674 URL: http://svn.apache.org/viewvc?rev=946674&view=rev Log: Arrange APR logic. Modified: tomcat/trunk/java/org/apache/coyote/ajp/AjpAprProtocol.java tomcat/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java to

svn commit: r946673 - /tomcat/trunk/build.xml

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 15:41:10 2010 New Revision: 946673 URL: http://svn.apache.org/viewvc?rev=946673&view=rev Log: Needed to test APR. Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=946673&r1=946672&

Re: svn commit: r946671 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-05-20 Thread Mark Thomas
On 20/05/2010 16:25, jfcl...@apache.org wrote: > Author: jfclere > Date: Thu May 20 15:25:13 2010 > New Revision: 946671 > > URL: http://svn.apache.org/viewvc?rev=946671&view=rev > Log: > Prevent core due to wrong synchronisation. > > Modified: > tomcat/trunk/java/org/apache/catalina/core/Apr

svn commit: r946671 - /tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 15:25:13 2010 New Revision: 946671 URL: http://svn.apache.org/viewvc?rev=946671&view=rev Log: Prevent core due to wrong synchronisation. Modified: tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java Modified: tomcat/trunk/java/org/apache/cata

RE: Tomcat NTLM authentication

2010-05-20 Thread dB .
I'll move it to the dev list, since it doesn't really belong on the users' one. The reason why you don't have it in Tomcat yet is cause it's not easy. To do Negotiate (NTLM / Kerberos) you need to basically call one windows API (AcceptSecurityContext). All other methods don't really work. Then y

svn commit: r946620 - in /tomcat/trunk/test/org/apache/catalina/startup: TestTomcatSSL.java test-cert.pem test-key.pem

2010-05-20 Thread jfclere
Author: jfclere Date: Thu May 20 13:14:20 2010 New Revision: 946620 URL: http://svn.apache.org/viewvc?rev=946620&view=rev Log: Add the certificate and key for the APR tests. Added: tomcat/trunk/test/org/apache/catalina/startup/test-cert.pem tomcat/trunk/test/org/apache/catalina/startup/te

DO NOT REPLY [Bug 49320] jpa annotaion entity exception when package to a jar

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49320 Konstantin Kolinko changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #1 from

DO NOT REPLY [Bug 49320] New: jpa annotaion entity exception when package to a jar

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49320 Summary: jpa annotaion entity exception when package to a jar Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW Severity: major

svn commit: r946604 - in /tomcat/trunk/java/org/apache/catalina: ant/AbstractCatalinaTask.java realm/JNDIRealm.java session/ManagerBase.java util/Base64.java

2010-05-20 Thread markt
Author: markt Date: Thu May 20 12:07:38 2010 New Revision: 946604 URL: http://svn.apache.org/viewvc?rev=946604&view=rev Log: Minor clean-up. Result is always converted to String so just do it once. Modified: tomcat/trunk/java/org/apache/catalina/ant/AbstractCatalinaTask.java tomcat/trunk/

Re: svn commit: r946583 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2010-05-20 Thread Konstantin Kolinko
2010/5/20 : > Author: markt > Date: Thu May 20 09:48:43 2010 > New Revision: 946583 > >         // Must have a real docBase - just use temp > -        Context ctx = > -            tomcat.addContext("/", System.getProperty("java.io.tmpdir")); > +        File docBase = new File(System.getProperty("

DO NOT REPLY [Bug 49317] org.apache.catalina.util.Base64 interface needs refactoring

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49317 Mark Thomas changed: What|Removed |Added Severity|normal |enhancement --- Comment #1 from Mark

DO NOT REPLY [Bug 49318] add a Negotiate (Kerberos/NTLM) authenticator / integrate Waffle

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49318 dB. changed: What|Removed |Added Severity|normal |enhancement -- Configure bugmail: https://i

DO NOT REPLY [Bug 49318] New: add a Negotiate (Kerberos/NTLM) authenticator / integrate Waffle

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49318 Summary: add a Negotiate (Kerberos/NTLM) authenticator / integrate Waffle Product: Tomcat 7 Version: trunk Platform: PC URL: http://waffle.codeplex.com OS/

DO NOT REPLY [Bug 49317] New: org.apache.catalina.util.Base64 interface needs refactoring

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49317 Summary: org.apache.catalina.util.Base64 interface needs refactoring Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows Server 2003 Status: NEW

DO NOT REPLY [Bug 49316] New: org.apache.tomcat.lite.util.Base64 broken

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49316 Summary: org.apache.tomcat.lite.util.Base64 broken Product: Tomcat 7 Version: unspecified Platform: PC OS/Version: Windows Server 2003 Status: NEW Severity: major

svn commit: r946591 - in /tomcat/trunk/java/org/apache/jasper/compiler: Parser.java ParserController.java SmapUtil.java TagFileProcessor.java TagLibraryInfoImpl.java

2010-05-20 Thread markt
Author: markt Date: Thu May 20 11:06:33 2010 New Revision: 946591 URL: http://svn.apache.org/viewvc?rev=946591&view=rev Log: Remove unused code identified by Eclipse Modified: tomcat/trunk/java/org/apache/jasper/compiler/Parser.java tomcat/trunk/java/org/apache/jasper/compiler/ParserContr

svn commit: r946584 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2010-05-20 Thread markt
Author: markt Date: Thu May 20 09:49:24 2010 New Revision: 946584 URL: http://svn.apache.org/viewvc?rev=946584&view=rev Log: Fix lost session path parameter on redirect Modified: tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java Modified: tomcat/trunk/java/org/apache/catalin

svn commit: r946583 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2010-05-20 Thread markt
Author: markt Date: Thu May 20 09:48:43 2010 New Revision: 946583 URL: http://svn.apache.org/viewvc?rev=946583&view=rev Log: REpurpose the duplicate pathPath test to test the redirect process Modified: tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java Modified: tomcat/tr

DO NOT REPLY [Bug 49292] Memory leak in org.apache.taglibs.standard.lang.jstl.ELEvaluator

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292 --- Comment #6 from nebur43 2010-05-20 05:38:46 EDT --- Created an attachment (id=25461) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25461) snapshot new ELEvaluator -- Configure bugmail: https://issues.apache.org/bugzilla/u

DO NOT REPLY [Bug 49292] Memory leak in org.apache.taglibs.standard.lang.jstl.ELEvaluator

2010-05-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292 --- Comment #5 from nebur43 2010-05-20 05:35:34 EDT --- Hi again, I just have tested the jar and seems to work correctly. Sorry, but your jar seems not to be correctly. In your first snapshot you can see these: - ELEvaluator - Coll

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC2

2010-05-20 Thread Mark Thomas
On 20/05/2010 10:23, jean-frederic clere wrote: > On 05/20/2010 11:10 AM, Mark Thomas wrote: >> On 20/05/2010 07:55, jean-frederic clere wrote: >>> The TC tests are crashing the JVM with and without my patch. Should I >>> commit the patch anyway? >> >> The TCK tests? > > No: in the TC tests: ant t

Re: [g...@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

2010-05-20 Thread Mark Thomas
On 20/05/2010 03:00, Konstantin Kolinko wrote: > The problem is that the request for /foo servlet on Gump is not > served, but is redirected to /foo/, and that redirection loses the > "jsessionid" parameter. > > // Must have a real docBase - just use temp > Context ctx = >

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC2

2010-05-20 Thread jean-frederic clere
On 05/20/2010 11:10 AM, Mark Thomas wrote: > On 20/05/2010 07:55, jean-frederic clere wrote: >> The TC tests are crashing the JVM with and without my patch. Should I >> commit the patch anyway? > > The TCK tests? No: in the TC tests: ant tests. The problem is located in AprLifecycleListener and/o

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC2

2010-05-20 Thread Mark Thomas
On 20/05/2010 07:55, jean-frederic clere wrote: > The TC tests are crashing the JVM with and without my patch. Should I > commit the patch anyway? The TCK tests? I ran the Servlet TCK with APR/native on Windows 64-bit without any crashes. I'd commit it. We can always back it out if there is a pro