https://issues.apache.org/bugzilla/show_bug.cgi?id=49305
Chuck Caldarale changed:
What|Removed |Added
Priority|P2 |P5
Platform|PC
https://issues.apache.org/bugzilla/show_bug.cgi?id=49305
Summary: Spurious manager.xml file in webapps/host-manager
Product: Tomcat 7
Version: unspecified
Platform: PC
OS/Version: Windows Vista
Status: NEW
Severity: normal
Author: kkolinko
Date: Tue May 18 01:07:10 2010
New Revision: 945446
URL: http://svn.apache.org/viewvc?rev=945446&view=rev
Log:
Do not abort testing after the first failure,
but report about existence of failures after all the tests were run.
Modified:
tomcat/trunk/build.xml
Modified: tomcat
On Mon, May 17, 2010 at 10:41 AM, Mark Thomas wrote:
> I have drafted an announcement of the upcoming TC7 release for our first
> blog post. It can be previewed here:
>
> http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
>
> Suggestions for improvements welcome.
Looks
2010/5/17 Rainer Jung :
> On 17.05.2010 19:56, Konstantin Kolinko wrote:
>>
>> 2010/5/17 Mark Thomas:
>>>
>>> I've just completed testing of trunk.
>>>
>>> Unit tests - pass
>>>
>>
>> They also pass for me, but Gump fails at TestCoyoteAdaptor:
>>
>>
>> http://vmgump.apache.org/gump/public/tomcat-tr
Author: markt
Date: Mon May 17 20:20:42 2010
New Revision: 945342
URL: http://svn.apache.org/viewvc?rev=945342&view=rev
Log:
Fix tests for a pure Ant run
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java
Modified:
tomcat/trunk/test/org/apache/catalina
On 17/05/2010 20:25, Rainer Jung wrote:
> On 17.05.2010 19:50, Konstantin Kolinko wrote:
>> 2010/5/17:
>>> Author: markt
>>> Date: Mon May 17 17:45:53 2010
>>> New Revision: 945271
>
> This breaks "ant test" for me. I run the test directly using ant,
> without Eclipse being involved. In case antF
On 17.05.2010 19:56, Konstantin Kolinko wrote:
2010/5/17 Mark Thomas:
I've just completed testing of trunk.
Unit tests - pass
They also pass for me, but Gump fails at TestCoyoteAdaptor:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-t
On 17.05.2010 19:50, Konstantin Kolinko wrote:
2010/5/17:
Author: markt
Date: Mon May 17 17:45:53 2010
New Revision: 945271
URL: http://svn.apache.org/viewvc?rev=945271&view=rev
Log:
Fix Eclipse warnings.
Reduce line length.
@@ -243,14 +253,9 @@ public class TestContextConfigAnnotation
Author: markt
Date: Mon May 17 19:24:21 2010
New Revision: 945322
URL: http://svn.apache.org/viewvc?rev=945322&view=rev
Log:
Add removed property.
Fix typos.
Modified:
tomcat/site/trunk/docs/migration.html
tomcat/site/trunk/xdocs/migration.xml
Modified: tomcat/site/trunk/docs/migration.h
On 17/05/2010 17:59, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas :
>> I have drafted an announcement of the upcoming TC7 release for our first
>> blog post. It can be previewed here:
>>
>> http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
>>
>
> Good, though some
All,
The 7.0.0-RC1 process worked reasonably well so I am going stick with
generating RC's for now. The next Tomcat 7.0.0 release candiate is ready
for testing. 7.0.0-RC2 can
be obtained from:
http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC2/
The svn tag is:
http://svn.apache.org/repos/asf/
On 17/05/2010 18:56, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas :
>> I've just completed testing of trunk.
>>
>> Unit tests - pass
>>
>
> They also pass for me, but Gump fails at TestCoyoteAdaptor:
>
> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomc
On 17.05.2010 19:56, Konstantin Kolinko wrote:
2010/5/17 Mark Thomas:
I've just completed testing of trunk.
Unit tests - pass
They also pass for me, but Gump fails at TestCoyoteAdaptor:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-t
2010/5/17 Mark Thomas :
> I've just completed testing of trunk.
>
> Unit tests - pass
>
They also pass for me, but Gump fails at TestCoyoteAdaptor:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_work/build_tomcat-trunk_tomcat-trunk-test.html
Do not know what is the deal
2010/5/17 :
> Author: markt
> Date: Mon May 17 17:45:53 2010
> New Revision: 945271
>
> URL: http://svn.apache.org/viewvc?rev=945271&view=rev
> Log:
> Fix Eclipse warnings.
> Reduce line length.
>
> @@ -243,14 +253,9 @@ public class TestContextConfigAnnotation
> if (eclipseFile.exist
Author: markt
Date: Mon May 17 17:45:53 2010
New Revision: 945271
URL: http://svn.apache.org/viewvc?rev=945271&view=rev
Log:
Fix Eclipse warnings.
Reduce line length.
Modified:
tomcat/trunk/test/org/apache/catalina/startup/DuplicateMappingParamFilter.java
tomcat/trunk/test/org/apache/ca
Author: markt
Date: Mon May 17 17:41:30 2010
New Revision: 945267
URL: http://svn.apache.org/viewvc?rev=945267&view=rev
Log:
Simplify test
Modified:
tomcat/trunk/test/org/apache/tomcat/util/http/TestBug49158.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestBug49158.java
URL:
Author: markt
Date: Mon May 17 17:38:35 2010
New Revision: 945265
URL: http://svn.apache.org/viewvc?rev=945265&view=rev
Log:
Fix Eclipse warning in webapps
Modified:
tomcat/trunk/webapps/examples/WEB-INF/classes/async/Stockticker.java
Modified: tomcat/trunk/webapps/examples/WEB-INF/classes/a
2010/5/17 Mark Thomas :
> On 17/05/2010 18:08, Mark Thomas wrote:
>> On 17/05/2010 17:50, Konstantin Kolinko wrote:
>>> I am a bit shivering looking at ([a++] != [b++]),
>>> but I did minimal changes to fix the issue.
>>
>> Understood. If I get a chance, I'll look to see if I can find an equally
>>
Author: markt
Date: Mon May 17 17:27:38 2010
New Revision: 945258
URL: http://svn.apache.org/viewvc?rev=945258&view=rev
Log:
Return version to 7.0.0-dev
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/t
Author: markt
Date: Mon May 17 17:27:08 2010
New Revision: 945257
URL: http://svn.apache.org/viewvc?rev=945257&view=rev
Log:
Tagging 7.0.0-RC2
Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_0_RC2/ (props changed)
- copied from r945256, tomcat/trunk/
Propchange: tomcat/tc7.0.x/tags/TOMCAT_7_0_
Author: markt
Date: Mon May 17 17:25:35 2010
New Revision: 945256
URL: http://svn.apache.org/viewvc?rev=945256&view=rev
Log:
Prepare for 7.0.0-RC2
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/b
I've just completed testing of trunk.
Unit tests - pass
Servlet 3.0 TCK
- BIO with security manager - pass
- NIO with security manager - pass (expected failures due to bug 49284)
- APR/native with security manager - pass
JSP 2.2 TCK
- APR/native with security manager - pass
EL 2.2 TCK
- wi
Author: markt
Date: Mon May 17 17:24:18 2010
New Revision: 945253
URL: http://svn.apache.org/viewvc?rev=945253&view=rev
Log:
Don't recommend a version that hasn't been released
Modified:
tomcat/trunk/java/org/apache/catalina/core/AprLifecycleListener.java
Modified: tomcat/trunk/java/org/apac
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-trunk-test has an issue affecting its community integration.
This i
On 17/05/2010 18:08, Mark Thomas wrote:
> On 17/05/2010 17:50, Konstantin Kolinko wrote:
>> I am a bit shivering looking at ([a++] != [b++]),
>> but I did minimal changes to fix the issue.
>
> Understood. If I get a chance, I'll look to see if I can find an equally
> good alternative.
How about (
On 17/05/2010, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas :
>
> > I have drafted an announcement of the upcoming TC7 release for our first
> > blog post. It can be previewed here:
> >
> >
> http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
> >
>
"alias supp
On 17/05/2010 17:50, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas :
>>
>> That's pretty ugly. Is there really no other way?
>>
>
> You mean, the named loop is ugly?
>
> Or the old code?
It was the named loop.
> I am a bit shivering looking at ([a++] != [b++]),
> but I did minimal changes t
2010/5/17 Mark Thomas :
> I have drafted an announcement of the upcoming TC7 release for our first
> blog post. It can be previewed here:
>
> http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
>
Good, though some of the mentioned features are already available in
the lat
2010/5/17 Mark Thomas :
>
> That's pretty ugly. Is there really no other way?
>
You mean, the named loop is ugly?
Or the old code?
I am a bit shivering looking at ([a++] != [b++]),
but I did minimal changes to fix the issue.
The code runs frequently, so I think/hope that somebody
has tried to
On 17/05/2010 17:28, kkoli...@apache.org wrote:
> Author: kkolinko
> Date: Mon May 17 16:28:44 2010
> New Revision: 945231
>
> URL: http://svn.apache.org/viewvc?rev=945231&view=rev
> Log:
> Fix a bug in ByteChunk.indexOf(String, ...)
>
> The problem is that the method could not find a string whic
Author: kkolinko
Date: Mon May 17 16:28:44 2010
New Revision: 945231
URL: http://svn.apache.org/viewvc?rev=945231&view=rev
Log:
Fix a bug in ByteChunk.indexOf(String, ...)
The problem is that the method could not find a string which length is 1,
as the only successful exit from the method was fro
Author: kkolinko
Date: Mon May 17 16:24:43 2010
New Revision: 945230
URL: http://svn.apache.org/viewvc?rev=945230&view=rev
Log:
Tests for ByteChunk indexOf/find* methods.
It caught a bug in implementation of ByteChunk.indexOf(String, ...) when
searching for a single-character string. I will comm
+1
my improvements for the list.
rewrite the internal component lifecycle management
easier tomcat embedding
used only java executor API at all connectors
Peter
Am 17.05.2010 um 16:41 schrieb Mark Thomas:
I have drafted an announcement of the upcoming TC7 release for our
first
blog post.
I wanted to give everyone here a heads up that SpringSource is looking
at some form of outreach to get some university students involved in the
Apache Tomcat project. The exact details are TBD but is likely to be
some form of pay per bug fix scheme starting in this autumn combined
with a summer int
On 05/17/2010 04:41 PM, Mark Thomas wrote:
> I have drafted an announcement of the upcoming TC7 release for our first
> blog post. It can be previewed here:
>
> http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
>
> Suggestions for improvements welcome.
>
> Note the li
Looks good to me!
On 17.05.2010 16:41, Mark Thomas wrote:
I have drafted an announcement of the upcoming TC7 release for our first
blog post. It can be previewed here:
http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
Suggestions for improvements welcome.
Note the
I have drafted an announcement of the upcoming TC7 release for our first
blog post. It can be previewed here:
http://blogs.apache.org/preview/tomcat/?previewEntry=apache_tomcat_7_released
Suggestions for improvements welcome.
Note the links won't work until we actually do the release.
Mark
-
Author: markt
Date: Mon May 17 13:56:16 2010
New Revision: 945161
URL: http://svn.apache.org/viewvc?rev=945161&view=rev
Log:
Fix some Eclipse warnings
Modified:
tomcat/trunk/test/org/apache/catalina/core/TestStandardContextResources.java
Modified:
tomcat/trunk/test/org/apache/catalina/core/
Author: markt
Date: Mon May 17 13:55:29 2010
New Revision: 945159
URL: http://svn.apache.org/viewvc?rev=945159&view=rev
Log:
Remove the dependency on MBean notifications for the mapper
Unit tests pass.
Fixes an issue with the TCK and welcome files.
Modified:
tomcat/trunk/java/org/apache/catal
Author: kkolinko
Date: Mon May 17 13:32:08 2010
New Revision: 945143
URL: http://svn.apache.org/viewvc?rev=945143&view=rev
Log:
cleanup code added in r945074
Modified:
tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
Modified: tomcat/trunk/java/org/apache/catalina/util/Lifecycle
https://issues.apache.org/bugzilla/show_bug.cgi?id=49303
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
https://issues.apache.org/bugzilla/show_bug.cgi?id=49303
Summary: Problem using "response.sendRedirect" to redirect to
URL that includes "ñ" or tilde
Product: Tomcat 5
Version: 5.5.28
Platform: PC
OS/Version: Windows XP
Author: markt
Date: Mon May 17 11:33:01 2010
New Revision: 945095
URL: http://svn.apache.org/viewvc?rev=945095&view=rev
Log:
More clean-up:
- findCharXXX to findByteXXX
- whitespace
- make code consistent where possible
Modified:
tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.j
2010/5/17 Mark Thomas :
> Given this is a major version change and that we haven't used the code
> internally, I'd be quite happy to change the name of the methods from
> findCharXXX to findByteXXX and code them all to use bytes.
>
> The code needs to be cleaned up and now is as good a time as any.
On 17/05/2010 11:35, Konstantin Kolinko wrote:
> I cannot say for sure what the intended usage of findChar() is. Given
> that the method was not used, we can remove those find* methods
> (though I do not see much benefit from removing), but I do not like
> changing its behaviour.
Got it. I saw c
Author: markt
Date: Mon May 17 10:47:50 2010
New Revision: 945074
URL: http://svn.apache.org/viewvc?rev=945074&view=rev
Log:
Wrap debug message is usual tyest
Modified:
tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
Modified: tomcat/trunk/java/org/apache/catalina/util/Lifecycl
Author: markt
Date: Mon May 17 10:47:03 2010
New Revision: 945073
URL: http://svn.apache.org/viewvc?rev=945073&view=rev
Log:
Add some debug logging for state changes
Modified:
tomcat/trunk/java/org/apache/catalina/util/LifecycleBase.java
tomcat/trunk/java/org/apache/catalina/util/LocalStr
Author: markt
Date: Mon May 17 10:36:25 2010
New Revision: 945071
URL: http://svn.apache.org/viewvc?rev=945071&view=rev
Log:
Correct example
Modified:
tomcat/trunk/conf/logging.properties
Modified: tomcat/trunk/conf/logging.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/conf/logg
2010/5/17 Mark Thomas :
> On 17/05/2010 10:47, Konstantin Kolinko wrote:
>> 2010/5/17 Mark Thomas :
>>> On 17/05/2010 09:49, Konstantin Kolinko wrote:
findChar() was the "correct" implementation.
It is indexOf() that is 0-127.
>>>
>>> We could fix that but given the current usage, I am ha
Author: markt
Date: Mon May 17 10:35:04 2010
New Revision: 945070
URL: http://svn.apache.org/viewvc?rev=945070&view=rev
Log:
Align comment and example
Modified:
tomcat/trunk/conf/logging.properties
Modified: tomcat/trunk/conf/logging.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk
Author: markt
Date: Mon May 17 10:29:04 2010
New Revision: 945067
URL: http://svn.apache.org/viewvc?rev=945067&view=rev
Log:
Fix comments
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
URL:
http://s
On 17/05/2010 10:47, Konstantin Kolinko wrote:
> 2010/5/17 Mark Thomas :
>> On 17/05/2010 09:49, Konstantin Kolinko wrote:
>>> findChar() was the "correct" implementation.
>>> It is indexOf() that is 0-127.
>>
>> We could fix that but given the current usage, I am happy with just
>> supporting 0-12
2010/5/17 Mark Thomas :
> On 17/05/2010 09:49, Konstantin Kolinko wrote:
>> findChar() was the "correct" implementation.
>> It is indexOf() that is 0-127.
>
> We could fix that but given the current usage, I am happy with just
> supporting 0-127.
>
I am happy with the old code:
- indexOf() support
On 17/05/2010 09:49, Konstantin Kolinko wrote:
> findChar() was the "correct" implementation.
> It is indexOf() that is 0-127.
Putting one side the error in my comments, I prefer the widening
conversion to the narrowing one for two reasons:
1. No chance of false positive on the match
2. It is what
2010/5/17 Mark Thomas :
> On 17/05/2010 00:03, Konstantin Kolinko wrote:
>> 2010/5/17 :
>>> Author: markt
>>> Date: Sun May 16 21:31:57 2010
>>> New Revision: 944918
>>>
>>> URL: http://svn.apache.org/viewvc?rev=944918&view=rev
>>> Log:
>>> Code clean-up
>>>
>>> Modified:
>>> tomcat/trunk/java/
Author: markt
Date: Mon May 17 08:26:43 2010
New Revision: 945016
URL: http://svn.apache.org/viewvc?rev=945016&view=rev
Log:
findChar is inconsistent in that it only supports characters in the range 0-127
while all the other methods support all single byte characters.
It isn't used within the Tom
Author: markt
Date: Mon May 17 08:20:00 2010
New Revision: 945014
URL: http://svn.apache.org/viewvc?rev=945014&view=rev
Log:
Improve comments, make param names consistent, clean up formatting.
No functional change.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
Modifie
Author: markt
Date: Mon May 17 07:51:31 2010
New Revision: 945007
URL: http://svn.apache.org/viewvc?rev=945007&view=rev
Log:
Revert r944918
Modified:
tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.java
URL:
http:/
On 17/05/2010 00:03, Konstantin Kolinko wrote:
> 2010/5/17 :
>> Author: markt
>> Date: Sun May 16 21:31:57 2010
>> New Revision: 944918
>>
>> URL: http://svn.apache.org/viewvc?rev=944918&view=rev
>> Log:
>> Code clean-up
>>
>> Modified:
>>tomcat/trunk/java/org/apache/tomcat/util/buf/ByteChunk.
61 matches
Mail list logo
