On 17/05/2010 10:47, Konstantin Kolinko wrote: > 2010/5/17 Mark Thomas <ma...@apache.org>: >> On 17/05/2010 09:49, Konstantin Kolinko wrote: >>> findChar() was the "correct" implementation. >>> It is indexOf() that is 0-127. >> >> We could fix that but given the current usage, I am happy with just >> supporting 0-127. >> > > I am happy with the old code: > - indexOf() supporting 0-127, > as it is only used to search for chars like '%', '=', '&' which are > 0-127, --- I agree with you. > - I think findChar() should still support 0-255 as it did.
findChar() was the only method that used a narrowing conversion and it was never used. findChars() and both indexOf() methods supported 0-127. Given findChar() was never used and the intended usage of these methods, I'd rather that findChar() was consistent with the other methods. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
