Agreed. I think this is good stuff, there are a lot of bad asserts in our
tests, and this will only help make debugging easier.
I'm going to try my best to get through the PR over the next few days.
- Houston
On Tue, Oct 18, 2022 at 12:50 PM Jan Høydahl wrote:
> +1
>
> If it gets merged both t
+1
If it gets merged both to main and branch_9x it will not cause backport pain at
all for 95% of the PRs.
Kudos for caring for the "boring" parts of open source!
Jan
> 18. okt. 2022 kl. 15:35 skrev Eric Pugh :
>
> Hi all,
>
> I started, and Kevin pushed to completion
> https://issues.apache
Changeset size is ~300 files - much smaller than the thousands of files
touched by spotless.
The tangible benefits being that error messages are no longer "assertion
failed" but instead say what was different in the case of arrays the two
arrays or in the case of some equals the two values. This i
I agree that these changes are good for the codebase. But, I am very much
disturbed by the changeset size. It will make backporting, working on
existing changes etc. a massive pain. I don't see the benefit enough to
outweigh the massive loss in productivity. Solr needs improvement in
efficiency, pe
Hi all,
I started, and Kevin pushed to completion
https://issues.apache.org/jira/browse/SOLR-16311, which is to simplify our
assert logic.
It touches 330 files, all various tests…. I think it’s a great enhancement,
but before clicking merge, wanted to give a chance for someone to speak up o
