[jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

[ https://issues.apache.org/jira/browse/LOG4J2-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131541#comment-16131541 ] Remko Popma commented on LOG4J2-1896: - So, essentially, the reconnect use case preven

Jenkins build is back to normal : Log4j 2.x #3002

See

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133848915 --- Diff: tests/src/log4net.Tests.csproj --- @@ -19,245 +18,25 @@ under the License. --> -http://schemas.microsoft.com/developer

[jira] [Commented] (LOG4NET-567) Use new csproj format to target multiple frameworks

[ https://issues.apache.org/jira/browse/LOG4NET-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131429#comment-16131429 ] Charles Lowell commented on LOG4NET-567: The Jenkins build is broken because the

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133846257 --- Diff: src/Appender/AppenderSkeleton.cs --- @@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent) {

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133846136 --- Diff: src/CompatibilityExtensions.cs --- @@ -0,0 +1,53 @@ +#region Apache License +// +// Licensed to the Apache Software Foundati

Build failed in Jenkins: Log4j 2.x #3001

See Changes: [garydgregory] [LOG4J2-1896] Update classes in org.apache.logging.log4j.core.net.ssl in -- [...truncated 4.73 MB...] Uploaded: https://repository.apache.org/cont

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user chlowell commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133845941 --- Diff: tests/src/Context/LogicalThreadContextTest.cs --- @@ -17,7 +17,7 @@ // #endregion -#if NET_4_5 || NETSTANDARD1_3 +#

Re: SocketOptions builder

That's fine I think. (Shameless plug) Every java main() method deserves http://picocli.info > On Aug 18, 2017, at 7:18, Gary Gregory wrote: > > What I did not do is change the "set" methods to "with" to avoid breaking > user sources. We should do that for 3.0 I think. > > Gary > >> On Thu, A

Re: SocketOptions builder

What I did not do is change the "set" methods to "with" to avoid breaking user sources. We should do that for 3.0 I think. Gary On Thu, Aug 17, 2017 at 4:10 PM, Remko Popma wrote: > I like the idiom where setter methods return `this`, so users can chain > methods; thanks for making that change.

[jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

[ https://issues.apache.org/jira/browse/LOG4J2-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131384#comment-16131384 ] ASF subversion and git services commented on LOG4J2-1896: - Commit

Re: SocketOptions builder

I like the idiom where setter methods return `this`, so users can chain methods; thanks for making that change. On Fri, Aug 18, 2017 at 5:41 AM, Gary Gregory wrote: > Hi All and FYI: > > I plan on redoing the SocketOptions class as a real builder by making all > accessors return this. > > Any o

[jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

[ https://issues.apache.org/jira/browse/LOG4J2-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131368#comment-16131368 ] Gary Gregory commented on LOG4J2-1896: -- I added the API clearSecrets() which could b

[jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

[ https://issues.apache.org/jira/browse/LOG4J2-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131359#comment-16131359 ] ASF subversion and git services commented on LOG4J2-1896: - Commit

[jira] [Resolved] (LOG4J2-2013) SslSocketManager does not apply SSLContext on TCP reconnect

[ https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-2013. -- Resolution: Fixed In Git master. Thank you all for your help. Please verify and close. > SslSo

[jira] [Commented] (LOG4J2-2013) SslSocketManager does not apply SSLContext on TCP reconnect

[ https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131345#comment-16131345 ] ASF subversion and git services commented on LOG4J2-2013: - Commit

[jira] [Commented] (LOG4J2-1896) Update classes in org.apache.logging.log4j.core.net.ssl in APIs from String to char[] for passwords

[ https://issues.apache.org/jira/browse/LOG4J2-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131312#comment-16131312 ] Gary Gregory commented on LOG4J2-1896: -- [~rem...@yahoo.com] and others: I would lik

SocketOptions builder

Hi All and FYI: I plan on redoing the SocketOptions class as a real builder by making all accessors return this. Any objections? Gary

Jenkins build is back to stable : Log4j 2.x #2999

See

[jira] [Commented] (LOG4J2-2020) Remove default layout from KafkaAppender

[ https://issues.apache.org/jira/browse/LOG4J2-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131193#comment-16131193 ] Mikael Ståldal commented on LOG4J2-2020: I don't think that's layout is very usef

Jenkins build became unstable: Log4j 2.x #2998

See

[jira] [Commented] (LOG4J2-2020) Remove default layout from KafkaAppender

[ https://issues.apache.org/jira/browse/LOG4J2-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16131169#comment-16131169 ] Gary Gregory commented on LOG4J2-2020: -- What about using {{PatternLayout.createDefau

[jira] [Resolved] (LOG4J2-2020) Remove default layout from KafkaAppender

[ https://issues.apache.org/jira/browse/LOG4J2-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael Ståldal resolved LOG4J2-2020. Resolution: Fixed Fix Version/s: 2.9 In Git master. > Remove default layout from Ka

[jira] [Created] (LOG4J2-2020) Remove default layout from KafkaAppender

Mikael Ståldal created LOG4J2-2020: -- Summary: Remove default layout from KafkaAppender Key: LOG4J2-2020 URL: https://issues.apache.org/jira/browse/LOG4J2-2020 Project: Log4j 2 Issue Type: Im

[jira] [Commented] (LOG4J2-2013) SslSocketManager does not apply SSLContext on TCP reconnect

[ https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130634#comment-16130634 ] ASF GitHub Bot commented on LOG4J2-2013: Github user garydgregory commented on th

[GitHub] logging-log4j2 issue #108: LOG4J2-2013 Handle reconnect in SSLSocketManager ...

Github user garydgregory commented on the issue: https://github.com/apache/logging-log4j2/pull/108 I had to get some work done here, but yes, I have an almost fix that I can get back to tonight. Please be patient ;-) --- If your project is set up for it, you can reply to this email a

[jira] [Commented] (LOG4J2-2013) SslSocketManager does not apply SSLContext on TCP reconnect

[ https://issues.apache.org/jira/browse/LOG4J2-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130484#comment-16130484 ] ASF GitHub Bot commented on LOG4J2-2013: Github user taylorp36 commented on the i

[GitHub] logging-log4j2 issue #108: LOG4J2-2013 Handle reconnect in SSLSocketManager ...

Github user taylorp36 commented on the issue: https://github.com/apache/logging-log4j2/pull/108 Sure, I like the builder idea. I was hesitant to modify TcpSocketManager initially. Sounds like Gary might already have a fix though. --- If your project is set up for it, you can reply to

[jira] [Commented] (LOG4NET-567) Use new csproj format to target multiple frameworks

[ https://issues.apache.org/jira/browse/LOG4NET-567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16130367#comment-16130367 ] Dominik Psenner commented on LOG4NET-567: - You can check the build of the pull re

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133704161 --- Diff: tests/src/log4net.Tests.csproj --- @@ -19,245 +18,25 @@ under the License. --> -http://schemas.microsoft.com/developer

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133700988 --- Diff: Jenkinsfile --- @@ -61,21 +61,14 @@ pipeline { // run docker container

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133703322 --- Diff: src/Util/PatternStringConverters/UserNamePatternConverter.cs --- @@ -69,6 +69,12 @@ override protected void Convert(TextWriter writer, obj

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133703847 --- Diff: tests/src/Context/LogicalThreadContextTest.cs --- @@ -17,7 +17,7 @@ // #endregion -#if NET_4_5 || NETSTANDARD1_3 +#

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133703032 --- Diff: src/CompatibilityExtensions.cs --- @@ -0,0 +1,53 @@ +#region Apache License +// +// Licensed to the Apache Software Foundati

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133701487 --- Diff: log4net.build --- @@ -1748,48 +1748,64 @@ limitations under the License. - - + +

[GitHub] logging-log4net pull request #14: Add .NET Standard 2.0 build

Github user dpsenner commented on a diff in the pull request: https://github.com/apache/logging-log4net/pull/14#discussion_r133702415 --- Diff: src/Appender/AppenderSkeleton.cs --- @@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent) {

[GitHub] logging-log4j2 issue #29: Property log4j.skipJansi should have a default of ...

Github user mikaelstaldal commented on the issue: https://github.com/apache/logging-log4j2/pull/29 If should add a parameter to ConsoleAppender, I think it should be named "enableJansi" (or similar) and have default false. --- If your project is set up for it, you can reply to this e