Clean C++ client metadata in timeouts

2020-09-17 Thread Alberto Bustamante Reyes
Hi geode-dev, I have a question about the c++ client. Some months ago we merged GEODE-8231 to solve a problem we observed regarding the native client was trying to connect to stopped server. GEODE-8231 solution consists on remove the client metadata when an "IO error in handshake" exception is

Re: [Discussion] - ClassLoaderService RFC proposal

2020-09-17 Thread Jens Deppe
Thanks for this work Udo! Does this ClassLoaderService effectively replace the current ClassPathLoader mechanism then? How will one access the service; is there some static reference? Some code examples would be helpful to properly understand how one might work with this. --Jens On 9/14/20,

Re: Clean C++ client metadata in timeouts

2020-09-17 Thread Dave Barnes
Alberto, Are there cases in which one or two timeouts are followed by a successful retry? Or does one timeout *always* end with more timeouts and, ultimately, an IO error? If timeouts can sometimes be followed by successful retries, and re-trying is the current default behavior, then I agree that i

Re: Clean C++ client metadata in timeouts

2020-09-17 Thread Blake Bender
Given that attempts to retrieve metadata after the C++ cache is closed are a constant headache for Geode Native development, I am generally in favor of anything that potentially reduces the number of times/places this happens. If we've failed the handshake, it's very unlikely things will correc

Re: Clean C++ client metadata in timeouts

2020-09-17 Thread Dave Barnes
If a straight-up change solves a constant headache, as you suggest, Alberto, and as Blake concurs, that sounds like the way to go. Why introduce a new option or property if the user will always prefer one behavior over the other? (And from a docs perspective, who needs another optional property, an

Re: Clean C++ client metadata in timeouts

2020-09-17 Thread Ernie Burghardt
Let's please consider how this would controlled and look for ways other than YetAnotherProperty Thanks, EB On 9/17/20, 12:59 PM, "Dave Barnes" wrote: If a straight-up change solves a constant headache, as you suggest, Alberto, and as Blake concurs, that sounds like the way to go.

Re: [Discussion] - ClassLoaderService RFC proposal

2020-09-17 Thread Udo Kohlmeyer
Jens, yes and no. The ClassPathLoader will still be relevant for the ClassLoader mechanisms we require for the non-ClassLoader-Isolated starting of the server. But all the functionality that ClassPathLoader exposes will eventually be replaced with the ClassLoader Isolated capability. I’ll add

Re: [Discussion] - ClassLoaderService RFC proposal

2020-09-17 Thread Udo Kohlmeyer
Sorry... Also, the new implementation will not be statically available and for now the instance is passed into the locations that require it. —Udo On Sep 18, 2020, 2:22 AM +1000, Jens Deppe , wrote: Thanks for this work Udo! Does this ClassLoaderService effectively replace the current ClassPath