[GitHub] geode pull request #720: Feature/geode 3462

GitHub user dineshakhand opened a pull request: https://github.com/apache/geode/pull/720 Feature/geode 3462 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been t

RE: How to export region keys in json file

Hi, Looks like it converting key in string when I am doing put gfsh>put --region=/CUSTOMER_1 --key='("CustomerKey","customerID":1,"cycleCode":1,"customerGroup":1000,"partitionID":100)' --value=foo but Region key is CustomerKey class object. gfsh>query --query='select e.key from /CUSTOMER_1.e

[GitHub] geode pull request #718: GEODE-3434: Allow old tomcat server sessions to be ...

Github user jhuynh1 closed the pull request at: https://github.com/apache/geode/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

Github user kirklund commented on the issue: https://github.com/apache/geode/pull/613 I think this sort of change should be proposed and discussed on the dev list. This is effectively adding new User APIs and that requires more discussion. --- If your project is set up for it, you c

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134002721 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void

[GitHub] geode issue #613: GEODE-3151: Internal Region Registration in JMX as per con...

Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/613 Hi Dinesh, Sorry to be so slow in responding to your PR. Since the changes you are proposing in GEODE-3151 involve changing a public-facing API (in DistributionConfig, I think it first

[GitHub] geode issue #720: GEODE-3462: FunctionStats Exposed over JMX

Github user jaredjstewart commented on the issue: https://github.com/apache/geode/pull/720 Hi Dinesh, I just commented on your earlier PR, and the same principle applies to this one as well: Changes to public APIs should first be discussed on dev@geode.apache.org. Th

[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/720#discussion_r134003148 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java --- @@ -3091,4 +3068,22 @@ public void stopReconnect

[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/720#discussion_r134004793 --- Diff: geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/720#discussion_r134003423 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java --- @@ -3138,7 +3138,7 @@ public Pool determineDefaultPool(PoolFact

[GitHub] geode pull request #720: GEODE-3462: FunctionStats Exposed over JMX

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/720#discussion_r134003701 --- Diff: geode-core/src/main/java/org/apache/geode/management/FunctionStatsMXBean.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134005011 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134005525 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -143,11 +150,12 @@ public TcpSer

[GitHub] geode pull request #715: GEODE-3169: Decoupling of DiskStore and backups

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/715 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set if the region is recoverd from the disk.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61722/ --- (Updated Aug. 18, 2017, 4:58 p.m.) Review request for geode, Darrel Schneider,

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134007044 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134006932 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134007487 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134006399 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134007584 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

Re: [Discuss] Compatibility with Apache Xerces

Why worry is claiming to support multiple version; and trying to manage/maintain it... -Anil. On Thu, Aug 17, 2017 at 11:35 PM, Darren Foong wrote: > Hi all, > > I'm using Geode in an application that uses the Apache implementation > of Xerces. The Oracle JDK comes with its own implementation

Re: [Discuss] Compatibility with Apache Xerces

I could have sworn at one point the the cache xml parser explicitly requested the oracle parser. Since the oracle parser is always going to be there I don't see any harm in doing that. A better fix might be to just normalize the white space when parsing. I also recall xerces having a flag for

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134021523 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,107 +351,109 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134021675 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,107 +351,109 @@ protected void run() {

Geode Clubhouse meeting on the integration of Lucene text search indexes in Geode

Hello Geode Contributors: For those who may not know me, I'm in Product Marketing at Pivotal, and among other things, I work with our PM and Engineering teams on Geode. Congratulations for the Geode 1.2.0 release which went out about a month ago. The integration of Lucene indexes to enable full te

[GitHub] geode pull request #721: GEODE-3448: Implement and expose parallel snapshot ...

GitHub user nreich opened a pull request: https://github.com/apache/geode/pull/721 GEODE-3448: Implement and expose parallel snapshot import Tests showed that allowing the parallel import of snapshot files (from parallel export) scales nearly linearly, greatly increasing performance

[GitHub] geode pull request #722: GEODE-3184: Cleaned up Cargo tests

GitHub user DivineEnder opened a pull request: https://github.com/apache/geode/pull/722 GEODE-3184: Cleaned up Cargo tests Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following st

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134053063 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134053987 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134050811 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java --- @@ -40,20 +42,28 @@ public void receive

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134051130 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java --- @@ -40,20 +42,28 @@ public void receive

[GitHub] geode pull request #719: GEODE-3447 Implement client authorization for the n...

Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/719#discussion_r134025383 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthorizer.java --- @@ -0,0 +1,42 @@ +/* + * Licensed

Re: [Discuss] Compatibility with Apache Xerces

> Since the oracle parser is always going to be there I don't see any harm in doing that. That's not true if we're running on non-oracle JDKs, right? I remember a while back someone was trying to run geode on IBMs JDK and having issues - maybe even this same whitespace problem? I think it this fi

Re: [Discuss] Compatibility with Apache Xerces

I think it's fine to add Xerces as a test runtime dependency. The fix to CacheXmlParser.java looks good to me! On Thu, Aug 17, 2017 at 11:35 PM, Darren Foong wrote: > Hi all, > > I'm using Geode in an applicat

Review Request 61757: GEODE-2859: Fix ShowDeadlockDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61757/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

[GitHub] geode pull request #723: GEODE-3055: Should use a conservative fix to only c...

GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/723 GEODE-3055: Should use a conservative fix to only catch the Partition… …OfflineEx to remove the leader region bucket. Previous fix to catch all RuntimeException is too aggress

Review Request 61758: GEODE-3471: Identify NPE in MBeanProxyFactory

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61758/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: [Discuss] Compatibility with Apache Xerces

You're right. This did come up with the IBM JDK and we fixed it. Not sure why then it's coming up again. Sent from my iPhone On Aug 18, 2017, at 2:01 PM, Dan Smith wrote: >> Since the oracle parser is always going to be there I don't see any harm > in doing that. > > That's not true if we're

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134066027 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #651 was SUCCESSFUL (with 2027 tests)

--- Spring Data GemFire > Nightly-ApacheGeode > #651 was successful. --- Scheduled 2029 tests in total. https://build.spring.io/browse/SGF-NAG-651/ -- This

Build failed in Jenkins: Geode-nightly #927

See Changes: [abarve] GEODE-2886 : 1. sent IllegalStateException instead of throwing [abarve] GEODE-2886 : 1. optimized imports to the correct order and to eliminate [abarve] GEODE-2886 : 1. renamed testcase name a

[GitHub] geode pull request #723: GEODE-3055: Should use a conservative fix to only c...

Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #724: GEODE-3469: prevent zero pid from AvailablePid for ...

GitHub user kirklund opened a pull request: https://github.com/apache/geode/pull/724 GEODE-3469: prevent zero pid from AvailablePid for tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/kirklund/geode GEODE-3469-LocatorLaunc

[GitHub] geode pull request #725: GEODE-3470: Increased serial gateway sender token t...

GitHub user boglesby opened a pull request: https://github.com/apache/geode/pull/725 GEODE-3470: Increased serial gateway sender token timeout Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ens

[GitHub] geode pull request #724: GEODE-3469: prevent zero pid from AvailablePid for ...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/724#discussion_r134075750 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java --- @@ -30,37 +30,88 @@ */ public class Availabl

[GitHub] geode pull request #724: GEODE-3469: prevent zero pid from AvailablePid for ...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/724#discussion_r134075476 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -100,7 +105,53 @@ public void findAvailablePids

[GitHub] geode pull request #724: GEODE-3469: prevent zero pid from AvailablePid for ...

Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/724#discussion_r134075704 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePidTest.java --- @@ -100,7 +105,53 @@ public void findAvailablePids

[GitHub] geode pull request #724: GEODE-3469: prevent zero pid from AvailablePid for ...

Github user kirklund commented on a diff in the pull request: https://github.com/apache/geode/pull/724#discussion_r134077082 --- Diff: geode-core/src/test/java/org/apache/geode/internal/process/lang/AvailablePid.java --- @@ -30,37 +30,88 @@ */ public class AvailablePid

Re: [Discuss] Compatibility with Apache Xerces

> You're right. This did come up with the IBM JDK and we fixed it. Not sure why > then it's coming up again. Could it be this? https://issues.apache.org/jira/browse/GEODE-135 Seems like a different issue with the IBM JDK though. I've just verified that the whitespace problem is still an issue wi