I think it's fine to add Xerces as a test runtime dependency. The fix to CacheXmlParser.java <https://github.com/apache/geode/pull/668/files#diff-b7bb25562c388c80273756a30689769c> looks good to me!
On Thu, Aug 17, 2017 at 11:35 PM, Darren Foong <darrenfo...@gmail.com> wrote: > Hi all, > > I'm using Geode in an application that uses the Apache implementation > of Xerces. The Oracle JDK comes with its own implementation of Xerces. > > I encountered an issue > (https://issues.apache.org/jira/browse/GEODE-3306) whereby cache.xml > parsing fails with Apache Xerces; details are in JIRA. > > Currently there are two workarounds: > > 1. Remove the whitespace between elements in cache.xml > 2. Load the JDK Xerces when parsing cache.xml > > I've submitted a pull request > (https://github.com/apache/geode/pull/668) to make `CacheXmlParser` > compatible with both versions of Xerces. > > This change would be useful for at least two groups of people: > > 1. Developers who are using the Apache implementation of Xerces > throughout their application, and only want one implementation of > Xerces > 2. Developers who are using a non-Oracle JDK > > Does anyone have any objections to having `xercesImpl` as a test > runtime dependency? > > I'd appreciate any feedback. Thank you! > > Best regards, > - Darren Foong >
