Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/719#discussion_r134050811
--- Diff:
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufSimpleAuthenticator.java
---
@@ -40,20 +42,28 @@ public void receiveMessage(InputStream inputStream,
OutputStream outputStream,
properties.setProperty("username",
authenticationRequest.getUsername());
properties.setProperty("password",
authenticationRequest.getPassword());
+ authorizer = null; // authenticating a new user clears current
authorizer
try {
Object principal = securityManager.authenticate(properties);
- authenticated = principal != null;
+ if (principal != null) {
+ authorizer = new ProtobufSimpleAuthorizer(principal,
securityManager);
+ }
} catch (AuthenticationFailedException e) {
- authenticated = false;
+ authorizer = null;
}
-
AuthenticationAPI.SimpleAuthenticationResponse.newBuilder().setAuthenticated(authenticated)
+
AuthenticationAPI.SimpleAuthenticationResponse.newBuilder().setAuthenticated(isAuthenticated())
.build().writeDelimitedTo(outputStream);
}
@Override
public boolean isAuthenticated() {
- return authenticated;
+ return authorizer != null;
--- End diff --
I must disagree with this logic. Something is NOT `authenticated` just
because there is an authorizer populated. A authorizer should be constructed
BECAUSE something was `authenticated`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
