Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-11 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/#review180208 --- Ship it! Ship It! - Bruce Schuchardt On July 7, 2017, 3:16 p

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-11 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/#review180205 --- Ship it! Ship It! - Alexander Murmann On July 7, 2017, 10:16

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-07 Thread Brian Rowe
> On July 7, 2017, 8:58 p.m., Udo Kohlmeyer wrote: > > geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java > > Line 267 (original), 267 (patched) > > > > > > You should maybe use the `SocketCrea

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-07 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/ --- (Updated July 7, 2017, 10:16 p.m.) Review request for geode, Alexander Murmann,

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-07 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/#review179943 --- geode-core/src/main/java/org/apache/geode/internal/net/SocketCrea

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-07 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/ --- (Updated July 7, 2017, 8:54 p.m.) Review request for geode, Alexander Murmann,

Re: Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-07-07 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/#review179916 --- Ship it! I'd prefer this SSL test to be really part of the core

Review Request 60526: GEODE-3121: Verify SSL works with new protobuf protocol

2017-06-28 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan,