----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/#review179916 -----------------------------------------------------------
Ship it! I'd prefer this SSL test to be really part of the core.. to test that ANY serialization framework can work over SSL. But for not it is good enough - Udo Kohlmeyer On June 28, 2017, 11:22 p.m., Brian Rowe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60526/ > ----------------------------------------------------------- > > (Updated June 28, 2017, 11:22 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-3121 > https://issues.apache.org/jira/browse/GEODE-3121 > > > Repository: geode > > > Description > ------- > > Adding a new test to run the protobuf integration test over a SSL connection. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java > 844b48413 > > geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java > 77b984f7e > > geode-protobuf/src/test/resources/org/apache/geode/protocol/default.keystore > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60526/diff/1/ > > > Testing > ------- > > This change is just adding a test. > > > Thanks, > > Brian Rowe > >
