----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60526/#review179943 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java Line 267 (original), 267 (patched) <https://reviews.apache.org/r/60526/#comment254882> You should maybe use the `SocketCreatorFactory`. We don't want to expose this class outside of the package. - Udo Kohlmeyer On July 7, 2017, 8:54 p.m., Brian Rowe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60526/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 8:54 p.m.) > > > Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen > O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer. > > > Bugs: GEODE-3121 > https://issues.apache.org/jira/browse/GEODE-3121 > > > Repository: geode > > > Description > ------- > > Adding a new test to run the protobuf integration test over a SSL connection. > > > Diffs > ----- > > geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java > 844b48413 > > geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java > 31a873658 > > geode-protobuf/src/test/resources/org/apache/geode/protocol/default.keystore > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60526/diff/2/ > > > Testing > ------- > > This change is just adding a test. > > > Thanks, > > Brian Rowe > >
