Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Dan Smith
> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote: > > geode-old-versions/build.gradle, line 63 > > > > > > Clarifying question: Should this be associated with 'test' sources or > > is 'main' so the tests may use it? >

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Bruce Schuchardt
> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote: > > geode-old-versions/build.gradle, line 63 > > > > > > Clarifying question: Should this be associated with 'test' sources or > > is 'main' so the tests may use it? >

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-07 Thread Dan Smith
> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote: > > geode-old-versions/build.gradle, line 63 > > > > > > Clarifying question: Should this be associated with 'test' sources or > > is 'main' so the tests may use it? I

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Mark Bretl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56348/#review164448 --- geode-old-versions/build.gradle (line 43)

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56348/#review164446 --- Ship it! Ship It! - Anthony Baker On Feb. 7, 2017, 12:53 a.m

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56348/ --- (Updated Feb. 7, 2017, 12:53 a.m.) Review request for geode, Bruce Schuchardt a

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56348/#review164434 --- Ship it! I downloaded the change set to a Win 7 machine and ran

Re: Review Request 56348: GEODE-2434: Generate old version classpaths in doLast

2017-02-06 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56348/#review164426 --- geode-old-versions/build.gradle (line 21)