----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56348/#review164434 -----------------------------------------------------------
Ship it! I downloaded the change set to a Win 7 machine and ran backward-compat unit tests both from gradle and from IntelliJ and it worked fine - Bruce Schuchardt On Feb. 6, 2017, 11:04 p.m., Dan Smith wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56348/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 11:04 p.m.) > > > Review request for geode, Bruce Schuchardt and Mark Bretl. > > > Repository: geode > > > Description > ------- > > The geode-old-versions/build.gradle was generating the classpath > properties file during the build configuration phase, rather than the > execution phase. > > Also converting the file to an actual properties file so that it will > handle special characters properly. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java > 7bda9481275d3801e347ae6dfd66520e3f123a3a > geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9 > > Diff: https://reviews.apache.org/r/56348/diff/ > > > Testing > ------- > > > Thanks, > > Dan Smith > >
