> On Feb. 7, 2017, 1:45 a.m., Mark Bretl wrote:
> > geode-old-versions/build.gradle, line 63
> > <https://reviews.apache.org/r/56348/diff/2/?file=1625843#file1625843line63>
> >
> > Clarifying question: Should this be associated with 'test' sources or
> > is 'main' so the tests may use it?
>
> Dan Smith wrote:
> I was thinking that at some point in the future we might want to get this
> file from the classpath, rather than what the code is doing now where it's
> poking around on the filesystem.
>
> Things in main will be added to the classpath of another project when you
> declare a dependency on this project, eg testComplile
> project('geode-old-versions'). Things in test generally aren't, unless you
> jump through some hoops.
>
> Bruce Schuchardt wrote:
> If this would allow the VersionManager code to find the file on its
> classpath I'd really like to make that change. Jenkins seems to be causing
> problems with the current "poking around" method of trying to find the file.
Yeah, we ought to be able to load this file just with something like this:
Properties props = new Properties();
try (InputStream in =
VersionManager.class.getResource("/geodeOldVersionClasspaths.txt").openStream())
{
props.load(in);
}
I'm not sure why the release build failed though, it seems like the code that's
on that branch should work.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56348/#review164448
-----------------------------------------------------------
On Feb. 7, 2017, 12:53 a.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56348/
> -----------------------------------------------------------
>
> (Updated Feb. 7, 2017, 12:53 a.m.)
>
>
> Review request for geode, Bruce Schuchardt and Mark Bretl.
>
>
> Repository: geode
>
>
> Description
> -------
>
> The geode-old-versions/build.gradle was generating the classpath
> properties file during the build configuration phase, rather than the
> execution phase.
>
> Also converting the file to an actual properties file so that it will
> handle special characters properly.
>
>
> Diffs
> -----
>
>
> geode-core/src/test/java/org/apache/geode/test/dunit/standalone/VersionManager.java
> 7bda9481275d3801e347ae6dfd66520e3f123a3a
> geode-old-versions/build.gradle a09b2d71c4ae9ab393b2d6e9cd44d94155e760f9
>
> Diff: https://reviews.apache.org/r/56348/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
