Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Owen Nichols
There appears to be consensus that this is a critical fix. PR #3949 has passed all PR checks and has been brought into release/1.10.0 as the critical fix for GEODE-3870

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Bruce Schuchardt
Ah, I see - I need to create a PR and tell it both of the branches.  The link from "git push" is for merging to develop. I'll give it another try. On 8/19/19 1:53 PM, Owen Nichols wrote: PR 3947 appears to be against develop. Looking for a PR against release/1.10.0... On Aug 19, 2019, at 1:

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Owen Nichols
PR 3947 appears to be against develop. Looking for a PR against release/1.10.0... > On Aug 19, 2019, at 1:50 PM, Bruce Schuchardt wrote: > > Unfortunately the code I'm working with went through some refactoring after > the 1.10.0 branch was cut. A PR based on release/1.10.0 membership change

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Bruce Schuchardt
Unfortunately the code I'm working with went through some refactoring after the 1.10.0 branch was cut.  A PR based on release/1.10.0 membership changes can't go through a PR pipeline because it won't compile once the changes are merged to develop. https://github.com/apache/geode/pull/3947/chec

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Owen Nichols
Hi Bruce, unfortunately 8e9b04470264983d0aa1c7900f6e9be2374549d9 does not cherry-pick cleanly into release/1.10.0. Can you please open a PR against release/1.10.0? -Owen > On Aug 19, 2019, at 9:16 AM, Kirk Lund wrote: > > +1 > > On Mon, Aug 19, 2019 at 8:29 AM Alexander Murmann > wrote: >

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Kirk Lund
+1 On Mon, Aug 19, 2019 at 8:29 AM Alexander Murmann wrote: > +1 > > it's a regression in 1.10 and a serious problem. > > On Mon, Aug 19, 2019 at 7:38 AM Bruce Schuchardt > wrote: > > > It sounds like Udo is okay with this now. Any other concerns? > > > > On 8/17/19 2:07 AM, Owen Nichols wrote

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Alexander Murmann
+1 it's a regression in 1.10 and a serious problem. On Mon, Aug 19, 2019 at 7:38 AM Bruce Schuchardt wrote: > It sounds like Udo is okay with this now. Any other concerns? > > On 8/17/19 2:07 AM, Owen Nichols wrote: > > On Aug 15, 2019, at 2:09 PM, Bruce Schuchardt > wrote: > > > > This is a f

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-19 Thread Bruce Schuchardt
It sounds like Udo is okay with this now.  Any other concerns? On 8/17/19 2:07 AM, Owen Nichols wrote: On Aug 15, 2019, at 2:09 PM, Bruce Schuchardt wrote: This is a fix for a problem where a member that has lost quorum does not detect it and does not shut down. The fix is small and has been

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-17 Thread Owen Nichols
Hi Bruce, thank you for bringing your concern. Geode's release process dictates a time-based schedule to cut release branches. The release/1.10.0 branch was already cut 2

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-15 Thread Bruce Schuchardt
In this case it was another change that is in 1.10 that decreased the amount of time we try to connect to unreachable alert listeners that caused this problem to resurface.  This decrease allowed availability checks to proceed faster than they used to. This allowed an availability check to pass

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-15 Thread Udo Kohlmeyer
Looking at the Geode ticket number, it seems this problem has resurfaced, as it seems to have been addressed in 1.7.0 already. My concern is, do what know WHAT caused it to resurface? Or was this issue always dormant and only recently resurfaced? Without understand why we are seeing "fixed" is

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-15 Thread Bruce Schuchardt
Testing in the past week hit this problem 9 times and it was identified as a new issue. On 8/15/19 2:23 PM, Jacob Barrett wrote: Because someone will ask, can we be proactive in these request with identifying if the issue being fixed is introduced in Geode 1.10 or is a preexisting condition.

Re: I propose including the fix for GEODE-3780 in 1.10

2019-08-15 Thread Jacob Barrett
Because someone will ask, can we be proactive in these request with identifying if the issue being fixed is introduced in Geode 1.10 or is a preexisting condition. -jake > On Aug 15, 2019, at 2:09 PM, Bruce Schuchardt wrote: > > This is a fix for a problem where a member that has lost quorum