Re: [Proposal] Adding Micrometer to Apache Geode

I have submitted a new PR https://github.com/apache/geode/pull/3180 , superseding the original one. I invite your review. Cheers, Dale — Dale Emery dem...@pivotal.io > On Feb 4, 2019, at 9:10 AM, Kirk Lund wrote: > > +1 to add Micrometer in the desc

Re: [Proposal] Adding Micrometer to Apache Geode

+1 to add Micrometer in the described way and I'll add my approval to the PR as well On Fri, Feb 1, 2019 at 4:16 PM Dale Emery wrote: > Hello all, > > I've created a PR to add Micrometer to Geode: > https://github.com/apache/geode/pull/3153 > > I invite your review. > > The Micrometer system inc

Re: [Proposal] Adding Micrometer to Apache Geode

Hello all, I've created a PR to add Micrometer to Geode: https://github.com/apache/geode/pull/3153 I invite your review. The Micrometer system includes a rich suite of Meter types for instrumenting code, and several styles of meter registries for maintaining the meters. It also includes (as se

Re: [Proposal] Adding Micrometer to Apache Geode

So... imo, what is a dimension and what is a metric. well to me a metric is a value that we want to measure on across all the different permutations of that metric. The metric has to be generic in the sense that it exposes no detail about the value it is measuring. Metrics are like dry oats.

Re: [Proposal] Adding Micrometer to Apache Geode

+1 Micrometer looks awesome. I'd love to see more details on how this will work. How will you hook micrometer in? Will all of the stats that are currently exposed in VSD be exposed in micrometer, or just some subset? How does a user configure which monitoring system(s) micrometer is sending data t

Re: [Proposal] Adding Micrometer to Apache Geode

Hi Udo and all, > On Jan 15, 2019, at 10:06 AM, Udo Kohlmeyer wrote: > > It would be good to see the new Micrometer stats have a logical grouping, > that makes it easier for users to search for metrics. Do you know of any useful guidelines or conventions for creating a hierarchy of metrics, a

Re: [Proposal] Adding Micrometer to Apache Geode

The plan is to use tagged metrics, so for example, you could slice metrics on puts by region, or server, or both. On Tue, Jan 15, 2019 at 10:06 AM Udo Kohlmeyer wrote: > I agree with Jacob here. Great to see such great strides forward > > +1 deprecating old Stats APIs > > It would be good to see

Re: [Proposal] Adding Micrometer to Apache Geode

Yes, we will be working towards tagged dimensions and JMX parity as well. > On Jan 15, 2019, at 10:06 AM, Udo Kohlmeyer wrote: > > I agree with Jacob here. Great to see such great strides forward > > +1 deprecating old Stats APIs > > It would be good to see the new Micrometer stats have a lo

Re: [Proposal] Adding Micrometer to Apache Geode

Yes, deprecating stats and VSD would be the direction we are heading… > On Jan 15, 2019, at 9:43 AM, Jacob Barrett wrote: > > I am good with this proposal as long as it includes the deprecation of all > the current stats APIs and VSD such that Micrometer is the only go forward > stats definit

Re: [Proposal] Adding Micrometer to Apache Geode

I agree with Jacob here. Great to see such great strides forward +1 deprecating old Stats APIs It would be good to see the new Micrometer stats have a logical grouping, that makes it easier for users to search for metrics. Does this mean that Geode will now support fully tagged/dimension met

Re: [Proposal] Adding Micrometer to Apache Geode

I am good with this proposal as long as it includes the deprecation of all the current stats APIs and VSD such that Micrometer is the only go forward stats definition and collection API in 2.0. > On Jan 15, 2019, at 9:37 AM, Mark Hanson wrote: > > Hello All, > > I would like to propose that w