Seems like the consensus is to make this change. I'll follow up with infra.
-Dan
On Wed, Oct 30, 2019 at 11:06 AM Jason Huynh wrote:
> +1, thanks Dan!
>
> On Wed, Oct 30, 2019 at 10:07 AM Aaron Lindsey
> wrote:
>
> > +1
> >
> > - Aaron
> >
> >
> > On Wed, Oct 30, 2019 at 8:02 AM Ju@N wrote:
>
+1, thanks Dan!
On Wed, Oct 30, 2019 at 10:07 AM Aaron Lindsey wrote:
> +1
>
> - Aaron
>
>
> On Wed, Oct 30, 2019 at 8:02 AM Ju@N wrote:
>
> > Perfect Naba, thanks for answering this.
> > My vote is +1 then.
> >
> > On Wed, Oct 30, 2019 at 2:37 PM Nabarun Nag wrote:
> >
> > > The check box Dan
+1
- Aaron
On Wed, Oct 30, 2019 at 8:02 AM Ju@N wrote:
> Perfect Naba, thanks for answering this.
> My vote is +1 then.
>
> On Wed, Oct 30, 2019 at 2:37 PM Nabarun Nag wrote:
>
> > The check box Dan is mentioning will just not invalidate any approved
> > review if the code is changed.
> > If
Perfect Naba, thanks for answering this.
My vote is +1 then.
On Wed, Oct 30, 2019 at 2:37 PM Nabarun Nag wrote:
> The check box Dan is mentioning will just not invalidate any approved
> review if the code is changed.
> If a change is requested, the button will remain disabled.
>
> Regards
> Naba
The check box Dan is mentioning will just not invalidate any approved
review if the code is changed.
If a change is requested, the button will remain disabled.
Regards
Naba
On Wed, Oct 30, 2019 at 6:27 AM Joris Melchior wrote:
> +1
>
> On Wed, Oct 30, 2019 at 5:27 AM Ju@N wrote:
>
> > Questio
+1
On Wed, Oct 30, 2019 at 5:27 AM Ju@N wrote:
> Question: this only applies for *approvals*, not for *refusals*, right?; I
> mean, the *merge pull request* button will remain blocked if there were
> some changes requested by reviewers and the author of the PR adds new
> commits (either addressi
Question: this only applies for *approvals*, not for *refusals*, right?; I
mean, the *merge pull request* button will remain blocked if there were
some changes requested by reviewers and the author of the PR adds new
commits (either addressing those requested changes or not)?.
If the answer to the
+1
On Tue, Oct 29, 2019 at 6:21 PM Darrel Schneider
wrote:
> +1
>
> On Tue, Oct 29, 2019 at 6:08 PM Owen Nichols wrote:
>
> > +1 …this has already bitten me a few times
> >
> > > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote:
> > >
> > > Hi all,
> > >
> > > It seems we've configured our branch
+1
On Tue, Oct 29, 2019 at 6:08 PM Owen Nichols wrote:
> +1 …this has already bitten me a few times
>
> > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote:
> >
> > Hi all,
> >
> > It seems we've configured our branch protection rules such that pushing a
> > change to a PR that has been approved inv
+1
On Tue, Oct 29, 2019, 6:08 PM Owen Nichols wrote:
> +1 …this has already bitten me a few times
>
> > On Oct 29, 2019, at 6:01 PM, Dan Smith wrote:
> >
> > Hi all,
> >
> > It seems we've configured our branch protection rules such that pushing a
> > change to a PR that has been approved inval
+1 …this has already bitten me a few times
> On Oct 29, 2019, at 6:01 PM, Dan Smith wrote:
>
> Hi all,
>
> It seems we've configured our branch protection rules such that pushing a
> change to a PR that has been approved invalidates the previous approval.
>
> I think we should turn this off -
11 matches
Mail list logo
