The reason I prefer the rules not apply in draft is quite simple, people
sometimes use the PR pipeline to test stuff. Its easy enough to just put in
GEODE- but sometimes it just “Test” because there is no GEODE associated.
Either way I don’t care enough to debate. I will abide by what the devs
I agree with Jake and do appreciate everyone using the "DRAFT" feature, one
downfall of that is this is not visible unless on Github; i.e. if you see
an email for a PR you won't know its in "DRAFT" mode until you go look at
it...
a related part of this, to me, seems to be that the PR checklist is
> On Mar 2, 2020, at 10:10 AM, Mark Hanson wrote:
>
> If I may add one caveat. If a pull request is in a ready to review state …
> . If it is prefaced with Do Not Review: then apply>.
-1
Use the “Draft” state of the PR and use good titles from the beginning. Using
“DO NO REVIEW” in the tit
I thought PR titles are generated from the git comment.
So, I'm expecting it to have the following format: "GEODE-XXX: "
Glancing at the current PR list, I do see that there is at least 1 PR
that does not follow that guideline.
We also don't want to be overly pr
,' etc?
>>
>> On Mon, Mar 2, 2020 at 8:47 AM Owen Nichols wrote:
>>
>>> +1
>>>
>>> It’s easy to fix too!
>>>
>>> On Mon, Mar 2, 2020 at 8:34 AM Jacob Barrett
>> wrote:
>>>
>>>> Please
a JIRA
> ticket #,' etc?
>
> On Mon, Mar 2, 2020 at 8:47 AM Owen Nichols wrote:
>
> > +1
> >
> > It’s easy to fix too!
> >
> > On Mon, Mar 2, 2020 at 8:34 AM Jacob Barrett
> wrote:
> >
> > > Please use meaningful PR titles. When brow
t 8:34 AM Jacob Barrett wrote:
>
> > Please use meaningful PR titles. When browsing the PRs or reading the
> > notifications, one shouldn’t have to decode your cryptic title. Consider
> > the title as the first line of you commit message.
> >
> > -Jake
> >
> >
>
+1
It’s easy to fix too!
On Mon, Mar 2, 2020 at 8:34 AM Jacob Barrett wrote:
> Please use meaningful PR titles. When browsing the PRs or reading the
> notifications, one shouldn’t have to decode your cryptic title. Consider
> the title as the first line of you commit message.
>
> -Jake
>
>
Please use meaningful PR titles. When browsing the PRs or reading the
notifications, one shouldn’t have to decode your cryptic title. Consider the
title as the first line of you commit message.
-Jake
