I thought PR titles are generated from the git comment.
So, I'm expecting it to have the following format: "GEODE-XXX: ........"
Glancing at the current PR list, I do see that there is at least 1 PR
that does not follow that guideline.
We also don't want to be overly prescriptive, so maybe if we find a PR
that does not meet that condition, we comment on that PR, asking for a
change or title and description to make it easier to understand what
that PR is for.
As for another check on the checklist... Well, I don't always see that
the current set are correctly filled in.. So, it just becomes another
check that some contributors will not check.
@Mark, I struggle to understand why one would submit a PR if it is not
to be reviewed or included in the project. Sounds like unnecessary noise
to me and should be discouraged
--Udo
On 3/2/20 10:10 AM, Mark Hanson wrote:
If I may add one caveat. If a pull request is in a ready to review state … <Rules
apply>. If it is prefaced with Do Not Review: then <Rules do not apply>.
Thanks,
Mark
On Mar 2, 2020, at 9:30 AM, Alexander Murmann <amurm...@apache.org> wrote:
Don't we have a published checklist or guideline or something for this
already? Including stuff like 'always prefix the PR title with a JIRA
ticket #,' etc?
Yes, we do. However, it only request the addition of the JIRA ticket #. It
does not call out having a descriptive title.
I like the idea of adding a point to the checklist to call this out.
On Mon, Mar 2, 2020 at 9:02 AM Blake Bender <bben...@pivotal.io> wrote:
Don't we have a published checklist or guideline or something for this
already? Including stuff like 'always prefix the PR title with a JIRA
ticket #,' etc?
On Mon, Mar 2, 2020 at 8:47 AM Owen Nichols <onich...@pivotal.io> wrote:
+1
It’s easy to fix too!
On Mon, Mar 2, 2020 at 8:34 AM Jacob Barrett <jbarr...@pivotal.io>
wrote:
Please use meaningful PR titles. When browsing the PRs or reading the
notifications, one shouldn’t have to decode your cryptic title.
Consider
the title as the first line of you commit message.
-Jake
