I agree with Jake and do appreciate everyone using the "DRAFT" feature, one
downfall of that is this is not visible unless on Github; i.e. if you see
an email for a PR you won't know its in "DRAFT" mode until you go look at
it...

a related part of this, to me, seems to be that the PR checklist is a bit
out of date... much of it is now automatically enforced (awesome), but
arguably the most important part of the checklist "[*] Have you written or
updated unit tests to verify your changes?" is buried at the bottom and is
an important signal being lost in the noise...

On Mon, Mar 2, 2020 at 10:12 AM Jacob Barrett <jbarr...@pivotal.io> wrote:

>
>
> > On Mar 2, 2020, at 10:10 AM, Mark Hanson <mhan...@pivotal.io> wrote:
> >
> > If I may add one caveat. If a pull request is in a ready to review state
> … <Rules apply>. If it is prefaced with Do Not Review: then <Rules do not
> apply>.
>  -1
> Use the “Draft” state of the PR and use good titles from the beginning.
> Using “DO NO REVIEW” in the title is super annoying now that GitHub has a
> feature for draft PRs.
>
>

Reply via email to