[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-24 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r135089666 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,23 @

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-24 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r135087207 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java --- @@ -297,6 +297,8 @@ public Object call() throws IOE

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/716 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-22 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134514607 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,23 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-21 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134270934 --- Diff: geode-core/src/test/java/org/apache/geode/test/dunit/standalone/DUnitLauncher.java --- @@ -297,6 +297,8 @@ public Object call() throws IOExce

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-21 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134358612 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,23 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-21 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134022599 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-21 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134026218 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/TcpServerFactory.java --- @@ -0,0 +1,39 @@ +package org.apache.geod

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-21 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134024644 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/TcpServerFactory.java --- @@ -0,0 +1,39 @@ +package org.apache.geod

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-21 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134023037 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnectionFactory.java --- @@ -49,20 +48,13 @@ private synchroniz

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134066027 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134053987 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134053063 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134021675 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,107 +351,109 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread galen-pivotal
Github user galen-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134021523 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,107 +351,109 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134007487 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134006399 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134006932 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134007584 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/InvalidExecutionContextException.java --- @@ -0,0 +1,33 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134007044 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134005525 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -143,11 +150,12 @@ public TcpSer

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134005011 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-18 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r134002721 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133847775 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133847176 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java --- @@ -32,75

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133844781 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133782267 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133783516 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133783618 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133780406 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,19 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133778667 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void t

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133781367 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java --- @@ -32,75 +

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133778013 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133778501 --- Diff: geode-core/src/test/java/org/apache/geode/cache/client/internal/AutoConnectionSourceImplJUnitTest.java --- @@ -392,7 +388,7 @@ public void t

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133779835 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,19 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133777949 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133774197 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775965 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775201 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775860 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/*

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-17 Thread kohlmu-pivotal
Github user kohlmu-pivotal commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133775690 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java --- @@ -76,7 +76,9 @@ */ public interface InternalCach

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133599245 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133598920 --- Diff: geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandler.java --- @@ -50,51 +37,19 @@

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133596280 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -334,42 +342,46 @@ protected void run() {

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133597359 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientProtoclMessageHandlerLoader.java --- @@ -0,0 +1,64 @@ +/* + *

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133598026 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133595959 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/tcpserver/TcpServer.java --- @@ -120,6 +126,7 @@ private InetAddress bind_a

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133599146 --- Diff: geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetAvailableServersOperationHandlerJUnitTest.java --- @@ -32,75 +30,48

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133596604 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/InternalCache.java --- @@ -76,7 +76,9 @@ */ public interface InternalCache ext

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread WireBaron
Github user WireBaron commented on a diff in the pull request: https://github.com/apache/geode/pull/716#discussion_r133597935 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ExecutionContext.java --- @@ -0,0 +1,54 @@ +/* + * Licensed to the

[GitHub] geode pull request #716: GEODE-3406: Locator accepts Protobuf requests

2017-08-16 Thread pivotal-amurmann
GitHub user pivotal-amurmann opened a pull request: https://github.com/apache/geode/pull/716 GEODE-3406: Locator accepts Protobuf requests Also addresses GEODE-3400, GEODE-3399 This allows the locator to respond to Protobuf requests. Currently it will only be able to respond