[GitHub] geode pull request #723: GEODE-3055: Should use a conservative fix to only c...

2017-08-18 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/723 GEODE-3055: Should use a conservative fix to only catch the Partition… …OfflineEx to remove the leader region bucket. Previous fix to catch all RuntimeException is too

[GitHub] geode pull request #706: GEODE-3304: when colocated child bucket is destroye...

2017-08-09 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/706 GEODE-3304: when colocated child bucket is destroyed, it should not i… @upthewaterspout @boglesby …mpact its parent bucket's creation. Thank you for submitt

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-08-02 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/570#discussion_r130938862 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java --- @@ -494,6 +494,18 @@ CreateBucketResult

[GitHub] geode issue #570: GEODE-3055: waitUntilFlush should use data region's bucket...

2017-08-01 Thread gesterzhou
Github user gesterzhou commented on the issue: https://github.com/apache/geode/pull/570 The forceRemovePrimary was useless and it can be removed because it always use "false". But when I added the logic to remove the leader region bucket (when the shadow bucket

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-08-01 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/570#discussion_r130729615 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionDataStore.java --- @@ -1472,6 +1472,19 @@ public boolean removeBucket

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

2017-08-01 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/674#discussion_r130727639 --- Diff: geode-cq/src/test/java/org/apache/geode/internal/cache/PutAllCSDUnitTest.java --- @@ -500,6 +502,81 @@ public void run2() throws CacheException

[GitHub] geode pull request #674: GEODE-3380: There're 2 problems here

2017-07-31 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/674 GEODE-3380: There're 2 problems here @dschneider-pivotal @upthewaterspout @boglesby There're 2 problems: 1) when removeAll is retried, it will get EntryNotFound exception.

[GitHub] geode pull request #654: GEODE-3291: add soundex analyzer into lucene query

2017-07-24 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/654 GEODE-3291: add soundex analyzer into lucene query Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure

[GitHub] geode pull request #570: GEODE-3055: waitUntilFlush should use data region's...

2017-06-08 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/570 GEODE-3055: waitUntilFlush should use data region's bucketid list. So… @upthewaterspout @boglesby …me of the buckets maybe not initialized, then wait for tempQueue to be

[GitHub] geode pull request #487: geode-2848: when found all the partitioned region i...

2017-05-02 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/487 geode-2848: when found all the partitioned region is destroyed, add b… @upthewaterspout @boglesby Need to check if shadow PR is destroyed and add back the events that are not put into

[GitHub] geode pull request #451: GEODE-2768: Lucene Queries executed before index is...

2017-04-12 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/451#discussion_r111261018 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/distributed/LuceneQueryFunction.java --- @@ -132,6 +133,25 @@ private

[GitHub] geode issue #444: Feature/gem 1353

2017-04-08 Thread gesterzhou
Github user gesterzhou commented on the issue: https://github.com/apache/geode/pull/444 This is the first draft of pull request for review. It's opt to change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] geode pull request #444: Feature/gem 1353

2017-04-08 Thread gesterzhou
GitHub user gesterzhou opened a pull request: https://github.com/apache/geode/pull/444 Feature/gem 1353 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/geode feature/GEM-1353 Alternatively you can review and apply these

[GitHub] geode pull request #427: GEODE-2674: Changing the lucene listener to get fro...

2017-03-16 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/427#discussion_r106503358 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/LuceneEventSubstitutionFilter.java --- @@ -0,0 +1,37

[GitHub] geode pull request #421: GEODE-2595: Change LuceneService.createIndex to use...

2017-03-10 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/geode/pull/421#discussion_r105441883 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneService.java --- @@ -37,15 +36,17 @@ * * * Lucene indexes can

[GitHub] incubator-geode issue #293: GEODE-1653: Executing a fire-and-forget function...

2016-11-30 Thread gesterzhou
Github user gesterzhou commented on the issue: https://github.com/apache/incubator-geode/pull/293 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-30 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296684 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -92,22 +90,23

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-30 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296464 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -117,22 +116,19

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-30 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90296214 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -92,22 +90,23

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-30 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90295325 --- Diff: geode-core/src/main/java/org/apache/geode/cache/client/internal/ExplicitConnectionSourceImpl.java --- @@ -257,7 +257,7 @@ public

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-29 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90173276 --- Diff: geode-core/src/main/java/org/apache/geode/cache/client/internal/ExecuteFunctionNoAckOp.java --- @@ -236,4 +236,16 @@ protected Message

[GitHub] incubator-geode pull request #293: GEODE-1653: Executing a fire-and-forget f...

2016-11-29 Thread gesterzhou
Github user gesterzhou commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/293#discussion_r90173264 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java --- @@ -0,0 +1,164