Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90296464
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -117,22 +116,19 @@ public void testFireAndForgetFunctionOnAllServers() {
// Step 7. Execute the same function to put DistributedMemberID into
above created replicated
// region.
- function = new TestFunction(false,
TestFunction.TEST_FUNCTION_FIREANDFORGET_ONALL_SERVERS);
- FunctionService.registerFunction(function);
-
dataSet = FunctionService.onServers(pool1);
dataSet.withArgs(regionName).execute(function);
+ await().atMost(60, SECONDS)
+ .until(() -> Assert.assertEquals(2,
pool.getCurrentServers().size()));
+
// Using Awatility, if the condition is not met during the timeout, a
// ConditionTimeoutException will be thrown. This makes analyzing
the failure much simpler
- await().atMost(60, SECONDS).until(() -> {
- return (region1.keySetOnServer().size() == 2);
- });
-
// Step 8. Assert for the region keyset size with 2, since above
function was executed on 2
// servers.
-
- Assert.assertEquals(2, region1.keySetOnServer().size());
+ await().atMost(60, SECONDS).until(() -> {
+ Assert.assertEquals(2, region1.keySetOnServer().size());
--- End diff --
These 2 lines are not necessary, they should be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
