Github user gesterzhou commented on a diff in the pull request:
https://github.com/apache/incubator-geode/pull/293#discussion_r90296214
--- Diff:
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
---
@@ -92,22 +90,23 @@ public void testFireAndForgetFunctionOnAllServers() {
// Step 4. Execute the function to put DistributedMemberID into
above created replicated
// region.
- Function function =
- new TestFunction(false,
TestFunction.TEST_FUNCTION_FIREANDFORGET_ONALL_SERVERS);
+ Function function = new FireAndForgetFunctionOnAllServers();
FunctionService.registerFunction(function);
+ PoolImpl pool = (PoolImpl) pool1;
+
+ await().atMost(60, SECONDS)
+ .until(() -> Assert.assertEquals(1,
pool.getCurrentServers().size()));
--- End diff --
The 2 lines should be moved to line 120. Otherwise, I wonder why the test
will pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
