[
https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959481#comment-15959481
]
Kevin Duling commented on GEODE-2662:
-
In {{DataCommandFunction.java}} at line 78
Do you have your settings set in your .git/config ?
[reviewboard]
url = https://reviews.apache.org/
On Wed, Mar 29, 2017 at 4:06 PM, Jared Stewart wrote:
> I’m trying to post a review request on Review Board (previously I have
> just used GitHub PRs), but this command hangs:
>
> rbt post --r
[
https://issues.apache.org/jira/browse/GEODE-2662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945630#comment-15945630
]
Kevin Duling commented on GEODE-2662:
-
The data returning to gfsh appears to be
[
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944033#comment-15944033
]
Kevin Duling edited comment on GEODE-1994 at 3/27/17 8:5
[
https://issues.apache.org/jira/browse/GEODE-1994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944033#comment-15944033
]
Kevin Duling commented on GEODE-1994:
-
In GEODE-2704, the custom StringUtil
[
https://issues.apache.org/jira/browse/GEODE-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15943739#comment-15943739
]
Kevin Duling commented on GEODE-2613:
-
Confirmed {{DATA:WRITE}} is in place for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57820/#review169900
---
Ship it!
Ship It!
- Kevin Duling
On March 23, 2017, 7:53
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57611/#review169791
---
Ship it!
Ship It!
- Kevin Duling
On March 14, 2017, 10:30
[
https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2704:
Fix Version/s: 1.2.0
> Remove Pulse's custom StringUtils in favor of Apache Commons Str
[
https://issues.apache.org/jira/browse/GEODE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2671.
-
Resolution: Fixed
Fix Version/s: 1.2.0
> When a locator is started with a custom
[
https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2704.
-
Resolution: Fixed
> Remove Pulse's custom StringUtils in favor of Apache Commons Str
On March 21, 2017, 3:05 p.m., Patrick Rhomberg wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
: https://reviews.apache.org/r/57796/diff/3/
Changes: https://reviews.apache.org/r/57796/diff/2-3/
Testing
---
precheckin restarted
Thanks,
Kevin Duling
Is this system proeprty set manually or by the locator/server when
> > starting up the pulse service?
>
> Kevin Duling wrote:
> It is set manually by the test. Prior to my change, Pulse only read from
> `pulse.properties` off of the classpath to set the `pulse.port` value
[
https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reassigned GEODE-2704:
---
Assignee: Kevin Duling
> Remove Pulse's custom StringUtils in favor of Apache
.java
d7f119b711c3b6168d826d195c582f655f10af68
geode-pulse/src/main/java/org/apache/geode/tools/pulse/internal/util/StringUtils.java
df7c5a5e5dde97fd726b46f7007121e0538bd01a
Diff: https://reviews.apache.org/r/57823/diff/1/
Testing
---
precheckin running
Thanks,
Kevin Duling
g at all.
> > Let's not introduce this test compile dependency.
>
> Kevin Duling wrote:
> I am also introducing this in GEODE-2671 in order to get ahold of the
> `jmx-manager-port` constant.
Wait...that should be compile, not testCompile.
- Kevin
-
ed e-mail. To reply, visit:
> https://reviews.apache.org/r/57822/
> ---
>
> (Updated March 21, 2017, 3:05 p.m.)
>
>
> Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe,
> Kirk Lund, and Swapnil Bawaskar.
://reviews.apache.org/r/57796/diff/2/
Testing (updated)
---
precheckin restarted
Thanks,
Kevin Duling
: https://reviews.apache.org/r/57796/diff/2/
Changes: https://reviews.apache.org/r/57796/diff/1-2/
Testing
---
precheckin successful
Thanks,
Kevin Duling
; I would hope we shouldn't need to manully set this in the test.
>
> Kevin Duling wrote:
> I was hoping not, also, but couldn't find another way to handle this.
> None of the parameters we are interested in are set in the system properties.
> For example `jmx-man
[
https://issues.apache.org/jira/browse/GEODE-2704?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2704:
Description: Moving away from these custom classes to use more standardized
ones.
> Remove Puls
Kevin Duling created GEODE-2704:
---
Summary: Remove Pulse's custom StringUtils in favor of Apache
Commons StringUtils
Key: GEODE-2704
URL: https://issues.apache.org/jira/browse/GEODE-2704
Project:
; I would hope we shouldn't need to manully set this in the test.
>
> Kevin Duling wrote:
> I was hoping not, also, but couldn't find another way to handle this.
> None of the parameters we are interested in are set in the system properties.
> For example `jmx-man
--
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57796/#review169587
---
On March 21, 2017, 9:35 a.m., Kevin Duling wrote:
>
> ---
/src/main/resources/pulse.properties
878bc680bbcc4369eb2d3859c6377b8942bc89d7
Diff: https://reviews.apache.org/r/57796/diff/1/
Testing (updated)
---
precheckin successful
Thanks,
Kevin Duling
878bc680bbcc4369eb2d3859c6377b8942bc89d7
Diff: https://reviews.apache.org/r/57796/diff/1/
Testing
---
precheckin running
Thanks,
Kevin Duling
[
https://issues.apache.org/jira/browse/GEODE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2671:
Summary: When a locator is started with a custom jmx-manager-port, the
embedded pulse server still
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57729/#review169505
---
Ship it!
Ship It!
- Kevin Duling
On March 17, 2017, 11:48
[
https://issues.apache.org/jira/browse/GEODE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reassigned GEODE-2671:
---
Assignee: Kevin Duling
> when a locator is started with a jmx-manager-port that is not 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57573/#review169085
---
Ship it!
Ship It!
- Kevin Duling
On March 15, 2017, 1:02
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57658/#review169041
---
Ship it!
Ship It!
- Kevin Duling
On March 15, 2017, 11:43
#comment241196>
"using an http connection. Otherwise, logs will be written
geode-core/src/test/resources/org/apache/geode/management/internal/cli/commands/golden-help-offline.properties
Lines 1497 (patched)
<https://reviews.apache.org/r/57611/#comment241198>
no longer use
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57569/#review168842
---
Ship it!
Ship It!
- Kevin Duling
On March 13, 2017, 3:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57522/#review168841
---
Ship it!
Ship It!
- Kevin Duling
On March 13, 2017, 3:31
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15922902#comment-15922902
]
Kevin Duling commented on GEODE-2539:
-
{{9.3.11.v20160721}} is still too high
[
https://issues.apache.org/jira/browse/GEODE-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2633.
-
Resolution: Fixed
Fix Version/s: 1.2.0
> When turning on fine logging, GEODE logs
l, and have
> > gfsh connect to it using username and password, and see if any of the
> > password show up in the logs.
>
> Kevin Duling wrote:
> `ArgumentRedactorJUnitTest` already has 85% method coverage and 95% line
> coverage of `ArgumentRedactor`. `SocketCre
742e7f3e93e595844675d0789b995e4ceb4431ac
geode-core/src/main/java/org/apache/geode/internal/util/ArgumentRedactor.java
419f3f976159e601c95a2042bafd96cc9fe9465f
Diff: https://reviews.apache.org/r/57431/diff/1/
Testing (updated)
---
precheckin completed
Thanks,
Kevin Duling
Kevin Duling created GEODE-2650:
---
Summary: Need an integration test to scan logs for clear-text
passwords
Key: GEODE-2650
URL: https://issues.apache.org/jira/browse/GEODE-2650
Project: Geode
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2539.
-
Resolution: Fixed
> Upgrading Jetty causes RestSecurityIntegrationTest to f
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15912634#comment-15912634
]
Kevin Duling commented on GEODE-2539:
-
Per discussion on dev list, we are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57439/#review168794
---
Ship it!
Ship It!
- Kevin Duling
On March 8, 2017, 4:44 p.m
I've been working on GEODE-2539 to upgrade Jetty to the latest version.
But I've run in to some snags.
The last version that appears to work with Geode without any changes is
9.3.11. In 9.3.12, they made a change to add cookies rather than replace,
so some of our tests failed due to two JSESSION
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15903962#comment-15903962
]
Kevin Duling commented on GEODE-2539:
-
Jetty 9.4's API has changed sign
+1. Don't turn to the dark side of the --force.
On Mar 8, 2017 3:12 PM, "Dan Smith" wrote:
> Yeah, shared branches was kinda of a vague term. I am talking about
> develop, master, and release*.
>
> I think in general if you are working on a feature branch with along other
> people, you also shou
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reopened GEODE-2539:
-
Integration test failed as a result of this change. Backed out until resolved
> Upgrading Je
l, and have
> > gfsh connect to it using username and password, and see if any of the
> > password show up in the logs.
>
> Kevin Duling wrote:
> `ArgumentRedactorJUnitTest` already has 85% method coverage and 95% line
> coverage of `ArgumentRedactor`. `SocketCre
tically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57431/#review168333
-------
On March 8, 2017, 12:58 p.m., Kevin Duling wrote:
>
> ---
> This is an automatically generate
/apache/geode/internal/util/ArgumentRedactor.java
419f3f976159e601c95a2042bafd96cc9fe9465f
Diff: https://reviews.apache.org/r/57431/diff/1/
Testing
---
precheckin running
Thanks,
Kevin Duling
[
https://issues.apache.org/jira/browse/GEODE-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reassigned GEODE-2633:
---
Assignee: Kevin Duling
> When turning on fine logging, GEODE logs the keystore password
[
https://issues.apache.org/jira/browse/GEODE-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling updated GEODE-2633:
Component/s: gfsh
> When turning on fine logging, GEODE logs the keystore password in clear t
Kevin Duling created GEODE-2633:
---
Summary: When turning on fine logging, GEODE logs the keystore
password in clear text
Key: GEODE-2633
URL: https://issues.apache.org/jira/browse/GEODE-2633
Project
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2539.
-
Resolution: Fixed
Fix Version/s: 1.2.0
> Upgrading Jetty cau
20 times by hand locally without failure: `./gradlew
geode-assembly:integrationTest
-DintegrationTest.single=RestSecurityIntegrationTest`
Thanks,
Kevin Duling
-
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57390/#review168170
-------
On March 7, 2017, 9:48 a.m., Kevin Duling wrote:
>
>
`
Thanks,
Kevin Duling
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898395#comment-15898395
]
Kevin Duling commented on GEODE-2539:
-
Upgrading to 9.4.2.v20170220 cause
[
https://issues.apache.org/jira/browse/GEODE-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reassigned GEODE-2539:
---
Assignee: Kevin Duling
> Upgrading Jetty causes RestSecurityIntegrationTest to f
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57342/#review168035
---
Ship it!
Ship It!
- Kevin Duling
On March 6, 2017, 9:03 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57311/#review167987
---
Ship it!
Ship It!
- Kevin Duling
On March 3, 2017, 5:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57243/#review167900
---
Ship it!
Ship It!
- Kevin Duling
On March 3, 2017, 2:17 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57249/#review167718
---
Ship it!
Ship It!
- Kevin Duling
On March 2, 2017, 11:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57242/#review167696
---
Ship it!
Ship It!
- Kevin Duling
On March 2, 2017, 7:30 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57221/#review167606
---
Ship it!
Ship It!
- Kevin Duling
On March 1, 2017, 2:25 p.m
Diff: https://reviews.apache.org/r/57208/diff/2/
Changes: https://reviews.apache.org/r/57208/diff/1-2/
Testing
---
precheckin running
Thanks,
Kevin Duling
eviews.apache.org/r/57208/#review167411
---
On March 1, 2017, 9:56 a.m., Kevin Duling wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57208/
> -
[
https://issues.apache.org/jira/browse/GEODE-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2560.
-
Resolution: Fixed
Added a test to ensure the file exists prior to executing the copy.
> Miss
/diff/1/
Testing
---
precheckin running
Thanks,
Kevin Duling
[
https://issues.apache.org/jira/browse/GEODE-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reassigned GEODE-2560:
---
Assignee: Kevin Duling
> Missing disk files (.crf) during backup/restore throws except
Kevin Duling created GEODE-2560:
---
Summary: Missing disk files (.crf) during backup/restore throws
exception
Key: GEODE-2560
URL: https://issues.apache.org/jira/browse/GEODE-2560
Project: Geode
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57175/#review167291
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 28, 2017, 5:39 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57050/#review166761
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 24, 2017, 1:37 p.m
When starting a locator, gfsh has the --bind-address option to tie to a
particular NIC. E.g.,
start locator --name=loc-sec
--security-properties-file=./security.properties
--classpath=/Users/kduling/gfsh-security --bind-address=localhost
This address is the one the server uses to connect with.
after that.
geode-core/src/main/java/org/apache/geode/management/internal/cli/CliAroundInterceptor.java
(lines 47 - 55)
<https://reviews.apache.org/r/56991/#comment238602>
Incomplete javadoc. It should be either filled out or omitted.
- Kevin Duling
On Feb. 23, 2017, 10:01 a.m.,
[
https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2457.
-
Resolution: Fixed
Fix Version/s: 1.2.0
> Replace org.apache.geode.internal.FileUtil w
[
https://issues.apache.org/jira/browse/GEODE-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling reassigned GEODE-2457:
---
Assignee: Kevin Duling (was: Kirk Lund)
> Replace org.apache.geode.internal.FileUtil w
/
Testing (updated)
---
precheckin successful
Thanks,
Kevin Duling
4620f1deb03b76452df3a8d95daf4294573f02b0
Diff: https://reviews.apache.org/r/56801/diff/
Testing
---
precheckin running
Thanks,
Kevin Duling
.java
4620f1deb03b76452df3a8d95daf4294573f02b0
Diff: https://reviews.apache.org/r/56801/diff/
Testing
---
precheckin running
Thanks,
Kevin Duling
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56801/#review165975
-------
On Feb. 17, 2017, 1:09 p.m., Kevin Duling wrote:
>
> ---
> This
Thanks,
Kevin Duling
?
- Kevin Duling
On Feb. 15, 2017, 4:23 p.m., Kirk Lund wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56635/#review165732
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 13, 2017, 6:33 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56637/#review165731
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 14, 2017, 11 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56668/#review165730
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 14, 2017, 9:01 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56586/#review165367
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 12, 2017, 8:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56556/#review165158
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 10, 2017, 11:30
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56522/#review165050
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 9, 2017, 4:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56520/#review165028
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 9, 2017, 4:07 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56519/#review165025
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 9, 2017, 3:02 p.m
)
---
Log of UX on https://issues.apache.org/jira/browse/GEODE-2247
precheckin successful
Thanks,
Kevin Duling
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56516/#review164999
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 9, 2017, 12:06 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56514/#review164996
---
Ship it!
Ship It!
- Kevin Duling
On Feb. 9, 2017, 11:44 a.m
-2247
precheckin running
Thanks,
Kevin Duling
/geode/management/internal/web/shell/AbstractHttpOperationInvoker.java
fa052489772e3e03eb865d17dbbcb7e227813c42
Diff: https://reviews.apache.org/r/56459/diff/
Testing
---
Log of UX on https://issues.apache.org/jira/browse/GEODE-2247
precheckin running
Thanks,
Kevin Duling
[
https://issues.apache.org/jira/browse/GEODE-2247?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Duling resolved GEODE-2247.
-
Resolution: Fixed
Fix Version/s: 1.2.0
An issue was found in
> On Feb. 8, 2017, 9:02 a.m., Kevin Duling wrote:
> > `File.getParentFile()` may return null. For example, assume your working
> > directory is "/tmp". The call to
> > `File(".").getParentFile().getParentFile()` will return null.
>
> Jared S
working
directory is "/tmp". The call to `File(".").getParentFile().getParentFile()`
will return null.
- Kevin Duling
On Feb. 7, 2017, 7:03 p.m., Jinmei Liao wrote:
>
> ---
> This is an automatically gene
@After near the top of the
class. From the diffs, it looks like SecurityClusterConfigDUnitTest has an
@After at the very end.
- Kevin Duling
On Feb. 7, 2017, 9:28 a.m., Jinmei Liao wrote:
>
> ---
> This is an automatically generat
1 - 100 of 206 matches
Mail list logo
