Passed: apache/geode-native#2358 (rel/v1.12.0 - 8ddc0e8)

2020-03-30 Thread Travis CI
Build Update for apache/geode-native - Build: #2358 Status: Passed Duration: 1 hr, 17 mins, and 40 secs Commit: 8ddc0e8 (rel/v1.12.0) Author: Blake Bender Message: GEODE-7694: fix pdx type lookup (#572) - < operator should have used typeId, was using className

Re: [DISCUSS] Redundancy Gfsh Commands

2020-03-30 Thread Donal Evans
> > So the "restore redundancy" command is blocking and only returns when the > operation is finished? That's correct. The intention is to ensure that redundancy is recovered before other commands can be issued. On Mon, Mar 30, 2020 at 6:33 PM Jinmei Liao wrote: > So the "restore redundancy" c

Passed: apache/geode-examples#429 (rel/v1.12.0 - d3cc0b7)

2020-03-30 Thread Travis CI
Build Update for apache/geode-examples - Build: #429 Status: Passed Duration: 24 mins and 23 secs Commit: d3cc0b7 (rel/v1.12.0) Author: Owen Nichols Message: remove binaries View the changeset: https://github.com/apache/geode-examples/compare/rel/v1.12.0 View

Re: [DISCUSS] Redundancy Gfsh Commands

2020-03-30 Thread Jinmei Liao
So the "restore redundancy" command is blocking and only returns when the operation is finished? On 3/30/20, 2:21 PM, "Kirk Lund" wrote: [I added this as a comment on the wiki page] You might want to consider making RestoreRedundancyOperation actually extend CompletableFuture.

Re: [VOTE] Apache Geode 1.12.0.RC4

2020-03-30 Thread Blake Bender
We’re a little late to the party, but FWIW native client is also a +1. Mike Martell ran native tests on Windows, and Vince Ford validated it on Mac. Thanks, Blake On Mon, Mar 30, 2020 at 3:00 PM Ernest Burghardt wrote: > It's past the announced deadline and we have enough votes to close the >

Re: RFC: Add C Bindings to Geode Native Client

2020-03-30 Thread Jacob Barrett
https://github.com/pivotal-jbarrett/geode-native/tree/ee34cfbb5bddb55f5f890bb013c75d7780a787ae/ccache Quick stab at a POC for thread exception handling. -Jake

Re: [DISCUSS] Redundancy Gfsh Commands

2020-03-30 Thread Dan Smith
Looks good. I put a few comments inline (look for the yellow highlights). -Dan On Mon, Mar 30, 2020 at 2:21 PM Kirk Lund wrote: > [I added this as a comment on the wiki page] > > You might want to consider making RestoreRedundancyOperation actually > extend CompletableFuture. The interface is a

Re: [VOTE] Apache Geode 1.12.0.RC4

2020-03-30 Thread Aaron Lindsey
+1 (non-binding) Steps I took: - Built from source and ran unit tests - Used GFSH to create a locator and server and do some puts/gets - Checked version in GFSH - Built and ran all of the examples - Verified SHAs and signatures Aaron > On Mar 30, 2020, at 7:54 AM, Dave Barnes wrote: > > +1 > S

Re: [VOTE] Apache Geode 1.12.0.RC4

2020-03-30 Thread Ernest Burghardt
It's past the announced deadline and we have enough votes to close the vote. Voting status == +1: 4 binding votes * Anthony Baker (PMC member) * Dave Barnes (PMC member) * John Blum (PMC member) * Dan Smith (PMC member) +0: zero votes -0: zero votes -1: zero votes The voting meets the

Re: RFC: Add C Bindings to Geode Native Client

2020-03-30 Thread Jacob Barrett
> On Mar 30, 2020, at 10:32 AM, Blake Bender wrote: > > Just want to +1 on the use of a dynamic library - this really has to be a > shared lib, interop with most other languages demands it. On the other > hand, I'm not a huge fan of making this a separate library from the native > client itse

Re: RFC: Add C Bindings to Geode Native Client

2020-03-30 Thread Jacob Barrett
> On Mar 30, 2020, at 2:38 PM, Matthew Reddington > wrote: > Does it make sense to have the CacheFactory concept at all (especially > since it is more of a builder)? Could we have some C struct that can be > used to create the cache, where the struct has fields for all the > configuratio

Re: RFC: Add C Bindings to Geode Native Client

2020-03-30 Thread Matthew Reddington
>>>Does it make sense to have the CacheFactory concept at all (especially since it is more of a builder)? Could we have some C struct that can be used to create the cache, where the struct has fields for all the configuration? In general can we rethink the API so that it makes sense for C or other

Re: [DISCUSS] Redundancy Gfsh Commands

2020-03-30 Thread Kirk Lund
[I added this as a comment on the wiki page] You might want to consider making RestoreRedundancyOperation actually extend CompletableFuture. The interface is already very similar to Future, and if you extend CompletableFuture, then the user of the API can easily combine it with other CompletableFu

[DISCUSS] Redundancy Gfsh Commands

2020-03-30 Thread Donal Evans
Hey everyone, An RFC for adding gfsh commands to allow users to restore redundancy to partitioned regions and to easily check the redundancy status of partitioned regions has been posted: https://cwiki.apache.org/confluence/display/GEODE/Redundancy+Gfsh+Commands. Please review and comment on this

Re: RFC: Add C Bindings to Geode Native Client

2020-03-30 Thread Blake Bender
Just want to +1 on the use of a dynamic library - this really has to be a shared lib, interop with most other languages demands it. On the other hand, I'm not a huge fan of making this a separate library from the native client itself, simply because proliferation of binary files makes life difficu

Re: [VOTE] Apache Geode 1.12.0.RC4

2020-03-30 Thread Dave Barnes
+1 Successfully built User Guide with the provided Docker-based toolset. Successfully built javadocs. On Fri, Mar 27, 2020 at 2:56 PM Dan Smith wrote: > +1 > > Ran my release check > https://github.com/upthewaterspout/geode-release-check > > -Dan > > On Fri, Mar 27, 2020 at 1:33 PM John Blum wr

Re: RFC: Add C Bindings to Geode Native Client

2020-03-30 Thread Jacob Barrett
> On Mar 27, 2020, at 4:04 PM, Matthew Reddington > wrote: > * C does not have namespaces or overloading, so we will need a naming > convention to differentiate our types and methods from any other library or > the application code. That means all types and functions should be prepended > w