+1 (non-binding)

Steps I took:
- Built from source and ran unit tests
- Used GFSH to create a locator and server and do some puts/gets
- Checked version in GFSH
- Built and ran all of the examples
- Verified SHAs and signatures

Aaron

> On Mar 30, 2020, at 7:54 AM, Dave Barnes <dbar...@apache.org> wrote:
> 
> +1
> Successfully built User Guide with the provided Docker-based toolset.
> Successfully built javadocs.
> 
> On Fri, Mar 27, 2020 at 2:56 PM Dan Smith <dsm...@pivotal.io> wrote:
> 
>> +1
>> 
>> Ran my release check
>> https://github.com/upthewaterspout/geode-release-check
>> 
>> -Dan
>> 
>> On Fri, Mar 27, 2020 at 1:33 PM John Blum <jb...@pivotal.io> wrote:
>> 
>>> SDG continues to build with the Apache Geode 1.12.0 RC4 bits.
>>> 
>>> https://jenkins.spring.io/job/spring-data-geode/job/master-next/16/
>>> https://github.com/spring-projects/spring-data-geode/commits/master-next
>>> 
>>> +1
>>> 
>>> 
>>> On Fri, Mar 27, 2020 at 1:23 PM Anthony Baker <aba...@apache.org> wrote:
>>> 
>>>> +1
>>>> 
>>>> Things I checked:
>>>> - expected files present
>>>> - hashes and signatures present and valid
>>>> - geode, geode-benchmarks, and geode-examples build from source
>>>> - no binaries present in source distributions
>>>> - verified that geode source and binary distributions have the correct
>>>> SHA's
>>>> - able to create a cluster and do region operations using gfsh
>>>> - brief license review, no Cat X dependencies found
>>>> 
>>>> Nitpicking:
>>>> 
>>>> 1) Let's be consistent with names of source distribution and
>> extensions.
>>>> 2) NOTICE file copyright date needs to be updated for -native,
>>>> -benchmark, -examples.
>>>> 3) Some of the version numbers in LICENSE need to updated to match,
>>>> also need to add asm-5.0.4.jar
>>>> 
>>>> Anthony
>>>> 
>>>> On Fri, Mar 27, 2020 at 11:37 AM Ernest Burghardt <
>> eburgha...@pivotal.io
>>>> 
>>>> wrote:
>>>>> 
>>>>> Hello Geode Dev Community,
>>>>> 
>>>>> This is a release candidate for Apache Geode version 1.12.0.RC4.
>>>>> Thanks to all the community members for their contributions to this
>>>> release!
>>>>> 
>>>>> Please do a review and give your feedback, including the checks you
>>>>> performed.
>>>>> 
>>>>> Voting deadline:
>>>>> 3PM PST Mon, March 30, 2020.
>>>>> 
>>>>> Please note that we are voting upon the source tag:
>>>>> rel/v1.12.0.RC4
>>>>> 
>>>>> Release notes:
>>>>> 
>>>> 
>>> 
>> https://cwiki.apache.org/confluence/display/GEODE/Release+Notes#ReleaseNotes-1.12.0
>>>>> 
>>>>> Source and binary distributions:
>>>>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC4/
>>>>> 
>>>>> Maven staging repo:
>>>>> 
>> https://repository.apache.org/content/repositories/orgapachegeode-1068
>>>>> 
>>>>> GitHub:
>>>>> https://github.com/apache/geode/tree/rel/v1.12.0.RC4
>>>>> https://github.com/apache/geode-examples/tree/rel/v1.12.0.RC4
>>>>> https://github.com/apache/geode-native/tree/rel/v1.12.0.RC4
>>>>> https://github.com/apache/geode-benchmarks/tree/rel/v1.12.0.RC4
>>>>> 
>>>>> Pipelines:
>>>>> 
>>>> 
>>> 
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-main
>>>>> 
>>>> 
>>> 
>> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-release-1-12-0-rc
>>>>> 
>>>>> Geode's KEYS file containing PGP keys we use to sign the release:
>>>>> https://github.com/apache/geode/blob/develop/KEYS
>>>>> 
>>>>> Command to run geode-examples:
>>>>> ./gradlew -PgeodeReleaseUrl=
>>>>> https://dist.apache.org/repos/dist/dev/geode/1.12.0.RC4
>>>>> -PgeodeRepositoryUrl=
>>>>> 
>> https://repository.apache.org/content/repositories/orgapachegeode-1068
>>>>> build runAll
>>>>> 
>>>>> Regards
>>>>> Ernie Burghardt
>>>> 
>>> 
>>> 
>>> --
>>> -John
>>> Spring Data Team
>>> 
>> 

Reply via email to