Re: Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-08 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/ --- (Updated Aug. 9, 2017, 4:52 a.m.) Review request for geode, Emily Yeh, Jared St

Build failed in Jenkins: Geode-nightly #917

2017-08-08 Thread Apache Jenkins Server
See Changes: [klund] GEODE-3073: Renamed OrderByComparatorUnmapped to OrderByComparatorMapped -- [...truncated 1.46 MB...] at org.apache.geode.distributed.internal.In

[GitHub] geode pull request #698: Mark ProtoBuf interface as experimental

2017-08-08 Thread pivotal-amurmann
GitHub user pivotal-amurmann opened a pull request: https://github.com/apache/geode/pull/698 Mark ProtoBuf interface as experimental Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the fo

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #641 was SUCCESSFUL (with 2027 tests). Change made by John Blum.

2017-08-08 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #641 was successful. --- Scheduled with changes by John Blum. 2029 tests in total. https://build.spring.io/browse

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182443 --- Ship it! Ship It! - Ken Howe On Aug. 8, 2017, 9:10 p.m., Jin

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182442 --- Ship it! Ship It! - Jared Stewart On Aug. 8, 2017, 9:10 p.m.

[GitHub] geode issue #664: Fix for GEODE-3292

2017-08-08 Thread jinmeiliao
Github user jinmeiliao commented on the issue: https://github.com/apache/geode/pull/664 I will pull this in the moment I got a green pipeline --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-08 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61420/#review182441 --- Ship it! Ship It! - Udo Kohlmeyer On Aug. 3, 2017, 10:07 p.m

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182440 --- Ship it! - Ken Howe On Aug. 8, 2017, 9:10 p.m., Jinmei Liao w

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jinmei Liao
> On Aug. 7, 2017, 8:21 p.m., Jared Stewart wrote: > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > > Lines 140 (patched) > > > > > > Can you clarify something for me

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Ken Howe
> On Aug. 7, 2017, 8:21 p.m., Jared Stewart wrote: > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > > Lines 140 (patched) > > > > > > Can you clarify something for me

Re: Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-08 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/#review182436 --- Fix it, then Ship it! Other than the SSLConfigurationFactory ch

Review Request 61507: GEODE-3313: Test utility supports building jar files with multiple classes

2017-08-08 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61507/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/ --- (Updated Aug. 8, 2017, 9:10 p.m.) Review request for geode, Emily Yeh, Jared St

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182434 --- geode-cq/src/test/java/org/apache/geode/security/ClientCQAuthDUni

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61480/#review182433 --- Ship it! Ship It! - Jared Stewart On Aug. 7, 2017, 8:13 p.m.

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jinmei Liao
> On Aug. 7, 2017, 8:21 p.m., Jared Stewart wrote: > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > > Lines 140 (patched) > > > > > > Can you clarify something for me

Re: Gitbox enables the full GitHub workflow

2017-08-08 Thread Mark Bretl
+1 for Gitbox I have been watching threads on INFRA list and been waiting to see when a good time would be to introduce the idea to the community. The Gitbox project has been going since the end of 2016 and looks as though it might be ready now as INFRA has begun moving some of their repositories

Review Request 61506: GEODE-3328: refactor ConnectCommand

2017-08-08 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61506/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, Patrick

Re: continuous query internal mechanism

2017-08-08 Thread Anilkumar Gingade
Registered events, i meant, are events generated for interest registration "region.registerInterest(*)". And CqEvents are for CQs registered. -Anil. On Tue, Aug 8, 2017 at 12:27 AM, Roi Apelker wrote: > Shukriya > > What is the difference between registered events and CQ events? > > -Origi

Re: Review Request 61420: GEODE-3307 CI failure: Uncaught exception in thread Thread[Geode Membership View Creator

2017-08-08 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61420/#review182413 --- Ship it! geode-core/src/main/java/org/apache/geode/distributed

Re: Gitbox enables the full GitHub workflow

2017-08-08 Thread Dan Smith
I'm in favor of switching to gitbox. We're already getting pretty much all contributions from non-committers coming in as pull requests so we might as well make it easier for us to manage things in github. -Dan On Tue, Aug 8, 2017 at 8:57 AM, Kirk Lund wrote: > One thing that's given me trouble

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

2017-08-08 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131974883 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java --- @@ -74,17 +73,6 @@ public static final l

[GitHub] geode pull request #683: GEODE-3314 - additional refactoring for developer Q...

2017-08-08 Thread pivotal-amurmann
Github user pivotal-amurmann commented on a diff in the pull request: https://github.com/apache/geode/pull/683#discussion_r131977004 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java --- @@ -1433,29 +1412,7 @@ public boolean lockInter

Re: Review Request 61166: GEODE-3313: Test utility supports building jar files with multiple classes

2017-08-08 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61166/ --- (Updated Aug. 8, 2017, 5:14 p.m.) Review request for geode, Emily Yeh, Jared St

Re: Review Request 61480: GEODE-3330: user needs CLUSTER:MANAGE:QUERY permission to create a CQ.

2017-08-08 Thread Jared Stewart
> On Aug. 7, 2017, 8:21 p.m., Jared Stewart wrote: > > geode-cq/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/ExecuteCQ61.java > > Lines 140 (patched) > > > > > > Can you clarify something for me

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

2017-08-08 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/#review182405 --- Ship it! Ship It! - Jared Stewart On Aug. 8, 2017, 4:38 p.m.

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

2017-08-08 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/668#discussion_r131968121 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java --- @@ -111,10 +113,31 @@ public void testCach

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

2017-08-08 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/668#discussion_r131967266 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java --- @@ -2596,6 +2596,18 @@ private void endDeclarable()

[GitHub] geode pull request #668: GEODE-3306: Remove whitespace StringBuffers/nodes c...

2017-08-08 Thread jaredjstewart
Github user jaredjstewart commented on a diff in the pull request: https://github.com/apache/geode/pull/668#discussion_r131966460 --- Diff: geode-core/src/test/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParserJUnitTest.java --- @@ -128,9 +128,16 @@ public void testCache

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

2017-08-08 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/ --- (Updated Aug. 8, 2017, 4:38 p.m.) Review request for geode, Emily Yeh, Jinmei L

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

2017-08-08 Thread Kirk Lund
> On Aug. 8, 2017, 1:04 a.m., Jared Stewart wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java > > Line 292 (original), 292 (patched) > > > > > > I might be missing

Re: Gitbox enables the full GitHub workflow

2017-08-08 Thread Kirk Lund
One thing that's given me trouble is that the mirroring of ASF git (for Apache Geode) to github can have a lengthy delay. In other words, after I commit to ASF git, it's not uncommon for my commit to not show up in the GitHub mirror right away and I've seen this delay take an hour. On Mon, Aug 7,

Re: Review Request 61487: GEODE-3407: fix deadlock between JMX and reconnect

2017-08-08 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/#review182391 --- geode-core/src/main/java/org/apache/geode/management/internal/bea

RE: Need to know complete execution time for geode-core Junit tests

2017-08-08 Thread Dinesh Akhand
Thanks Darrel It works on Linux. But there I see another failure: :geode-core:distributedTest org.apache.geode.internal.cache.FixedPRSinglehopDUnitTest > testMetadataInClientWithFixedPartitions FAILED java.lang.AssertionError: bucket 3 was incorrect expected:<20189> but was:<29785>

RE: continuous query internal mechanism

2017-08-08 Thread Roi Apelker
Shukriya What is the difference between registered events and CQ events? -Original Message- From: Anilkumar Gingade [mailto:aging...@pivotal.io] Sent: Monday, August 07, 2017 10:12 PM To: dev@geode.apache.org Subject: Re: continuous query internal mechanism CQ Processing on server side