Github user jaredjstewart commented on a diff in the pull request:
https://github.com/apache/geode/pull/668#discussion_r131967266
--- Diff:
geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/CacheXmlParser.java
---
@@ -2596,6 +2596,18 @@ private void endDeclarable() {
public void startElement(String namespaceURI, String localName, String
qName, Attributes atts)
throws SAXException {
+ // This while loop pops all StringBuffers at the top of the stack
+ // that contain only whitespace; see GEODE-3306
+ while (!stack.empty()) {
+ Object o = stack.peek();
+ if (o instanceof StringBuffer
+ && ((StringBuffer) o).toString().replaceAll("\\s",
"").equals("")) {
--- End diff --
I think `StringUtils.isBlank( (StringBuffer o).toString())` might be
simpler here as well as in `endElement`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
