Re: Review Request 54915: GEODE-2215: GatewaySenderAdvisor checks the current processor to see if it has started

2016-12-20 Thread xiaojian zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54915/#review159786 --- Ship it! Ship It! - xiaojian zhou On Dec. 20, 2016, 9:58 p.m

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread Amey Barve (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766067#comment-15766067 ] Amey Barve commented on GEODE-1754: --- Thanks Bruce for your detailed review, I have updat

Build failed in Jenkins: Geode-nightly #691

2016-12-20 Thread Apache Jenkins Server
See Changes: [abarve] GEODE-1541 : Made statsListUniqueId to be an AtomicLong. This closes [bschuchardt] GEODE-1550 MembershipJUnitTest.testMultipleManagersInSameProcess failure [bschuchardt] GEODE-1580: [bschuchardt] GEODE-2215 NPE in

[jira] [Commented] (GEODE-165) Add build support for generating antlr classes from grammar

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15766001#comment-15766001 ] ASF GitHub Bot commented on GEODE-165: -- Github user davinash commented on the issue:

[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...

2016-12-20 Thread davinash
Github user davinash commented on the issue: https://github.com/apache/geode/pull/322 Thanks @upthewaterspout , Is this PR good for merge to develop now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Assigned] (GEODE-728) Rename Execution.withArgs to Execution.setArguments

2016-12-20 Thread Alyssa Kim (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Kim reassigned GEODE-728: Assignee: Alyssa Kim (was: Dan Smith) > Rename Execution.withArgs to Execution.setArguments > -

[jira] [Updated] (GEODE-2238) Member may fail to receive cluster configuration from locator

2016-12-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-2238: - Summary: Member may fail to receive cluster configuration from locator (was: LuceneClusterConfigurationD

[jira] [Assigned] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith reassigned GEODE-2238: Assignee: Dan Smith > LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterC

Review Request 54924: GEODE-2238: Fix how peers discover locators with cluster config

2016-12-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54924/ --- Review request for geode, Jinmei Liao, Kevin Duling, and Kirk Lund. Repository:

Re: Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

2016-12-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/#review159783 --- I don't think we should mark this test flaky, I think we should fi

[jira] [Updated] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dan Smith updated GEODE-2238: - Component/s: (was: lucene) (was: tests) management > LuceneClust

[jira] [Commented] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Dan Smith (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765782#comment-15765782 ] Dan Smith commented on GEODE-2238: -- I was able to reproduce this running the test in my I

[jira] [Commented] (GEODE-165) Add build support for generating antlr classes from grammar

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765744#comment-15765744 ] ASF GitHub Bot commented on GEODE-165: -- Github user upthewaterspout commented on the i

[GitHub] geode issue #322: [GEODE-165] Fix for Add build support for generating antlr...

2016-12-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/322 +1 Awesome!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

New proposal for type definitons

2016-12-20 Thread Udo Kohlmeyer
Hey there, I've just completed a new proposal on the wiki for a new mechanism that could be used to define a type definition for an object. https://cwiki.apache.org/confluence/display/GEODE/Custom+External+Type+Definition+Proposal+for+JSON Primarily the new type definition proposal will hopef

Re: Review Request 54918: GEODE-2099: The GfshConnectorRule has been refactored to use awaitility to wait and retry till connection is ready.

2016-12-20 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54918/#review159775 --- Ship it! Ship It! - Kevin Duling On Dec. 20, 2016, 2:57 p.m.

Review Request 54918: GEODE-2099: The GfshConnectorRule has been refactored to use awaitility to wait and retry till connection is ready.

2016-12-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54918/ --- Review request for geode, Jared Stewart, Kevin Duling, and Kirk Lund. Repositor

Re: Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

2016-12-20 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/#review159773 --- Ship it! Ship It! - Kevin Duling On Dec. 20, 2016, 2:46 p.m.

[jira] [Assigned] (GEODE-2099) Race condition in ConnectToLocatorSSLDUnitTest

2016-12-20 Thread Jinmei Liao (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinmei Liao reassigned GEODE-2099: -- Assignee: Jinmei Liao > Race condition in ConnectToLocatorSSLDUnitTest > --

Re: Review Request 54586: GEODE-2172: CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

2016-12-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54586/#review159770 --- Ship it! Ship It! - Jinmei Liao On Dec. 19, 2016, 12:45 p.m.

Re: Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

2016-12-20 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/#review159771 --- Ship it! Ship It! - Jinmei Liao On Dec. 20, 2016, 10:46 p.m.

Re: Review Request 54586: GEODE-2172: CustomConfigWithCacheIntegrationTest fails with AssertionError on Windows

2016-12-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54586/#review159768 --- Ship it! Ship It! - Kirk Lund On Dec. 19, 2016, 12:45 p.m.,

Review Request 54917: GEODE-2238: add FlakyTest category to flaky test

2016-12-20 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54917/ --- Review request for geode, Jason Huynh and Dan Smith. Bugs: GEODE-2238 https

[jira] [Updated] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2238: - Affects Version/s: 1.0.0-incubating > LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsin

[jira] [Updated] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2238: - Labels: Flaky (was: ) > LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfi

[jira] [Created] (GEODE-2238) LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError

2016-12-20 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2238: Summary: LuceneClusterConfigurationDUnitTest.indexWithAnalyzerGetsCreatedUsingClusterConfiguration fails with AssertionError Key: GEODE-2238 URL: https://issues.apache.org/jira/browse/GE

[jira] [Updated] (GEODE-2119) gfsh user and password visible in clear text

2016-12-20 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling updated GEODE-2119: Affects Version/s: 1.0.0-incubating > gfsh user and password visible in clear text > ---

[jira] [Commented] (GEODE-2119) gfsh user and password visible in clear text

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765444#comment-15765444 ] ASF GitHub Bot commented on GEODE-2119: --- Github user asfgit closed the pull request

[GitHub] geode pull request #311: GEODE-2119: gfsh user and password in clear text

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (GEODE-2119) gfsh user and password visible in clear text

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765443#comment-15765443 ] ASF subversion and git services commented on GEODE-2119: Commit 2f

[jira] [Commented] (GEODE-2119) gfsh user and password visible in clear text

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765423#comment-15765423 ] ASF subversion and git services commented on GEODE-2119: Commit 4e

[jira] [Commented] (GEODE-2119) gfsh user and password visible in clear text

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765419#comment-15765419 ] ASF subversion and git services commented on GEODE-2119: Commit 3f

[jira] [Commented] (GEODE-2109) calling submit on ExecutionService can cause exceptions to be lost

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765414#comment-15765414 ] ASF GitHub Bot commented on GEODE-2109: --- Github user upthewaterspout commented on th

[GitHub] geode issue #296: GEODE-2109 : Calling submit on ExecutionService can cause ...

2016-12-20 Thread upthewaterspout
Github user upthewaterspout commented on the issue: https://github.com/apache/geode/pull/296 Hi @deepakddixit Sorry for the slow response. I'm a little concerned that with your changes to the test in ef4d38d, the test is no longer actually testing what happens if the runnabl

[jira] [Created] (GEODE-2237) Geode product classes should use Log4J2 Logger instead of JUL or LogWriter

2016-12-20 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-2237: Summary: Geode product classes should use Log4J2 Logger instead of JUL or LogWriter Key: GEODE-2237 URL: https://issues.apache.org/jira/browse/GEODE-2237 Project: Geode

[jira] [Assigned] (GEODE-2237) Geode product classes should use Log4J2 Logger instead of JUL or LogWriter

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-2237: Assignee: Kirk Lund > Geode product classes should use Log4J2 Logger instead of JUL or LogWriter >

The right way to remove a region's cache listener?

2016-12-20 Thread Kevin Duling
I'm looking at GEODE-2236 and protecting against the NPE is trivial. But the question is, what is the right way to do this? What is the syntax people would expect to use? What if there are multiple listeners and you wanted to delete one or more

Re: Review Request 54916: GEODE-2215: Fixed flakiness of ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread

2016-12-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/#review159759 --- geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concu

Re: Review Request 54914: GEODE-1943: Minor modification to SessionReplicationIntegrationJUnitTest.testInvalidateSession9

2016-12-20 Thread Dan Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54914/#review159758 --- Ship it! Ship It! - Dan Smith On Dec. 20, 2016, 9:56 p.m., J

[jira] [Created] (GEODE-2236) Attempting to remove all CacheListeners from a Region using gfsh throws NullPointerException

2016-12-20 Thread Kevin Duling (JIRA)
Kevin Duling created GEODE-2236: --- Summary: Attempting to remove all CacheListeners from a Region using gfsh throws NullPointerException Key: GEODE-2236 URL: https://issues.apache.org/jira/browse/GEODE-2236

Review Request 54916: GEODE-2215: Fixed flakiness of ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread

2016-12-20 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54916/ --- Review request for geode, nabarun nag and Dan Smith. Repository: geode Descri

Review Request 54915: GEODE-2215: GatewaySenderAdvisor checks the current processor to see if it has started

2016-12-20 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54915/ --- Review request for geode and xiaojian zhou. Repository: geode Description ---

Review Request 54914: GEODE-1943: Minor modification to SessionReplicationIntegrationJUnitTest.testInvalidateSession9

2016-12-20 Thread Jason Huynh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54914/ --- Review request for geode, nabarun nag and Dan Smith. Repository: geode Descri

[jira] [Resolved] (GEODE-2210) Session module class loader should check the thread context class loader

2016-12-20 Thread Jason Huynh (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Huynh resolved GEODE-2210. Resolution: Fixed > Session module class loader should check the thread context class loader > -

[jira] [Resolved] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

2016-12-20 Thread Kevin Duling (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Duling resolved GEODE-2188. - Resolution: Fixed > ExampleSecurityManager references SampleSecurityManager in javadoc > -

[jira] [Created] (GEODE-2235) test is missing @Test: PrCqUsingPoolDUnitTest.testCqOnAccessorServerWithUpdatesResultingInDestroyedCQEvents

2016-12-20 Thread Bruce Schuchardt (JIRA)
Bruce Schuchardt created GEODE-2235: --- Summary: test is missing @Test: PrCqUsingPoolDUnitTest.testCqOnAccessorServerWithUpdatesResultingInDestroyedCQEvents Key: GEODE-2235 URL: https://issues.apache.org/jira/brow

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765029#comment-15765029 ] ASF GitHub Bot commented on GEODE-1754: --- Github user bschuchardt commented on the is

[GitHub] geode issue #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argument fr...

2016-12-20 Thread bschuchardt
Github user bschuchardt commented on the issue: https://github.com/apache/geode/pull/323 Amey, if you don't mind I'm going to merge your commit with my fixes for GEODE-1893. I'm removing the peerLocator & serverLocator options for starting a locator and it's hitting the same code you

Re: Review Request 54879: GEODE-1893 remove ability to create a locator without all location services

2016-12-20 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54879/#review159738 --- Ship it! Ship It! - Udo Kohlmeyer On Dec. 19, 2016, 11:26 p.

[jira] [Resolved] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2167. -- Resolution: Fixed Fix Version/s: 1.1.0 > BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fai

[jira] [Resolved] (GEODE-2207) IntegratedSecurityCacheLifecycleDistributedTest is disabled and needs to be fixed

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-2207. -- Resolution: Fixed Fix Version/s: 1.1.0 > IntegratedSecurityCacheLifecycleDistributedTest is disab

[jira] [Updated] (GEODE-2207) IntegratedSecurityCacheLifecycleDistributedTest is disabled and needs to be fixed

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-2207: - Affects Version/s: 1.0.0-incubating > IntegratedSecurityCacheLifecycleDistributedTest is disabled and need

[jira] [Updated] (GEODE-1541) statsListUniqueId should be an AtomicLong

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1541: - Affects Version/s: 1.0.0-incubating > statsListUniqueId should be an AtomicLong >

[jira] [Commented] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764880#comment-15764880 ] ASF GitHub Bot commented on GEODE-2167: --- Github user vectorijk commented on the issu

[jira] [Commented] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-20 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764893#comment-15764893 ] Barry Oglesby commented on GEODE-2234: -- I moved the queryExecution stat manipulation

[jira] [Assigned] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-20 Thread Barry Oglesby (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Barry Oglesby reassigned GEODE-2234: Assignee: Barry Oglesby > Lucene query hit stats shows number higher than number of calls >

[jira] [Updated] (GEODE-1541) statsListUniqueId should be an AtomicLong

2016-12-20 Thread Kirk Lund (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-1541: - Fix Version/s: 1.1.0 > statsListUniqueId should be an AtomicLong > ---

[jira] [Created] (GEODE-2234) Lucene query hit stats shows number higher than number of calls

2016-12-20 Thread Barry Oglesby (JIRA)
Barry Oglesby created GEODE-2234: Summary: Lucene query hit stats shows number higher than number of calls Key: GEODE-2234 URL: https://issues.apache.org/jira/browse/GEODE-2234 Project: Geode

[GitHub] geode issue #308: [GEODE-2167] BundledJarsJUnitTest fails on Windows

2016-12-20 Thread vectorijk
Github user vectorijk commented on the issue: https://github.com/apache/geode/pull/308 Thanks for the review @jinmeiliao @kirklund @metatype --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[jira] [Commented] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764806#comment-15764806 ] ASF GitHub Bot commented on GEODE-2167: --- Github user asfgit closed the pull request

[GitHub] geode pull request #308: [GEODE-2167] BundledJarsJUnitTest fails on Windows

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/308 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (GEODE-2167) BundledJarsJUnitTest.verifyBundledJarsHaveNotChanged fails with java.nio.file.InvalidPathException on Windows

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764804#comment-15764804 ] ASF subversion and git services commented on GEODE-2167: Commit 40

[jira] [Updated] (GEODE-2232) Rename GemFireConfigException

2016-12-20 Thread Karen Smoler Miller (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Smoler Miller updated GEODE-2232: --- Component/s: docs > Rename GemFireConfigException > - > >

[jira] [Created] (GEODE-2233) CI Failure ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread

2016-12-20 Thread Dan Smith (JIRA)
Dan Smith created GEODE-2233: Summary: CI Failure ConcurrentParallelGatewaySenderOperation_2_DUnitTest.shuttingOneSenderInAVMShouldNotAffectOthersBatchRemovalThread Key: GEODE-2233 URL: https://issues.apache.org/jira/

[jira] [Commented] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

2016-12-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764732#comment-15764732 ] ASF subversion and git services commented on GEODE-2188: Commit 7c

[jira] [Commented] (GEODE-2188) ExampleSecurityManager references SampleSecurityManager in javadoc

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764733#comment-15764733 ] ASF GitHub Bot commented on GEODE-2188: --- Github user asfgit closed the pull request

[GitHub] geode pull request #316: GEODE-2188: ExampleSecurityManager references Sampl...

2016-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764593#comment-15764593 ] ASF GitHub Bot commented on GEODE-1754: --- Github user bschuchardt commented on a diff

[jira] [Commented] (GEODE-1754) InternalLocator.startLocator needs to be cleaned up

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15764592#comment-15764592 ] ASF GitHub Bot commented on GEODE-1754: --- Github user bschuchardt commented on a diff

[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...

2016-12-20 Thread bschuchardt
Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/323#discussion_r93273525 --- Diff: geode-core/src/main/java/org/apache/geode/internal/DistributionLocator.java --- @@ -166,9 +166,9 @@ public void run() { try {

[GitHub] geode pull request #323: GEODE-1754: Cleaned up loadSharedConfigFromDir argu...

2016-12-20 Thread bschuchardt
Github user bschuchardt commented on a diff in the pull request: https://github.com/apache/geode/pull/323#discussion_r93273028 --- Diff: geode-core/src/main/java/org/apache/geode/distributed/Locator.java --- @@ -253,7 +253,7 @@ private static Locator startLocator(int port, File lo

[jira] [Commented] (GEODE-1969) oplog closed while writing to oplog with gemfire.syncWrites=true

2016-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GEODE-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763897#comment-15763897 ] ASF GitHub Bot commented on GEODE-1969: --- Github user shankarh commented on the issue

[GitHub] geode issue #320: GEODE-1969 : oplog closed while writing to oplog with gemf...

2016-12-20 Thread shankarh
Github user shankarh commented on the issue: https://github.com/apache/geode/pull/320 Thanks @dschneider-pivotal for the review. Will add the unit test. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe