----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54879/#review159738 -----------------------------------------------------------
Ship it! Ship It! - Udo Kohlmeyer On Dec. 19, 2016, 11:26 p.m., Bruce Schuchardt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54879/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 11:26 p.m.) > > > Review request for geode and Udo Kohlmeyer. > > > Bugs: GEODE-1893 > https://issues.apache.org/jira/browse/GEODE-1893 > > > Repository: geode > > > Description > ------- > > Deprecated API options for creating a locator without peerLocation or > serverLocation handlers. There will be documentation work to do since the > docs mention this in at least one place. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java > 536e4b63cd6893409b40f09061793b782f01f66c > geode-core/src/main/java/org/apache/geode/distributed/Locator.java > 049ead477cea6e52b518c30f19c0ae37c838a47d > geode-core/src/main/java/org/apache/geode/distributed/LocatorLauncher.java > d7048044512f773c5d121fb3f27c734f421f0a98 > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalDistributedSystem.java > 95aa7df17e584aff2bfa901145fdc789681b571c > > geode-core/src/main/java/org/apache/geode/distributed/internal/InternalLocator.java > 18eee7081f7c99effbacf3f00304b2af2e5b0ddc > geode-core/src/main/java/org/apache/geode/internal/DistributionLocator.java > e0de2bd97aba9f033cf5766f918863d751d09580 > > geode-core/src/main/java/org/apache/geode/internal/admin/remote/DistributionLocatorId.java > f724292ccd905143982be0ddc1b5e79300455932 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/LocatorMBeanBridge.java > 9544a96884030f1e929d862696a5c5f6382fc077 > geode-core/src/test/java/org/apache/geode/distributed/LocatorJUnitTest.java > 8be0e7a191c135440885b669172c80aaae98a498 > > geode-core/src/test/java/org/apache/geode/distributed/internal/InternalDistributedSystemJUnitTest.java > 07c6f38d5e3ae9275ad7700419ba0669251a937f > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/MembershipJUnitTest.java > eeb2d9b2563e85355a40e8528843d43d02a21359 > > geode-core/src/test/java/org/apache/geode/distributed/internal/membership/gms/locator/GMSLocatorRecoveryJUnitTest.java > 489d4b8d0f4b3836790c7f1503d5d717bd647001 > > geode-wan/src/main/java/org/apache/geode/cache/client/internal/locator/wan/LocatorHelper.java > 9038bb808531e71a0855fe5a1974ffe8fc19547c > > Diff: https://reviews.apache.org/r/54879/diff/ > > > Testing > ------- > > Precheckin. I removed a couple of unit tests that were checking if it's > possible to create a locator without one of these services. > > > Thanks, > > Bruce Schuchardt > >
