[
https://issues.apache.org/jira/browse/GEODE-1754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15765029#comment-15765029
]
ASF GitHub Bot commented on GEODE-1754:
---------------------------------------
Github user bschuchardt commented on the issue:
https://github.com/apache/geode/pull/323
Amey, if you don't mind I'm going to merge your commit with my fixes for
GEODE-1893. I'm removing the peerLocator & serverLocator options for starting
a locator and it's hitting the same code you've modified.
> InternalLocator.startLocator needs to be cleaned up
> ---------------------------------------------------
>
> Key: GEODE-1754
> URL: https://issues.apache.org/jira/browse/GEODE-1754
> Project: Geode
> Issue Type: Task
> Components: management
> Reporter: Bruce Schuchardt
> Assignee: Amey Barve
>
> InternalLocator.startLocator was modified to have a loadSharedConfigFromDir
> parameter that is never used. It should be removed.
> {noformat}
> /**
> * Creates a distribution locator that runs in this VM on the given
> * port and bind address.
> *
> * This is for internal use only as it does not create a distributed
> * system unless told to do so.
> *
> * @param port
> * the tcp/ip port to listen on
> * @param logFile
> * the file that log messages should be written to
> * @param logger
> * a log writer that should be used (logFile parameter is ignored)
> * @param securityLogger
> * the logger to be used for security related log messages
> * @param startDistributedSystem
> * if true, a distributed system is started
> * @param dsProperties
> * optional properties to configure the distributed system (e.g., mcast
> addr/port, other locators)
> * @param peerLocator
> * enable peer location services
> * @param enableServerLocator
> * enable server location services
> * @param hostnameForClients
> * the name to give to clients for connecting to this locator
> * @param loadSharedConfigFromDir TODO:CONFIG
> * @throws IOException
> */
> public static InternalLocator startLocator(
> int port,
> File logFile,
> File stateFile,
> InternalLogWriter logger,
> InternalLogWriter securityLogger,
> InetAddress bindAddress,
> boolean startDistributedSystem,
> java.util.Properties dsProperties,
> boolean peerLocator,
> boolean enableServerLocator,
> String hostnameForClients,
> boolean loadSharedConfigFromDir
> )
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
